squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-22 08:27:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix empty tooltips showed at the progress bar borders

Browse Source 
If tooltip text contains an empty HTML body, Qt still shows it as an
empty rectangle. Thus, output HTML tags only if we are within the
image region, and return true empty string if we are at the borders.
This commit is contained in:
Eugene Shalygin
2016-06-02 20:51:57 +02:00
parent 95fbff3a53
commit 0b1a9220a9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/gui/properties/piecesbar.cpp
View File

@@ -253,11 +253,11 @@ void PiecesBar::showToolTip(const QHelpEvent *e)
QTextStream stream(&toolTipText, QIODevice::WriteOnly); QTextStream stream(&toolTipText, QIODevice::WriteOnly);
bool showDetailedInformation = QApplication::keyboardModifiers().testFlag(Qt::ShiftModifier); bool showDetailedInformation = QApplication::keyboardModifiers().testFlag(Qt::ShiftModifier);
if (showDetailedInformation) { if (showDetailedInformation) {
stream << "<html><body>";
const int imagePos = e->pos().x() - borderWidth; const int imagePos = e->pos().x() - borderWidth;
if ((imagePos >=0) && (imagePos < m_image.width())) { if ((imagePos >=0) && (imagePos < m_image.width())) {
stream << "<html><body>";
PieceIndexToImagePos transform {m_torrent->info(), m_image}; PieceIndexToImagePos transform {m_torrent->info(), m_image};
int pieceIndex = transform.pieceIndex(e->pos().x() - borderWidth); int pieceIndex = transform.pieceIndex(imagePos);
QVector<int> files {m_torrent->info().fileIndicesForPiece(pieceIndex)}; QVector<int> files {m_torrent->info().fileIndicesForPiece(pieceIndex)};
QString tooltipTitle; QString tooltipTitle;
@@ -281,8 +281,8 @@ void PiecesBar::showToolTip(const QHelpEvent *e)
renderer(Utils::Misc::friendlyUnit(m_torrent->info().fileSize(f)), filePath); renderer(Utils::Misc::friendlyUnit(m_torrent->info().fileSize(f)), filePath);
} }
stream << "</body></html>";
} }
stream << "</body></html>";
} }
else { else {
stream << simpleToolTipText(); stream << simpleToolTipText();