squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-17 14:08:03 -06:00
Code Issues Packages Projects Releases Wiki Activity

WebUI: prevent passing wrong parameter

Browse Source 
The `event` object will be passed as the first parameter to the event handler. So wrap the
event handler with a closure to prevent `event` leaking to other functions.
This commit is contained in:
Chocobo1
2024-08-09 15:52:46 +08:00
parent e069fbc37f
commit 1179fc3de3
4 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/webui/www/private/scripts/contextmenu.js
View File

@@ -440,7 +440,7 @@ window.qBittorrent.ContextMenu ??= (() => {
const createMenuItem = (text, imgURL, clickFn) => {
const anchor = document.createElement("a");
anchor.textContent = text;
anchor.addEventListener("click", clickFn);
anchor.addEventListener("click", () => { clickFn(); });
const img = document.createElement("img");
img.src = imgURL;
@@ -495,7 +495,7 @@ window.qBittorrent.ContextMenu ??= (() => {
const createMenuItem = (text, imgURL, clickFn) => {
const anchor = document.createElement("a");
anchor.textContent = text;
anchor.addEventListener("click", clickFn);
anchor.addEventListener("click", () => { clickFn(); });
const img = document.createElement("img");
img.src = imgURL;