From 2bd09659060dc4548bec858469aa25ef8d867121 Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Sun, 24 Aug 2025 20:15:51 +0800 Subject: [PATCH] WebUI: remove redundant braces in switch `statements` Braces are only required when there are variable/function declarations. --- src/webui/www/eslint.config.mjs | 3 ++- src/webui/www/private/scripts/dynamicTable.js | 10 ++++------ src/webui/www/private/scripts/search.js | 3 +-- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/webui/www/eslint.config.mjs b/src/webui/www/eslint.config.mjs index fbd1e4d27..7056136d8 100644 --- a/src/webui/www/eslint.config.mjs +++ b/src/webui/www/eslint.config.mjs @@ -69,7 +69,8 @@ export default [ "Stylistic/semi": "error", "Stylistic/spaced-comment": ["error", "always", { exceptions: ["*"] }], "Unicorn/no-zero-fractions": "error", - "Unicorn/prefer-number-properties": "error" + "Unicorn/prefer-number-properties": "error", + "Unicorn/switch-case-braces": ["error", "avoid"] } } ]; diff --git a/src/webui/www/private/scripts/dynamicTable.js b/src/webui/www/private/scripts/dynamicTable.js index 252c224d0..8ac518e11 100644 --- a/src/webui/www/private/scripts/dynamicTable.js +++ b/src/webui/www/private/scripts/dynamicTable.js @@ -183,18 +183,17 @@ window.qBittorrent.DynamicTable ??= (() => { return; switch (e.key) { - case "ArrowUp": { + case "ArrowUp": e.preventDefault(); this.selectPreviousRow(); this.dynamicTableDiv.querySelector(".selected").scrollIntoView({ block: "nearest" }); break; - } - case "ArrowDown": { + + case "ArrowDown": e.preventDefault(); this.selectNextRow(); this.dynamicTableDiv.querySelector(".selected").scrollIntoView({ block: "nearest" }); break; - } } }); } @@ -1632,7 +1631,7 @@ window.qBittorrent.DynamicTable ??= (() => { return false; break; // do nothing - default: { + default: if (!useSubcategories) { if (category !== row["full_data"].category) return false; @@ -1647,7 +1646,6 @@ window.qBittorrent.DynamicTable ??= (() => { } } break; - } } switch (tag) { diff --git a/src/webui/www/private/scripts/search.js b/src/webui/www/private/scripts/search.js index 5dba42a50..e7e484c52 100644 --- a/src/webui/www/private/scripts/search.js +++ b/src/webui/www/private/scripts/search.js @@ -142,7 +142,7 @@ window.qBittorrent.Search ??= (() => { document.getElementById("SearchPanel").addEventListener("keydown", (event) => { switch (event.key) { - case "Enter": { + case "Enter": event.preventDefault(); event.stopPropagation(); @@ -156,7 +156,6 @@ window.qBittorrent.Search ??= (() => { } break; - } } });