GHA CI: fix broken retry when packaging for macOS

Failed CI instance: https://github.com/qbittorrent/qBittorrent/actions/runs/16437290836/job/46449723244
Follow up bb1c02125b.

PR #23036.

.github/workflows/ci_macos.yaml

@@ -122,25 +122,24 @@ jobs:
 
       - name: Prepare build artifacts
         run: |
-          # create .dmg
           appName="qbittorrent"
           if [ "${{ matrix.qbt_gui }}" = "GUI=OFF" ]; then
             appName="qbittorrent-nox"
           fi
-          # package
           pushd build
-          PACKAGE_RETRY=0
-          while [ "$PACKAGE_RETRY" -lt "3" ]; do
+          # packaging
           macdeployqt "$appName.app" -no-strip
-            # sign
+          # code signing
           xattr -cr "$appName.app"
           codesign --force --sign - --options runtime \
+            "$appName.app" \
             "$appName.app/Contents/Frameworks"/* \
-              "$appName.app/Contents/MacOS/$appName" \
-              "$appName.app"
+            "$appName.app/Contents/MacOS/$appName"
           codesign --verify --deep --strict -v "$appName.app"
-            hdiutil create -fs HFS+ -srcfolder "$appName.app" -volname "$appName" "$appName.dmg"
-            if [ -f "$appName.dmg" ]; then
+          # create .dmg
+          PACKAGE_RETRY=0
+          while [ "$PACKAGE_RETRY" -lt "3" ]; do
+            if hdiutil create -fs HFS+ -srcfolder "$appName.app" -volname "$appName" "$appName.dmg"; then
               break
             fi
             sleep 5