Set dialog properties at the caller site

Redundant `setModal(true)` are removed since the dialog is already opened via `open()`.
This commit is contained in:
Chocobo1
2022-06-02 19:51:26 +08:00
parent ab0c82965c
commit 3fd0241abb
11 changed files with 30 additions and 32 deletions

View File

@@ -66,7 +66,6 @@ PluginSelectDialog::PluginSelectDialog(SearchPluginManager *pluginManager, QWidg
, m_pluginManager(pluginManager)
{
m_ui->setupUi(this);
setAttribute(Qt::WA_DeleteOnClose);
m_ui->pluginsTree->setRootIsDecorated(false);
m_ui->pluginsTree->hideColumn(PLUGIN_ID);
@@ -89,7 +88,6 @@ PluginSelectDialog::PluginSelectDialog(SearchPluginManager *pluginManager, QWidg
connect(m_pluginManager, &SearchPluginManager::checkForUpdatesFailed, this, &PluginSelectDialog::checkForUpdatesFailed);
resize(m_storeDialogSize);
show();
}
PluginSelectDialog::~PluginSelectDialog()
@@ -346,8 +344,10 @@ void PluginSelectDialog::finishPluginUpdate()
void PluginSelectDialog::on_installButton_clicked()
{
auto *dlg = new PluginSourceDialog(this);
dlg->setAttribute(Qt::WA_DeleteOnClose);
connect(dlg, &PluginSourceDialog::askForLocalFile, this, &PluginSelectDialog::askForLocalPlugin);
connect(dlg, &PluginSourceDialog::askForUrl, this, &PluginSelectDialog::askForPluginUrl);
dlg->show();
}
void PluginSelectDialog::askForPluginUrl()

View File

@@ -39,10 +39,8 @@ PluginSourceDialog::PluginSourceDialog(QWidget *parent)
, m_storeDialogSize(SETTINGS_KEY(u"Size"_qs))
{
m_ui->setupUi(this);
setAttribute(Qt::WA_DeleteOnClose);
resize(m_storeDialogSize);
show();
}
PluginSourceDialog::~PluginSourceDialog()

View File

@@ -286,7 +286,9 @@ void SearchWidget::toggleFocusBetweenLineEdits()
void SearchWidget::on_pluginsButton_clicked()
{
new PluginSelectDialog(SearchPluginManager::instance(), this);
auto *dlg = new PluginSelectDialog(SearchPluginManager::instance(), this);
dlg->setAttribute(Qt::WA_DeleteOnClose);
dlg->show();
}
void SearchWidget::searchTextEdited(const QString &)