squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-22 16:37:21 -06:00
Code Issues Packages Projects Releases Wiki Activity

Convert pass-by-value arguments to const refs where applicable

Browse Source
This commit is contained in:
thalieht
2019-02-12 02:45:30 +02:00
parent ca3ce87e06
commit 445adb0ab4
18 changed files with 84 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/gui/mainwindow.cpp
View File

@@ -849,7 +849,7 @@ void MainWindow::finishedTorrent(BitTorrent::TorrentHandle *const torrent) const
}
// Notification when disk is full
void MainWindow::fullDiskError(BitTorrent::TorrentHandle *const torrent, QString msg) const
void MainWindow::fullDiskError(BitTorrent::TorrentHandle *const torrent, const QString &msg) const
{
showNotificationBaloon(tr("I/O Error", "i.e: Input/Output Error")
, tr("An I/O error occurred for torrent '%1'.\n Reason: %2"
@@ -963,7 +963,7 @@ void MainWindow::askRecursiveTorrentDownloadConfirmation(BitTorrent::TorrentHand
confirmBox->show();
}
void MainWindow::handleDownloadFromUrlFailure(QString url, QString reason) const
void MainWindow::handleDownloadFromUrlFailure(const QString &url, const QString &reason) const
{
// Display a message box
showNotificationBaloon(tr("URL download error")
@@ -1061,7 +1061,7 @@ bool MainWindow::unlockUI()
return true;
}
void MainWindow::notifyOfUpdate(QString)
void MainWindow::notifyOfUpdate(const QString &)
{
// Show restart message
m_statusBar->showRestartRequired();
@@ -1565,7 +1565,7 @@ void MainWindow::updateGUI()
}
}
void MainWindow::showNotificationBaloon(QString title, QString msg) const
void MainWindow::showNotificationBaloon(const QString &title, const QString &msg) const
{
if (!isNotificationsEnabled()) return;
#if (defined(Q_OS_UNIX) && !defined(Q_OS_MAC)) && defined(QT_DBUS_LIB)

8
src/gui/mainwindow.h
View File

@@ -99,20 +99,20 @@ public:
void activate();
void cleanup();
void showNotificationBaloon(QString title, QString msg) const;
void showNotificationBaloon(const QString &title, const QString &msg) const;
private slots:
void showFilterContextMenu(const QPoint &);
void balloonClicked();
void writeSettings();
void readSettings();
void fullDiskError(BitTorrent::TorrentHandle *const torrent, QString msg) const;
void handleDownloadFromUrlFailure(QString, QString) const;
void fullDiskError(BitTorrent::TorrentHandle *const torrent, const QString &msg) const;
void handleDownloadFromUrlFailure(const QString &, const QString &) const;
void tabChanged(int newTab);
bool defineUILockPassword();
void clearUILockPassword();
bool unlockUI();
void notifyOfUpdate(QString);
void notifyOfUpdate(const QString &);
void showConnectionSettings();
void minimizeWindow();
// Keyboard shortcuts

2
src/gui/properties/trackerlistwidget.cpp
View File

@@ -149,7 +149,7 @@ QList<QTreeWidgetItem*> TrackerListWidget::getSelectedTrackerItems() const
return selectedTrackers;
}
void TrackerListWidget::setRowColor(const int row, QColor color)
void TrackerListWidget::setRowColor(const int row, const QColor &color)
{
const int nbColumns = columnCount();
QTreeWidgetItem *item = topLevelItem(row);

2
src/gui/properties/trackerlistwidget.h
View File

@@ -69,7 +69,7 @@ public:
int visibleColumnsCount() const;
public slots:
void setRowColor(int row, QColor color);
void setRowColor(int row, const QColor &color);
void moveSelectionUp();
void moveSelectionDown();

8
src/gui/search/pluginselectdialog.cpp
View File

@@ -228,7 +228,7 @@ void PluginSelectDialog::enableSelection(bool enable)
}
// Set the color of a row in data model
void PluginSelectDialog::setRowColor(const int row, QString color)
void PluginSelectDialog::setRowColor(const int row, const QString &color)
{
QTreeWidgetItem *item = m_ui->pluginsTree->topLevelItem(row);
for (int i = 0; i < m_ui->pluginsTree->columnCount(); ++i) {
@@ -236,7 +236,7 @@ void PluginSelectDialog::setRowColor(const int row, QString color)
}
}
QList<QTreeWidgetItem*> PluginSelectDialog::findItemsWithUrl(QString url)
QList<QTreeWidgetItem*> PluginSelectDialog::findItemsWithUrl(const QString &url)
{
QList<QTreeWidgetItem*> res;
@@ -249,7 +249,7 @@ QList<QTreeWidgetItem*> PluginSelectDialog::findItemsWithUrl(QString url)
return res;
}
QTreeWidgetItem *PluginSelectDialog::findItemWithID(QString id)
QTreeWidgetItem *PluginSelectDialog::findItemWithID(const QString &id)
{
for (int i = 0; i < m_ui->pluginsTree->topLevelItemCount(); ++i) {
QTreeWidgetItem *item = m_ui->pluginsTree->topLevelItem(i);
@@ -268,7 +268,7 @@ void PluginSelectDialog::loadSupportedSearchPlugins()
addNewPlugin(name);
}
void PluginSelectDialog::addNewPlugin(QString pluginName)
void PluginSelectDialog::addNewPlugin(const QString &pluginName)
{
QTreeWidgetItem *item = new QTreeWidgetItem(m_ui->pluginsTree);
PluginInfo *plugin = m_pluginManager->pluginInfo(pluginName);

8
src/gui/search/pluginselectdialog.h
View File

@@ -51,8 +51,8 @@ public:
explicit PluginSelectDialog(SearchPluginManager *pluginManager, QWidget *parent = nullptr);
~PluginSelectDialog();
QList<QTreeWidgetItem*> findItemsWithUrl(QString url);
QTreeWidgetItem *findItemWithID(QString id);
QList<QTreeWidgetItem*> findItemsWithUrl(const QString &url);
QTreeWidgetItem *findItemWithID(const QString &id);
protected:
void dropEvent(QDropEvent *event) override;
@@ -64,7 +64,7 @@ private slots:
void on_installButton_clicked();
void on_closeButton_clicked();
void togglePluginState(QTreeWidgetItem*, int);
void setRowColor(int row, QString color);
void setRowColor(int row, const QString &color);
void displayContextMenu(const QPoint &pos);
void enableSelection(bool enable);
void askForLocalPlugin();
@@ -81,7 +81,7 @@ private slots:
private:
void loadSupportedSearchPlugins();
void addNewPlugin(QString pluginName);
void addNewPlugin(const QString &pluginName);
void startAsyncOp();
void finishAsyncOp();
void finishPluginUpdate();

2
src/gui/search/searchwidget.cpp
View File

@@ -280,7 +280,7 @@ void SearchWidget::on_pluginsButton_clicked()
new PluginSelectDialog(SearchPluginManager::instance(), this);
}
void SearchWidget::searchTextEdited(QString)
void SearchWidget::searchTextEdited(const QString &)
{
// Enable search button
m_ui->searchButton->setText(tr("Search"));

2
src/gui/search/searchwidget.h
View File

@@ -74,7 +74,7 @@ private:
void fillCatCombobox();
void fillPluginComboBox();
void selectActivePage();
void searchTextEdited(QString);
void searchTextEdited(const QString &);
void updateButtons();
QString selectedCategory() const;

6
src/gui/transferlistwidget.cpp
View File

@@ -338,7 +338,7 @@ TransferListModel *TransferListWidget::getSourceModel() const
return m_listModel;
}
void TransferListWidget::previewFile(QString filePath)
void TransferListWidget::previewFile(const QString &filePath)
{
Utils::Misc::openPath(filePath);
}
@@ -854,7 +854,7 @@ void TransferListWidget::renameSelectedTorrent()
}
}
void TransferListWidget::setSelectionCategory(QString category)
void TransferListWidget::setSelectionCategory(const QString &category)
{
for (const QModelIndex &index : asConst(selectionModel()->selectedRows()))
m_listModel->setData(m_listModel->index(mapToSource(index).row(), TransferListModel::TR_CATEGORY), category, Qt::DisplayRole);
@@ -1173,7 +1173,7 @@ void TransferListWidget::currentChanged(const QModelIndex &current, const QModel
emit currentTorrentChanged(torrent);
}
void TransferListWidget::applyCategoryFilter(QString category)
void TransferListWidget::applyCategoryFilter(const QString &category)
{
if (category.isNull())
m_sortFilterModel->disableCategoryFilter();

6
src/gui/transferlistwidget.h
View File

@@ -56,7 +56,7 @@ public:
TransferListModel *getSourceModel() const;
public slots:
void setSelectionCategory(QString category);
void setSelectionCategory(const QString &category);
void addSelectionTag(const QString &tag);
void removeSelectionTag(const QString &tag);
void clearSelectionTags();
@@ -90,11 +90,11 @@ public slots:
void displayDLHoSMenu(const QPoint&);
void applyNameFilter(const QString &name);
void applyStatusFilter(int f);
void applyCategoryFilter(QString category);
void applyCategoryFilter(const QString &category);
void applyTagFilter(const QString &tag);
void applyTrackerFilterAll();
void applyTrackerFilter(const QStringList &hashes);
void previewFile(QString filePath);
void previewFile(const QString &filePath);
void renameSelectedTorrent();
protected: