Remove closed connections immediately

Previously it relied on a timer to drop dead connections but that proved to
be too slow when there is an incoming burst of connections.

Fixes #10487.

src/base/http/server.cpp

@@ -98,15 +98,22 @@ void Server::incomingConnection(qintptr socketDescriptor)
 
     Connection *c = new Connection(serverSocket, m_requestHandler, this);
     m_connections.append(c);
+    connect(serverSocket, &QAbstractSocket::disconnected, this, [c, this]() { removeConnection(c); });
+}
+
+void Server::removeConnection(Connection *connection)
+{
+    m_connections.removeOne(connection);
+    connection->deleteLater();
 }
 
 void Server::dropTimedOutConnection()
 {
     QMutableListIterator<Connection *> i(m_connections);
     while (i.hasNext()) {
-        auto connection = i.next();
+        Connection *connection = i.next();
-        if (connection->isClosed() || connection->hasExpired(KEEP_ALIVE_DURATION)) {
+        if (connection->hasExpired(KEEP_ALIVE_DURATION)) {
-            delete connection;
+            connection->deleteLater();
             i.remove();
         }
     }

src/base/http/server.h

@@ -63,6 +63,7 @@ namespace Http
 
     private:
         void incomingConnection(qintptr socketDescriptor);
+        void removeConnection(Connection *connection);
 
         IRequestHandler *m_requestHandler;
         QList<Connection *> m_connections;  // for tracking persistent connections