squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-31 20:58:07 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8325 from luis-pereira/prevent-c++11-range-loop-detach

Browse Source 
Prevent possible c++11 range-loop container detach
This commit is contained in:
Vladimir Golovnev
2018-02-22 16:28:04 +03:00
committed by GitHub
parent edef85fa3e 1a913c502b
commit 5c2f698cb4
7 changed files with 35 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/gui/ipsubnetwhitelistoptionsdialog.cpp
View File

@@ -34,6 +34,7 @@
#include <QSortFilterProxyModel>
#include <QStringListModel>
#include "base/global.h"
#include "base/preferences.h"
#include "base/utils/net.h"
#include "ui_ipsubnetwhitelistoptionsdialog.h"
@@ -47,7 +48,7 @@ IPSubnetWhitelistOptionsDialog::IPSubnetWhitelistOptionsDialog(QWidget *parent)
m_ui->setupUi(this);
QStringList authSubnetWhitelistStringList;
for (const Utils::Net::Subnet &subnet : Preferences::instance()->getWebUiAuthSubnetWhitelist())
for (const Utils::Net::Subnet &subnet : copyAsConst(Preferences::instance()->getWebUiAuthSubnetWhitelist()))
authSubnetWhitelistStringList << Utils::Net::subnetToString(subnet);
m_model = new QStringListModel(authSubnetWhitelistStringList, this);
@@ -100,7 +101,7 @@ void IPSubnetWhitelistOptionsDialog::on_buttonWhitelistIPSubnet_clicked()
void IPSubnetWhitelistOptionsDialog::on_buttonDeleteIPSubnet_clicked()
{
for (const auto &i : m_ui->whitelistedIPSubnetList->selectionModel()->selectedIndexes())
for (const auto &i : copyAsConst(m_ui->whitelistedIPSubnetList->selectionModel()->selectedIndexes()))
m_sortFilter->removeRow(i.row());
m_modified = true;

5
src/gui/properties/speedplotview.cpp
View File

@@ -30,6 +30,7 @@
#include <QPainter>
#include <QPen>
#include "base/global.h"
#include "base/utils/misc.h"
SpeedPlotView::SpeedPlotView(QWidget *parent)
@@ -257,7 +258,7 @@ void SpeedPlotView::paintEvent(QPaintEvent *)
double legendHeight = 0;
int legendWidth = 0;
for (const auto &property : m_properties) {
for (const auto &property : qAsConst(m_properties)) {
if (!property.enable)
continue;
@@ -272,7 +273,7 @@ void SpeedPlotView::paintEvent(QPaintEvent *)
painter.fillRect(legendBackgroundRect, legendBackgroundColor);
i = 0;
for (const auto &property : m_properties) {
for (const auto &property : qAsConst(m_properties)) {
if (!property.enable)
continue;