squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-18 14:38:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

Replace QScopedPointer with std::unqiue_ptr

Browse Source 
These 2 types are very similar and we should prefer the one from C++
standard library, this reduces the number of types in our code base.

Also see:
https://stackoverflow.com/questions/40346393/should-i-use-qscopedpointer-or-stdunique-ptr#comment67966940_40346991
This commit is contained in:
Chocobo1
2019-02-16 12:29:57 +08:00
parent 78ab0e4ba9
commit 5e3fddf456
7 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/gui/fspathedit.cpp
View File

@@ -28,6 +28,8 @@
#include "fspathedit.h"
#include <memory>
#include <QAction>
#include <QApplication>
#include <QCoreApplication>
@@ -74,7 +76,7 @@ class FileSystemPathEdit::FileSystemPathEditPrivate
QString dialogCaptionOrDefault() const;
FileSystemPathEdit *q_ptr;
QScopedPointer<Private::FileEditorWithCompletion> m_editor;
std::unique_ptr<Private::FileEditorWithCompletion> m_editor;
QAction *m_browseAction;
QToolButton *m_browseBtn;
QString m_fileNameFilter;
@@ -192,7 +194,10 @@ FileSystemPathEdit::FileSystemPathEdit(Private::FileEditorWithCompletion *editor
connect(d->m_browseAction, &QAction::triggered, this, [this]() { this->d_func()->browseActionTriggered(); });
}
FileSystemPathEdit::~FileSystemPathEdit() = default;
FileSystemPathEdit::~FileSystemPathEdit()
{
delete d_ptr;
}
QString FileSystemPathEdit::selectedPath() const
{