squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-17 14:08:03 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improve "split to byte array views" function

Browse Source 
1. Utilize string matcher
2. Remove split behavior parameter
   Previously `KeepEmptyParts` behavior doesn't match Qt's
   implementation and since our codebase doesn't really make use of it,
   we can just remove the parameter.
3. Add tests.

PR #22352.
This commit is contained in:
Chocobo1
2025-03-03 21:42:03 +08:00
committed by GitHub
parent 96295adc08
commit 62a7fd86d6
9 changed files with 67 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/base/http/requestparser.cpp
View File

@@ -279,7 +279,7 @@ bool RequestParser::parsePostMessage(const QByteArrayView data)
// split data by "dash-boundary"
const QByteArray dashDelimiter = QByteArray("--") + delimiter + CRLF;
QList<QByteArrayView> multipart = splitToViews(data, dashDelimiter, Qt::SkipEmptyParts);
QList<QByteArrayView> multipart = splitToViews(data, dashDelimiter);
if (multipart.isEmpty())
{
qWarning() << Q_FUNC_INFO << "multipart empty";