squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2026-01-01 13:18:06 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improve "split to byte array views" function

Browse Source 
1. Utilize string matcher
2. Remove split behavior parameter
   Previously `KeepEmptyParts` behavior doesn't match Qt's
   implementation and since our codebase doesn't really make use of it,
   we can just remove the parameter.
3. Add tests.

PR #22352.
This commit is contained in:
Chocobo1
2025-03-03 21:42:03 +08:00
committed by GitHub
parent 96295adc08
commit 62a7fd86d6
9 changed files with 67 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/gui/search/searchwidget.cpp
View File

@@ -172,8 +172,10 @@ namespace
return nonstd::make_unexpected(readResult.error().message);
}
const QList<QByteArrayView> lines = Utils::ByteArray::splitToViews(readResult.value(), "\n");
QStringList history;
for (const QByteArrayView line : asConst(Utils::ByteArray::splitToViews(readResult.value(), "\n")))
history.reserve(lines.size());
for (const QByteArrayView line : lines)
history.append(QString::fromUtf8(line));
return history;