squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-17 22:18:05 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant null checks

Browse Source 
Attempting to delete a null pointer is a noop in C++.

Closes #2864.

[1] https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null
This commit is contained in:
NotTsunami
2020-02-03 16:38:46 -05:00
parent c78604c7d3
commit 6748e8d787
14 changed files with 37 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/base/bittorrent/session.cpp
View File

@@ -977,8 +977,7 @@ Session::~Session()
// We must delete FilterParserThread
// before we delete lt::session
if (m_filterParser)
delete m_filterParser;
delete m_filterParser;
// We must delete PortForwarderImpl before
// we delete lt::session
@@ -1002,10 +1001,8 @@ void Session::initInstance()
void Session::freeInstance()
{
if (m_instance) {
delete m_instance;
m_instance = nullptr;
}
delete m_instance;
m_instance = nullptr;
}
Session *Session::instance()
@@ -1605,8 +1602,7 @@ void Session::enableTracker(const bool enable)
m_tracker->start();
}
else {
if (m_tracker)
delete m_tracker;
delete m_tracker;
}
}