squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-17 06:01:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

WebUI: prefer for loop over Array.forEach method

Browse Source 
The `for` loop can do everything `forEach` can and doesn't need a closure.
This commit is contained in:
Chocobo1
2025-08-24 18:34:10 +08:00
parent 2be052e9c4
commit 6ac0c5a8b8
12 changed files with 58 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/webui/www/private/scripts/dynamicTable.js
View File

@@ -603,10 +603,10 @@ window.qBittorrent.DynamicTable ??= (() => {
const val = LocalPreferences.get(`columns_order_${this.dynamicTableDivId}`);
if ((val === null) || (val === undefined))
return;
val.split(",").forEach((v) => {
for (const v of val.split(",")) {
if ((v in this.columns) && (!columnsOrder.contains(v)))
columnsOrder.push(v);
});
}
for (let i = 0; i < this.columns.length; ++i) {
if (!columnsOrder.contains(this.columns[i].name))
@@ -2474,9 +2474,8 @@ window.qBittorrent.DynamicTable ??= (() => {
populateTable(root) {
this.fileTree.setRoot(root);
root.children.forEach((node) => {
for (const node of root.children)
this.#addNodeToTable(node, 0, root);
});
}
#addNodeToTable(node, depth, parent) {
@@ -2490,9 +2489,8 @@ window.qBittorrent.DynamicTable ??= (() => {
rowId: node.rowId,
});
node.children.forEach((child) => {
for (const child of node.children)
this.#addNodeToTable(child, depth + 1, node);
});
}
getRoot() {