squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2026-01-01 05:08:05 -06:00
Code Issues Packages Projects Releases Wiki Activity

Provide interface for serialization to string type

Browse Source 
PR #16685.
This commit is contained in:
Chocobo1
2022-03-23 12:55:41 +08:00
committed by GitHub
parent b7c098c5e6
commit 6c10aa33e1
5 changed files with 62 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/base/settingsstorage.h
View File

@@ -34,9 +34,10 @@
#include <QObject>
#include <QReadWriteLock>
#include <QTimer>
#include <QVariant>
#include <QVariantHash>
#include "path.h"
#include "base/interfaces/istringable.h"
#include "utils/string.h"
template <typename T>
@@ -45,7 +46,11 @@ struct IsQFlags : std::false_type {};
template <typename T>
struct IsQFlags<QFlags<T>> : std::true_type {};
class SettingsStorage : public QObject
// There are 2 ways for class `T` provide serialization support into `SettingsStorage`:
// 1. If the `T` state is intended for users to edit (via a text editor), then
// implement `IStringable` interface
// 2. Otherwise, use `Q_DECLARE_METATYPE(T)` and let `QMetaType` handle the serialization
class SettingsStorage final : public QObject
{
Q_OBJECT
SettingsStorage();
@@ -59,7 +64,12 @@ public:
template <typename T>
T loadValue(const QString &key, const T &defaultValue = {}) const
{
if constexpr (std::is_enum_v<T>)
if constexpr (std::is_base_of_v<IStringable, T>)
{
const QString value = loadValue(key, defaultValue.toString());
return T {value};
}
else if constexpr (std::is_enum_v<T>)
{
const auto value = loadValue<QString>(key);
return Utils::String::toEnum(value, defaultValue);
@@ -69,11 +79,6 @@ public:
const typename T::Int value = loadValue(key, static_cast<typename T::Int>(defaultValue));
return T {value};
}
else if constexpr (std::is_same_v<T, Path>)
{
const auto value = loadValue<QString>(key, defaultValue.toString());
return Path(value);
}
else if constexpr (std::is_same_v<T, QVariant>)
{
// fast path for loading QVariant
@@ -90,12 +95,12 @@ public:
template <typename T>
void storeValue(const QString &key, const T &value)
{
if constexpr (std::is_enum_v<T>)
if constexpr (std::is_base_of_v<IStringable, T>)
storeValueImpl(key, value.toString());
else if constexpr (std::is_enum_v<T>)
storeValueImpl(key, Utils::String::fromEnum(value));
else if constexpr (IsQFlags<T>::value)
storeValueImpl(key, static_cast<typename T::Int>(value));
else if constexpr (std::is_same_v<T, Path>)
storeValueImpl(key, value.toString());
else
storeValueImpl(key, QVariant::fromValue(value));
}