squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2026-01-10 01:22:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

WebUI: prefer arrow functions whenever applicable

Browse Source 
Compared to plain function, arrow function is simpler to understand (without bindings to `this`, `arguments`, `super`) and to read.
Now, plain function will only be used when this object is required.

PR #21691.
This commit is contained in:
Chocobo1
2024-11-01 04:17:41 +08:00
committed by GitHub
parent 7af6ac18aa
commit 72cbc83569
49 changed files with 574 additions and 570 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/webui/www/private/views/searchplugins.html
View File

@@ -92,7 +92,7 @@
let prevOffsetLeft;
let prevOffsetTop;
const setup = function() {
const setup = () => {
searchPluginsTable = new window.qBittorrent.DynamicTable.SearchPluginsTable();
searchPluginsTableContextMenu = new window.qBittorrent.ContextMenu.SearchPluginsTableContextMenu({
targets: ".searchPluginsTableRow",
@@ -107,11 +107,11 @@
updateTable();
};
const closeSearchWindow = function(id) {
const closeSearchWindow = (id) => {
window.parent.MochaUI.closeWindow(window.parent.$(id));
};
const installPlugin = function(path) {
const installPlugin = (path) => {
new MochaUI.Window({
id: "installSearchPlugin",
icon: "images/qbittorrent-tray.svg",
@@ -128,7 +128,7 @@
});
};
const uninstallPlugin = function() {
const uninstallPlugin = () => {
const plugins = searchPluginsTable.selectedRowsIds().join("|");
const url = new URI("api/v2/search/uninstallPlugin");
new Request({
@@ -140,7 +140,7 @@
}).send();
};
const enablePlugin = function() {
const enablePlugin = () => {
const plugins = searchPluginsTable.selectedRowsIds();
let enable = true;
if (plugins && plugins.length)
@@ -157,7 +157,7 @@
}).send();
};
const checkForUpdates = function() {
const checkForUpdates = () => {
const url = new URI("api/v2/search/updatePlugins");
new Request({
url: url,
@@ -165,7 +165,7 @@
}).send();
};
const calculateContextMenuOffsets = function() {
const calculateContextMenuOffsets = () => {
prevOffsetLeft = document.getElementById("searchPlugins").getBoundingClientRect().left;
prevOffsetTop = document.getElementById("searchPlugins").getBoundingClientRect().top;
@@ -175,13 +175,13 @@
};
};
const updateSearchPluginsTableContextMenuOffset = function() {
const updateSearchPluginsTableContextMenuOffset = () => {
// only re-calculate if window has moved
if ((prevOffsetLeft !== document.getElementById("searchPlugins").getBoundingClientRect().left) || (prevOffsetTop !== document.getElementById("searchPlugins").getBoundingClientRect().top))
searchPluginsTableContextMenu.options.offsets = calculateContextMenuOffsets();
};
const setupSearchPluginTableEvents = function(enable) {
const setupSearchPluginTableEvents = (enable) => {
const clickHandler = (e) => { enablePlugin(); };
const menuHandler = (e) => { updateSearchPluginsTableContextMenuOffset(); };
if (enable) {
@@ -198,7 +198,7 @@
}
};
const updateTable = function() {
const updateTable = () => {
// clear event listeners
setupSearchPluginTableEvents(false);