squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2026-01-03 06:02:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use const accessor

Browse Source 
This avoids an unnecessary check to the container internal atomic variable and prevents
potential detachment.

PR #22280.
This commit is contained in:
Chocobo1
2025-02-16 15:51:40 +08:00
committed by GitHub
parent ddf6dd5fa2
commit 8da43a4054
11 changed files with 45 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/gui/torrentcontentmodelfolder.cpp
View File

@@ -97,7 +97,7 @@ void TorrentContentModelFolder::updatePriority()
// If all children have the same priority
// then the folder should have the same
// priority
const BitTorrent::DownloadPriority prio = m_childItems.first()->priority();
const BitTorrent::DownloadPriority prio = m_childItems.constFirst()->priority();
for (int i = 1; i < m_childItems.size(); ++i)
{
if (m_childItems.at(i)->priority() != prio)

4
src/gui/uithememanager.cpp
View File

@@ -199,8 +199,8 @@ QIcon UIThemeManager::getFlagIcon(const QString &countryIsoCode) const
return {};
const QString key = countryIsoCode.toLower();
const auto iter = m_flags.find(key);
if (iter != m_flags.end())
const auto iter = m_flags.constFind(key);
if (iter != m_flags.cend())
return *iter;
const QIcon icon {u":/icons/flags/" + key + u".svg"};

4
src/gui/uithemesource.cpp
View File

@@ -175,7 +175,7 @@ void DefaultThemeSource::loadColors()
const QHash<QString, QColor> lightModeColorOverrides = colorsFromJSON(config.value(KEY_COLORS_LIGHT).toObject());
for (auto overridesIt = lightModeColorOverrides.cbegin(); overridesIt != lightModeColorOverrides.cend(); ++overridesIt)
{
auto it = m_colors.find(overridesIt.key());
const auto it = m_colors.find(overridesIt.key());
if (it != m_colors.end())
it.value().light = overridesIt.value();
}
@@ -183,7 +183,7 @@ void DefaultThemeSource::loadColors()
const QHash<QString, QColor> darkModeColorOverrides = colorsFromJSON(config.value(KEY_COLORS_DARK).toObject());
for (auto overridesIt = darkModeColorOverrides.cbegin(); overridesIt != darkModeColorOverrides.cend(); ++overridesIt)
{
auto it = m_colors.find(overridesIt.key());
const auto it = m_colors.find(overridesIt.key());
if (it != m_colors.end())
it.value().dark = overridesIt.value();
}