Use const accessor

This avoids an unnecessary check to the container internal atomic variable and prevents
potential detachment.

PR #22280.
This commit is contained in:
Chocobo1
2025-02-16 15:51:40 +08:00
committed by GitHub
parent ddf6dd5fa2
commit 8da43a4054
11 changed files with 45 additions and 45 deletions

View File

@@ -175,7 +175,7 @@ void DefaultThemeSource::loadColors()
const QHash<QString, QColor> lightModeColorOverrides = colorsFromJSON(config.value(KEY_COLORS_LIGHT).toObject());
for (auto overridesIt = lightModeColorOverrides.cbegin(); overridesIt != lightModeColorOverrides.cend(); ++overridesIt)
{
auto it = m_colors.find(overridesIt.key());
const auto it = m_colors.find(overridesIt.key());
if (it != m_colors.end())
it.value().light = overridesIt.value();
}
@@ -183,7 +183,7 @@ void DefaultThemeSource::loadColors()
const QHash<QString, QColor> darkModeColorOverrides = colorsFromJSON(config.value(KEY_COLORS_DARK).toObject());
for (auto overridesIt = darkModeColorOverrides.cbegin(); overridesIt != darkModeColorOverrides.cend(); ++overridesIt)
{
auto it = m_colors.find(overridesIt.key());
const auto it = m_colors.find(overridesIt.key());
if (it != m_colors.end())
it.value().dark = overridesIt.value();
}