squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2026-01-02 05:38:06 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use const accessor

Browse Source 
This avoids an unnecessary check to the container internal atomic variable and prevents
potential detachment.

PR #22280.
This commit is contained in:
Chocobo1
2025-02-16 15:51:40 +08:00
committed by GitHub
parent ddf6dd5fa2
commit 8da43a4054
11 changed files with 45 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/webui/api/authcontroller.cpp
View File

@@ -103,8 +103,8 @@ void AuthController::logoutAction() const
bool AuthController::isBanned() const
{
const auto failedLoginIter = m_clientFailedLogins.find(m_sessionManager->clientId());
if (failedLoginIter == m_clientFailedLogins.end())
const auto failedLoginIter = m_clientFailedLogins.constFind(m_sessionManager->clientId());
if (failedLoginIter == m_clientFailedLogins.cend())
return false;
bool isBanned = (failedLoginIter->banTimer.remainingTime() >= 0);

12
src/webui/api/searchcontroller.cpp
View File

@@ -131,8 +131,8 @@ void SearchController::stopAction()
const int id = params()[u"id"_s].toInt();
const auto iter = m_searchHandlers.find(id);
if (iter == m_searchHandlers.end())
const auto iter = m_searchHandlers.constFind(id);
if (iter == m_searchHandlers.cend())
throw APIError(APIErrorType::NotFound);
const std::shared_ptr<SearchHandler> &searchHandler = iter.value();
@@ -176,8 +176,8 @@ void SearchController::resultsAction()
int limit = params()[u"limit"_s].toInt();
int offset = params()[u"offset"_s].toInt();
const auto iter = m_searchHandlers.find(id);
if (iter == m_searchHandlers.end())
const auto iter = m_searchHandlers.constFind(id);
if (iter == m_searchHandlers.cend())
throw APIError(APIErrorType::NotFound);
const std::shared_ptr<SearchHandler> &searchHandler = iter.value();
@@ -207,8 +207,8 @@ void SearchController::deleteAction()
const int id = params()[u"id"_s].toInt();
const auto iter = m_searchHandlers.find(id);
if (iter == m_searchHandlers.end())
const auto iter = m_searchHandlers.constFind(id);
if (iter == m_searchHandlers.cend())
throw APIError(APIErrorType::NotFound);
const std::shared_ptr<SearchHandler> &searchHandler = iter.value();

2
src/webui/api/synccontroller.cpp
View File

@@ -864,7 +864,7 @@ void SyncController::onTorrentAboutToBeRemoved(BitTorrent::Torrent *torrent)
for (const BitTorrent::TrackerEntryStatus &status : asConst(torrent->trackers()))
{
auto iter = m_knownTrackers.find(status.url);
const auto iter = m_knownTrackers.find(status.url);
Q_ASSERT(iter != m_knownTrackers.end());
if (iter == m_knownTrackers.end()) [[unlikely]]
continue;

4
src/webui/webapplication.cpp
View File

@@ -339,8 +339,8 @@ void WebApplication::doProcessRequest()
}
// Filter HTTP methods
const auto allowedMethodIter = m_allowedMethod.find({scope, action});
if (allowedMethodIter == m_allowedMethod.end())
const auto allowedMethodIter = m_allowedMethod.constFind({scope, action});
if (allowedMethodIter == m_allowedMethod.cend())
{
// by default allow both GET, POST methods
if ((m_request.method != Http::METHOD_GET) && (m_request.method != Http::METHOD_POST))