squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-17 06:01:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

WebUI: use secure random number generator for generating random port

Browse Source 
Cryptographically strong random number generators are generally preferred over others.

PR #23049.
This commit is contained in:
Chocobo1
2025-08-03 15:09:39 +08:00
committed by GitHub
parent ae8a6689dc
commit 94552b2384
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/webui/www/private/views/preferences.html
View File

@@ -2127,9 +2127,11 @@ Use ';' to split multiple entries. Can use wildcard '*'.)QBT_TR[CONTEXT=OptionsD
};
const generateRandomPort = () => {
const min = 1024;
const max = 65535;
const port = Math.floor(Math.random() * (max - min + 1) + min);
// don't use modulo operations to avoid 'modulo bias'
const buffer = new Uint16Array(1);
let port = crypto.getRandomValues(buffer)[0];
while (port < 1024)
port = crypto.getRandomValues(buffer)[0];
document.getElementById("portValue").value = port;
};