From ff99e5ac9a30a720cc23c6fccd3037a212ad1506 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Mon, 24 Jan 2022 10:41:25 +0800
Subject: [PATCH 1/2] Speed up piece relevance calculation

For ~800 pieces, this roughly cuts the run time (of this function) in
half.
---
 src/base/bittorrent/peerinfo.cpp | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/src/base/bittorrent/peerinfo.cpp b/src/base/bittorrent/peerinfo.cpp
index 8d8c05f2a..835c85c08 100644
--- a/src/base/bittorrent/peerinfo.cpp
+++ b/src/base/bittorrent/peerinfo.cpp
@@ -229,25 +229,16 @@ QString PeerInfo::connectionType() const
 void PeerInfo::calcRelevance(const Torrent *torrent)
 {
     const QBitArray allPieces = torrent->pieces();
-    const QBitArray peerPieces = pieces();
-
-    int localMissing = 0;
-    int remoteHaves = 0;
-
-    for (int i = 0; i < allPieces.size(); ++i)
+    const int localMissing = allPieces.count(false);
+    if (localMissing <= 0)
     {
-        if (!allPieces[i])
-        {
-            ++localMissing;
-            if (peerPieces[i])
-                ++remoteHaves;
-        }
+        m_relevance = 0;
+        return;
     }
 
-    if (localMissing == 0)
-        m_relevance = 0.0;
-    else
-        m_relevance = static_cast<qreal>(remoteHaves) / localMissing;
+    const QBitArray peerPieces = pieces();
+    const int remoteHaves = (peerPieces & (~allPieces)).count(true);
+    m_relevance = static_cast<qreal>(remoteHaves) / localMissing;
 }
 
 qreal PeerInfo::relevance() const

From 53992bf0d5c76f607c43511c4829b721a32f7417 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Mon, 24 Jan 2022 13:44:49 +0800
Subject: [PATCH 2/2] Initialize class variable in initializer list

---
 src/base/bittorrent/peerinfo.cpp | 11 ++++-------
 src/base/bittorrent/peerinfo.h   |  2 +-
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/base/bittorrent/peerinfo.cpp b/src/base/bittorrent/peerinfo.cpp
index 835c85c08..291459434 100644
--- a/src/base/bittorrent/peerinfo.cpp
+++ b/src/base/bittorrent/peerinfo.cpp
@@ -39,8 +39,8 @@ using namespace BitTorrent;
 
 PeerInfo::PeerInfo(const Torrent *torrent, const lt::peer_info &nativeInfo)
     : m_nativeInfo(nativeInfo)
+    , m_relevance(calcRelevance(torrent))
 {
-    calcRelevance(torrent);
     determineFlags();
 }
 
@@ -226,19 +226,16 @@ QString PeerInfo::connectionType() const
         : QLatin1String {"Web"};
 }
 
-void PeerInfo::calcRelevance(const Torrent *torrent)
+qreal PeerInfo::calcRelevance(const Torrent *torrent) const
 {
     const QBitArray allPieces = torrent->pieces();
     const int localMissing = allPieces.count(false);
     if (localMissing <= 0)
-    {
-        m_relevance = 0;
-        return;
-    }
+        return 0;
 
     const QBitArray peerPieces = pieces();
     const int remoteHaves = (peerPieces & (~allPieces)).count(true);
-    m_relevance = static_cast<qreal>(remoteHaves) / localMissing;
+    return static_cast<qreal>(remoteHaves) / localMissing;
 }
 
 qreal PeerInfo::relevance() const
diff --git a/src/base/bittorrent/peerinfo.h b/src/base/bittorrent/peerinfo.h
index bfa5f9b2e..f7f51d177 100644
--- a/src/base/bittorrent/peerinfo.h
+++ b/src/base/bittorrent/peerinfo.h
@@ -92,7 +92,7 @@ namespace BitTorrent
         int downloadingPieceIndex() const;
 
     private:
-        void calcRelevance(const Torrent *torrent);
+        qreal calcRelevance(const Torrent *torrent) const;
         void determineFlags();
 
         lt::peer_info m_nativeInfo = {};