squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-23 08:48:07 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improve handling when writing to temporary files

Browse Source 
Let QTemporaryFile remove incomplete written file when error occurs.
"XXXXXX" template is not strictly required according to Qt doc.
This commit is contained in:
Chocobo1
2021-09-15 23:17:24 +08:00
parent fa8786e230
commit 9673be17cb
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/base/net/downloadhandlerimpl.cpp
View File

@@ -46,14 +46,13 @@ namespace
if (!filePath.isEmpty()) if (!filePath.isEmpty())
return Utils::IO::saveToFile(filePath, replyData).has_value(); return Utils::IO::saveToFile(filePath, replyData).has_value();
QTemporaryFile tmpfile {Utils::Fs::tempPath() + "XXXXXX"}; QTemporaryFile file {Utils::Fs::tempPath()};
tmpfile.setAutoRemove(false); if (!file.open() || (file.write(replyData) != replyData.length()) || !file.flush())
if (!tmpfile.open())
return false; return false;
filePath = tmpfile.fileName(); file.setAutoRemove(false);
return (tmpfile.write(replyData) == replyData.length()); filePath = file.fileName();
return true;
} }
} }