squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-19 23:17:21 -06:00
Code Issues Packages Projects Releases Wiki Activity

- Cleanly fixed popup menus position in lists (no more workarounds)

Browse Source
This commit is contained in:
Christophe Dumez
2009-07-12 06:07:20 +00:00
parent e67d3243e8
commit 9b29302d42
5 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog
View File

@@ -4,6 +4,7 @@
- BUGFIX: Fixed a little bug in search engine plugins helper file - BUGFIX: Fixed a little bug in search engine plugins helper file
- BUGFIX: Fixed compilation problems with Qt 4.3 - BUGFIX: Fixed compilation problems with Qt 4.3
- BUGFIX: Percentages no longer disapear with default cleanlooks style - BUGFIX: Percentages no longer disapear with default cleanlooks style
- BUGFIX: Cleanly fixed popup menus position in lists (no more workarounds)
* Sun Apr 5 2009 - Christophe Dumez <chris@qbittorrent.org> - v1.3.3 * Sun Apr 5 2009 - Christophe Dumez <chris@qbittorrent.org> - v1.3.3
- BUGFIX: Fixed Web UI torrent upload form - BUGFIX: Fixed Web UI torrent upload form

5
src/FinishedTorrents.cpp
View File

@@ -355,7 +355,7 @@ void FinishedTorrents::forceRecheck(){
} }
} }
void FinishedTorrents::displayFinishedListMenu(const QPoint& pos){ void FinishedTorrents::displayFinishedListMenu(const QPoint&){
QMenu myFinishedListMenu(this); QMenu myFinishedListMenu(this);
// Enable/disable pause/start action given the DL state // Enable/disable pause/start action given the DL state
QModelIndexList selectedIndexes = finishedList->selectionModel()->selectedIndexes(); QModelIndexList selectedIndexes = finishedList->selectionModel()->selectedIndexes();
@@ -399,8 +399,7 @@ void FinishedTorrents::displayFinishedListMenu(const QPoint& pos){
myFinishedListMenu.addAction(actionBuy_it); myFinishedListMenu.addAction(actionBuy_it);
// Call menu // Call menu
// XXX: why mapToGlobal() is not enough? myFinishedListMenu.exec(QCursor::pos());
myFinishedListMenu.exec(mapToGlobal(pos)+QPoint(10,58));
} }

5
src/downloadingTorrents.cpp
View File

@@ -236,7 +236,7 @@ void DownloadingTorrents::forceRecheck() {
} }
} }
void DownloadingTorrents::displayDLListMenu(const QPoint& pos) { void DownloadingTorrents::displayDLListMenu(const QPoint&) {
QMenu myDLLlistMenu(this); QMenu myDLLlistMenu(this);
// Enable/disable pause/start action given the DL state // Enable/disable pause/start action given the DL state
QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes(); QModelIndexList selectedIndexes = downloadList->selectionModel()->selectedIndexes();
@@ -285,8 +285,7 @@ void DownloadingTorrents::displayDLListMenu(const QPoint& pos) {
myDLLlistMenu.addSeparator(); myDLLlistMenu.addSeparator();
myDLLlistMenu.addAction(actionBuy_it); myDLLlistMenu.addAction(actionBuy_it);
// Call menu // Call menu
// XXX: why mapToGlobal() is not enough? myDLLlistMenu.exec(QCursor::pos());
myDLLlistMenu.exec(mapToGlobal(pos)+QPoint(10,35));
} }

5
src/properties_imp.cpp
View File

@@ -362,7 +362,7 @@ void properties::getPriorities(QStandardItem *parent, int *priorities) {
} }
} }
void properties::displayFilesListMenu(const QPoint& pos){ void properties::displayFilesListMenu(const QPoint&){
if(h.get_torrent_info().num_files() == 1) return; if(h.get_torrent_info().num_files() == 1) return;
QMenu myFilesLlistMenu(this); QMenu myFilesLlistMenu(this);
QModelIndex index; QModelIndex index;
@@ -374,8 +374,7 @@ void properties::displayFilesListMenu(const QPoint& pos){
myFilesLlistMenu.addAction(actionHigh); myFilesLlistMenu.addAction(actionHigh);
myFilesLlistMenu.addAction(actionMaximum); myFilesLlistMenu.addAction(actionMaximum);
// Call menu // Call menu
// XXX: why mapToGlobal() is not enough? myFilesLlistMenu.exec(QCursor::pos());
myFilesLlistMenu.exec(mapToGlobal(pos)+QPoint(22,95));
} }
void properties::ignoreSelection(){ void properties::ignoreSelection(){

5
src/torrentAddition.h
View File

@@ -290,7 +290,7 @@ class torrentAdditionDialog : public QDialog, private Ui_addTorrentDialog{
return true; return true;
} }
void displayFilesListMenu(const QPoint& pos){ void displayFilesListMenu(const QPoint&){
if(nbFiles == 1) return; if(nbFiles == 1) return;
QMenu myFilesLlistMenu(this); QMenu myFilesLlistMenu(this);
QModelIndex index; QModelIndex index;
@@ -302,8 +302,7 @@ class torrentAdditionDialog : public QDialog, private Ui_addTorrentDialog{
myFilesLlistMenu.addAction(actionHigh); myFilesLlistMenu.addAction(actionHigh);
myFilesLlistMenu.addAction(actionMaximum); myFilesLlistMenu.addAction(actionMaximum);
// Call menu // Call menu
// XXX: why mapToGlobal() is not enough? myFilesLlistMenu.exec(QCursor::pos());
myFilesLlistMenu.exec(mapToGlobal(pos)+QPoint(10,145));
} }
void ignoreSelection(){ void ignoreSelection(){