From 9ce5463d9d7b19e00b23aeffb70524d2cb7bcf4c Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Mon, 20 Oct 2025 17:20:42 +0800
Subject: [PATCH] Avoid container detachments

PR #23393.
---
 src/app/application.cpp                              | 2 +-
 src/gui/guiaddtorrentmanager.cpp                     | 2 +-
 src/gui/trackerlist/trackerlistmodel.cpp             | 2 +-
 src/gui/transferlistfilters/trackersfilterwidget.cpp | 2 +-
 src/webui/api/synccontroller.cpp                     | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/app/application.cpp b/src/app/application.cpp
index 8240e23b6..8955ceed5 100644
--- a/src/app/application.cpp
+++ b/src/app/application.cpp
@@ -996,7 +996,7 @@ int Application::exec()
 #endif // DISABLE_WEBUI
 
         m_isProcessingParamsAllowed = true;
-        for (const QBtCommandLineParameters &params : m_paramsQueue)
+        for (const QBtCommandLineParameters &params : asConst(m_paramsQueue))
             processParams(params);
         m_paramsQueue.clear();
     });
diff --git a/src/gui/guiaddtorrentmanager.cpp b/src/gui/guiaddtorrentmanager.cpp
index 6e6b709d7..b68e982e1 100644
--- a/src/gui/guiaddtorrentmanager.cpp
+++ b/src/gui/guiaddtorrentmanager.cpp
@@ -176,7 +176,7 @@ void GUIAddTorrentManager::onMetadataDownloaded(const BitTorrent::TorrentInfo &m
     if (!metadata.isValid()) [[unlikely]]
         return;
 
-    for (const auto &[infoHash, dialog] : m_dialogs.asKeyValueRange())
+    for (const auto &[infoHash, dialog] : asConst(m_dialogs).asKeyValueRange())
     {
         if (metadata.matchesInfoHash(infoHash))
             dialog->updateMetadata(metadata);
diff --git a/src/gui/trackerlist/trackerlistmodel.cpp b/src/gui/trackerlist/trackerlistmodel.cpp
index 684bef069..6c52a0bf2 100644
--- a/src/gui/trackerlist/trackerlistmodel.cpp
+++ b/src/gui/trackerlist/trackerlistmodel.cpp
@@ -741,7 +741,7 @@ void TrackerListModel::onTrackersChanged()
         trackerItemIDs.insert(m_items->at(i)->name);
 
     QList<std::shared_ptr<Item>> newTrackerItems;
-    for (const BitTorrent::TrackerEntryStatus &trackerEntryStatus : m_torrent->trackers())
+    for (const BitTorrent::TrackerEntryStatus &trackerEntryStatus : asConst(m_torrent->trackers()))
     {
         trackerItemIDs.insert(trackerEntryStatus.url);
 
diff --git a/src/gui/transferlistfilters/trackersfilterwidget.cpp b/src/gui/transferlistfilters/trackersfilterwidget.cpp
index fd0c9524f..65e76ee01 100644
--- a/src/gui/transferlistfilters/trackersfilterwidget.cpp
+++ b/src/gui/transferlistfilters/trackersfilterwidget.cpp
@@ -630,7 +630,7 @@ void TrackersFilterWidget::handleTorrentsLoaded(const QList<BitTorrent::Torrent
             torrentsPerTracker[NULL_HOST].append(torrentID);
     }
 
-    for (const auto &[trackerURL, torrents] : torrentsPerTracker.asKeyValueRange())
+    for (const auto &[trackerURL, torrents] : asConst(torrentsPerTracker).asKeyValueRange())
     {
         addItems(trackerURL, torrents);
     }
diff --git a/src/webui/api/synccontroller.cpp b/src/webui/api/synccontroller.cpp
index f2f05c55b..a68a7fce2 100644
--- a/src/webui/api/synccontroller.cpp
+++ b/src/webui/api/synccontroller.cpp
@@ -609,7 +609,7 @@ void SyncController::makeMaindataSnapshot()
     for (const Tag &tag : asConst(session->tags()))
         m_maindataSnapshot.tags.append(tag.toString());
 
-    for (const auto &[tracker, torrentIDs] : m_knownTrackers.asKeyValueRange())
+    for (const auto &[tracker, torrentIDs] : asConst(m_knownTrackers).asKeyValueRange())
         m_maindataSnapshot.trackers[tracker] = asStrings(torrentIDs);
 
     m_maindataSnapshot.serverState = getTransferInfo();