squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-21 16:07:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8558 from luis-pereira/containter-anti-pattern

Browse Source 
Don't create temporary containers just to iterate over them
This commit is contained in:
Vladimir Golovnev
2018-03-19 13:06:01 +03:00
committed by GitHub
parent a8dbff06a3 ac42ccb5e4
commit a5294e1e08
14 changed files with 120 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/base/net/portforwarder.cpp
View File

@@ -121,8 +121,10 @@ void PortForwarder::start()
settingsPack.set_bool(libt::settings_pack::enable_natpmp, true);
m_provider->apply_settings(settingsPack);
#endif
foreach (quint16 port, m_mappedPorts.keys())
m_mappedPorts[port] = m_provider->add_port_mapping(libt::session::tcp, port, port);
for (auto i = m_mappedPorts.begin(); i != m_mappedPorts.end(); ++i) {
// quint16 port = i.key();
i.value() = m_provider->add_port_mapping(libt::session::tcp, i.key(), i.key());
}
m_active = true;
Logger::instance()->addMessage(tr("UPnP / NAT-PMP support [ON]"), Log::INFO);
}