Fix javascript errors and follow best practices

This commit is contained in:
Thomas Piccirello
2017-07-01 00:42:20 -04:00
parent 1a506ac582
commit a7f4ea8b18
11 changed files with 145 additions and 145 deletions

View File

@@ -23,7 +23,7 @@ var ContextMenu = new Class({
//initialization
initialize: function(options) {
//set options
this.setOptions(options)
this.setOptions(options);
//option diffs menu
this.menu = $(this.options.menu);
@@ -69,19 +69,19 @@ var ContextMenu = new Class({
});
// position the menu
var xPos = e.page.x + this.options.offsets.x;
var yPos = e.page.y + this.options.offsets.y;
if (xPos + this.menu.offsetWidth > document.documentElement.clientWidth)
xPos -= this.menu.offsetWidth;
if (yPos + this.menu.offsetHeight > document.documentElement.clientHeight)
yPos = document.documentElement.clientHeight - this.menu.offsetHeight;
if (xPos < 0)
xPos = 0;
if (yPos < 0)
yPos = 0;
var xPosMenu = e.page.x + this.options.offsets.x;
var yPosMenu = e.page.y + this.options.offsets.y;
if (xPosMenu + this.menu.offsetWidth > document.documentElement.clientWidth)
xPosMenu -= this.menu.offsetWidth;
if (yPosMenu + this.menu.offsetHeight > document.documentElement.clientHeight)
yPosMenu = document.documentElement.clientHeight - this.menu.offsetHeight;
if (xPosMenu < 0)
xPosMenu = 0;
if (yPosMenu < 0)
yPosMenu = 0;
this.menu.setStyles({
left: xPos,
top: yPos,
left: xPosMenu,
top: yPosMenu,
position: 'absolute',
'z-index': '2000'
});
@@ -260,19 +260,19 @@ var TorrentsTableContextMenu = new Class({
h.each(function(item, index){
var data = torrentsTable.rows.get(item).full_data;
if (data['seq_dl'] != true)
if (data['seq_dl'] !== true)
all_are_seq_dl = false;
else
there_are_seq_dl = true;
if (data['f_l_piece_prio'] != true)
if (data['f_l_piece_prio'] !== true)
all_are_f_l_piece_prio = false;
else
there_are_f_l_piece_prio = true;
if (data['progress'] != 1.0) // not downloaded
all_are_downloaded = false;
else if (data['super_seeding'] != true)
else if (data['super_seeding'] !== true)
all_are_super_seeding = false;
if (data['state'] != 'pausedUP' && data['state'] != 'pausedDL')
@@ -280,7 +280,7 @@ var TorrentsTableContextMenu = new Class({
else
there_are_paused = true;
if (data['force_start'] != true)
if (data['force_start'] !== true)
all_are_force_start = false;
else
there_are_force_start = true;
@@ -344,7 +344,7 @@ var TorrentsTableContextMenu = new Class({
categoryList.appendChild(new Element('li', {html: '<a href="javascript:torrentNewCategoryFN();"><img src="theme/list-add" alt="QBT_TR(New...)QBT_TR[CONTEXT=TransferListWidget]"/> QBT_TR(New...)QBT_TR[CONTEXT=TransferListWidget]</a>'}));
categoryList.appendChild(new Element('li', {html: '<a href="javascript:torrentSetCategoryFN(0);"><img src="theme/edit-clear" alt="QBT_TR(Reset)QBT_TR[CONTEXT=TransferListWidget]"/> QBT_TR(Reset)QBT_TR[CONTEXT=TransferListWidget]</a>'}));
var sortedCategories = []
var sortedCategories = [];
Object.each(category_list, function (category) {
sortedCategories.push(category.name);
});