squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-19 06:57:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential data race

Browse Source 
This case could be considered benign however it could still be an
undefined behavior to the compiler, so remove it.

Ref:
https://hacks.mozilla.org/2021/04/eliminating-data-races-in-firefox-a-technical-report/
This commit is contained in:
Chocobo1
2021-05-07 15:38:58 +08:00
parent 05e3e46f5a
commit a82ca6adb2
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/base/settingsstorage.cpp
View File

@@ -184,9 +184,8 @@ SettingsStorage *SettingsStorage::instance()
bool SettingsStorage::save() bool SettingsStorage::save()
{ {
if (!m_dirty) return true; // Obtaining the lock is expensive, let's check early const QWriteLocker locker(&m_lock); // guard for `m_dirty` too
const QWriteLocker locker(&m_lock); // to guard for `m_dirty` if (!m_dirty) return true;
if (!m_dirty) return true; // something might have changed while we were getting the lock
const TransactionalSettings settings(QLatin1String("qBittorrent")); const TransactionalSettings settings(QLatin1String("qBittorrent"));
if (!settings.write(m_data)) if (!settings.write(m_data))