From c59ac3b970e512a9e3d2efce54ede2e26fed6b82 Mon Sep 17 00:00:00 2001 From: Thomas Piccirello <8296030+Piccirello@users.noreply.github.com> Date: Thu, 5 Jun 2025 02:32:26 -0700 Subject: [PATCH] Make modifying log file perms best effort qBittorrent is able to write to the log file, so it's ok if the permission change fails. PR #22800. --- src/app/filelogger.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/app/filelogger.cpp b/src/app/filelogger.cpp index 5436c1392..4c83c16a1 100644 --- a/src/app/filelogger.cpp +++ b/src/app/filelogger.cpp @@ -175,12 +175,15 @@ void FileLogger::flushLog() void FileLogger::openLogFile() { - if (!m_logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text) - || !m_logFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner)) + if (!m_logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text)) { - m_logFile.close(); - LogMsg(tr("An error occurred while trying to open the log file. Logging to file is disabled."), Log::CRITICAL); + LogMsg(tr("An error occurred while trying to open the log file. Logging to file is disabled. File: \"%1\". Error: \"%2\".") + .arg(m_logFile.fileName(), m_logFile.errorString()), Log::CRITICAL); + return; } + + // best effort, don't report error + m_logFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner); } void FileLogger::closeLogFile()