squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-18 22:47:21 -06:00
Code Issues Packages Projects Releases Wiki Activity

Avoid redundant data copy by using JSON objects directly

Browse Source
This commit is contained in:
Chocobo1
2019-08-01 21:00:10 +08:00
parent f6ee96ed83
commit cfe83275d3
3 changed files with 51 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/webui/api/logcontroller.cpp
View File

@@ -29,6 +29,7 @@
#include "logcontroller.h"
#include <QJsonArray>
#include <QJsonObject>
#include "base/global.h"
#include "base/logger.h"
@@ -70,7 +71,7 @@ void LogController::mainAction()
lastKnownId = -1;
Logger *const logger = Logger::instance();
QVariantList msgList;
QJsonArray msgList;
for (const Log::Msg &msg : asConst(logger->getMessages(lastKnownId))) {
if (!((msg.type == Log::NORMAL && isNormal)
@@ -79,7 +80,7 @@ void LogController::mainAction()
|| (msg.type == Log::CRITICAL && isCritical)))
continue;
msgList.append(QVariantHash {
msgList.append(QJsonObject {
{KEY_LOG_ID, msg.id},
{KEY_LOG_TIMESTAMP, msg.timestamp},
{KEY_LOG_MSG_TYPE, msg.type},
@@ -87,7 +88,7 @@ void LogController::mainAction()
});
}
setResult(QJsonArray::fromVariantList(msgList));
setResult(msgList);
}
// Returns the peer log in JSON format.
@@ -110,10 +111,10 @@ void LogController::peersAction()
lastKnownId = -1;
Logger *const logger = Logger::instance();
QVariantList peerList;
QJsonArray peerList;
for (const Log::Peer &peer : asConst(logger->getPeers(lastKnownId))) {
peerList.append(QVariantHash {
peerList.append(QJsonObject {
{KEY_LOG_ID, peer.id},
{KEY_LOG_TIMESTAMP, peer.timestamp},
{KEY_LOG_PEER_IP, peer.ip},
@@ -122,5 +123,5 @@ void LogController::peersAction()
});
}
setResult(QJsonArray::fromVariantList(peerList));
setResult(peerList);
}