squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-22 00:17:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add pointer qualifications to auto-typed variables

Browse Source
This commit is contained in:
Chocobo1
2023-05-05 03:07:26 +08:00
parent 8c9b6e2f2d
commit e408973ee6
27 changed files with 78 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/gui/rss/articlelistwidget.cpp
View File

@@ -71,11 +71,11 @@ void ArticleListWidget::setRSSItem(RSS::Item *rssItem, bool unreadOnly)
connect(m_rssItem, &RSS::Item::articleRead, this, &ArticleListWidget::handleArticleRead);
connect(m_rssItem, &RSS::Item::articleAboutToBeRemoved, this, &ArticleListWidget::handleArticleAboutToBeRemoved);
for (const auto article : asConst(rssItem->articles()))
for (auto *article : asConst(rssItem->articles()))
{
if (!(m_unreadOnly && article->isRead()))
{
auto item = createItem(article);
auto *item = createItem(article);
addItem(item);
m_rssArticleToListItemMapping.insert(article, item);
}
@@ -89,7 +89,7 @@ void ArticleListWidget::handleArticleAdded(RSS::Article *rssArticle)
{
if (!(m_unreadOnly && rssArticle->isRead()))
{
auto item = createItem(rssArticle);
auto *item = createItem(rssArticle);
insertItem(0, item);
m_rssArticleToListItemMapping.insert(rssArticle, item);
}
@@ -99,7 +99,7 @@ void ArticleListWidget::handleArticleAdded(RSS::Article *rssArticle)
void ArticleListWidget::handleArticleRead(RSS::Article *rssArticle)
{
auto item = mapRSSArticle(rssArticle);
auto *item = mapRSSArticle(rssArticle);
if (!item) return;
const QBrush foregroundBrush {UIThemeManager::instance()->getColor(u"RSS.ReadArticle"_qs)};

10
src/gui/rss/automatedrssdownloader.cpp
View File

@@ -192,7 +192,7 @@ void AutomatedRssDownloader::loadFeedList()
{
const QSignalBlocker feedListSignalBlocker(m_ui->listFeeds);
for (const auto feed : asConst(RSS::Session::instance()->feeds()))
for (const auto *feed : asConst(RSS::Session::instance()->feeds()))
{
QListWidgetItem *item = new QListWidgetItem(feed->name(), m_ui->listFeeds);
item->setData(Qt::UserRole, feed->url());
@@ -636,11 +636,11 @@ void AutomatedRssDownloader::updateMatchingArticles()
: RSS::AutoDownloader::instance()->ruleByName(ruleItem->text()));
for (const QString &feedURL : asConst(rule.feedURLs()))
{
auto feed = RSS::Session::instance()->feedByURL(feedURL);
auto *feed = RSS::Session::instance()->feedByURL(feedURL);
if (!feed) continue; // feed doesn't exist
QStringList matchingArticles;
for (const auto article : asConst(feed->articles()))
for (const auto *article : asConst(feed->articles()))
if (rule.matches(article->data()))
matchingArticles << article->title();
if (!matchingArticles.isEmpty())
@@ -853,7 +853,7 @@ void AutomatedRssDownloader::handleRuleAdded(const QString &ruleName)
void AutomatedRssDownloader::handleRuleRenamed(const QString &ruleName, const QString &oldRuleName)
{
auto item = m_itemsByRuleName.take(oldRuleName);
auto *item = m_itemsByRuleName.take(oldRuleName);
m_itemsByRuleName.insert(ruleName, item);
if (m_currentRule.name() == oldRuleName)
m_currentRule.setName(ruleName);
@@ -862,7 +862,7 @@ void AutomatedRssDownloader::handleRuleRenamed(const QString &ruleName, const QS
void AutomatedRssDownloader::handleRuleChanged(const QString &ruleName)
{
auto item = m_itemsByRuleName.value(ruleName);
auto *item = m_itemsByRuleName.value(ruleName);
if (item && (item != m_currentRuleItem))
item->setCheckState(RSS::AutoDownloader::instance()->ruleByName(ruleName).isEnabled() ? Qt::Checked : Qt::Unchecked);
}

10
src/gui/rss/feedlistwidget.cpp
View File

@@ -123,7 +123,7 @@ FeedListWidget::FeedListWidget(QWidget *parent)
void FeedListWidget::handleItemAdded(RSS::Item *rssItem)
{
auto parentItem = m_rssToTreeItemMapping.value(
auto *parentItem = m_rssToTreeItemMapping.value(
RSS::Session::instance()->itemByPath(RSS::Item::parentPath(rssItem->path())));
createItem(rssItem, parentItem);
}
@@ -264,7 +264,7 @@ void FeedListWidget::dropEvent(QDropEvent *event)
// move as much items as possible
for (QTreeWidgetItem *srcItem : asConst(selectedItems()))
{
auto rssItem = getRSSItem(srcItem);
auto *rssItem = getRSSItem(srcItem);
RSS::Session::instance()->moveItem(rssItem, RSS::Item::joinPath(destFolder->path(), rssItem->name()));
}
@@ -281,7 +281,7 @@ QTreeWidgetItem *FeedListWidget::createItem(RSS::Item *rssItem, QTreeWidgetItem
m_rssToTreeItemMapping[rssItem] = item;
QIcon icon;
if (auto feed = qobject_cast<RSS::Feed *>(rssItem))
if (auto *feed = qobject_cast<RSS::Feed *>(rssItem))
icon = rssFeedIcon(feed);
else
icon = UIThemeManager::instance()->getIcon(u"directory"_qs);
@@ -299,11 +299,11 @@ QTreeWidgetItem *FeedListWidget::createItem(RSS::Item *rssItem, QTreeWidgetItem
void FeedListWidget::fill(QTreeWidgetItem *parent, RSS::Folder *rssParent)
{
for (const auto rssItem : asConst(rssParent->items()))
for (auto *rssItem : asConst(rssParent->items()))
{
QTreeWidgetItem *item = createItem(rssItem, parent);
// Recursive call if this is a folder.
if (auto folder = qobject_cast<RSS::Folder *>(rssItem))
if (auto *folder = qobject_cast<RSS::Folder *>(rssItem))
fill(item, folder);
}
}

12
src/gui/rss/rsswidget.cpp
View File

@@ -203,7 +203,7 @@ void RSSWidget::displayItemsListMenu()
bool hasLink = false;
for (const QListWidgetItem *item : asConst(m_articleListWidget->selectedItems()))
{
auto article = item->data(Qt::UserRole).value<RSS::Article *>();
auto *article = item->data(Qt::UserRole).value<RSS::Article *>();
Q_ASSERT(article);
if (!article->torrentUrl().isEmpty())
@@ -364,7 +364,7 @@ void RSSWidget::downloadSelectedTorrents()
{
for (QListWidgetItem *item : asConst(m_articleListWidget->selectedItems()))
{
auto article = item->data(Qt::UserRole).value<RSS::Article *>();
auto *article = item->data(Qt::UserRole).value<RSS::Article *>();
Q_ASSERT(article);
// Mark as read
@@ -385,7 +385,7 @@ void RSSWidget::openSelectedArticlesUrls()
{
for (QListWidgetItem *item : asConst(m_articleListWidget->selectedItems()))
{
auto article = item->data(Qt::UserRole).value<RSS::Article *>();
auto *article = item->data(Qt::UserRole).value<RSS::Article *>();
Q_ASSERT(article);
// Mark as read
@@ -467,7 +467,7 @@ void RSSWidget::copySelectedFeedsURL()
QStringList URLs;
for (QTreeWidgetItem *item : asConst(m_feedListWidget->selectedItems()))
{
if (auto feed = qobject_cast<RSS::Feed *>(m_feedListWidget->getRSSItem(item)))
if (auto *feed = qobject_cast<RSS::Feed *>(m_feedListWidget->getRSSItem(item)))
URLs << feed->url();
}
qApp->clipboard()->setText(URLs.join(u'\n'));
@@ -496,14 +496,14 @@ void RSSWidget::handleCurrentArticleItemChanged(QListWidgetItem *currentItem, QL
if (previousItem)
{
auto article = m_articleListWidget->getRSSArticle(previousItem);
auto *article = m_articleListWidget->getRSSArticle(previousItem);
Q_ASSERT(article);
article->markAsRead();
}
if (!currentItem) return;
auto article = m_articleListWidget->getRSSArticle(currentItem);
auto *article = m_articleListWidget->getRSSArticle(currentItem);
Q_ASSERT(article);
const QString highlightedBaseColor = m_ui->textBrowser->palette().color(QPalette::Highlight).name();