squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2026-01-02 05:38:06 -06:00
Code Issues Packages Projects Releases Wiki Activity
13,100 Commits 18 Branches 253 Tags
7487cd7e6ddb94b458a9d55db252bbe1ab7fb59e
Commit Graph

47 Commits

Author SHA1 Message Date
Chocobo1
7487cd7e6d WebUI: disallow unnecessary quotes in property name 
Those two forms are the same and from now on we enforce to one style.

PR #22051.
 2024-12-24 22:25:18 +08:00
skomerko
7080f85b59 WebUI: Replace Mootools class list manipulation methods 
All `addClass()`, `removeClass()` and `hasClass()` instances were changed to use `classList` equivalent:
https://developer.mozilla.org/en-US/docs/Web/API/Element/classList

PR #21946.

---------

Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
 2024-12-08 16:12:57 +08:00
skomerko
c9c85eeb95 WebUI: Use event delegation to handle common table events 
Event delegation is now used to handle basic table events.
2 minor fixes were added to match GUI behavior:
* Clicking on the table body deselects everything
* Table rows are now scrolled into view when using up/down arrows

PR #21829.
 2024-11-19 02:12:26 +08:00
Thomas Piccirello
dc30b9c2ec WebUI: Improve table overflow handling 
This PR relies on flexbox to ensure all WebUI tables are the correct height without overflowing. Table headers are now always visible and JS-based dynamic resizing is no longer needed.

PR #21652.
 2024-11-03 15:11:30 +08:00
skomerko
0704049026 WebUI: Apply box-sizing reset 
Box-sizing: border-box is now applied globally. A lot of tiny changes were made but they were necessary to correct resulting inconsistencies. Everything should be pretty much as it was with just some minor exceptions.

Looks like this PR also indirectly fixed #21414.

PR #21464.
 2024-10-12 14:22:07 +08:00
Thomas Piccirello
b1fd61af3a WebUI: Handle folders when updating RSS feed url 
Follow up to #21371 ([context](https://github.com/qbittorrent/qBittorrent/pull/21371#discussion_r1780908605)).

PR #21437.
 2024-10-12 13:30:24 +08:00
Chocobo1
6bbedbea8a WebUI: remove unused variable 
PR #21500.
 2024-10-06 16:54:42 +08:00
Chocobo1
dc02a0fc56 WebUI: remove unused variables 
PR #21432.
 2024-10-04 22:23:04 +08:00
Chocobo1
cebaedf485 WebUI: CSS/styling improvements 
WebUI: CSS/styling improvements
 2024-09-30 17:57:42 +08:00
Thomas Piccirello
50acb670b0 WebUI: Support updating RSS feed URL 
PR #21371.

Signed-off-by: Thomas Piccirello <thomas@piccirello.com>
 2024-09-30 17:34:37 +08:00
skomerko
2952480f37 WebUI: Use correct text and background colors in RSS details view 2024-09-28 17:49:52 +02:00
skomerko
8b2d8f3afd WebUI: Use Map instead of Mootools Hash in all dynamic tables 
PR #21358.
 2024-09-28 15:46:16 +08:00
Chocobo1
29379232aa WebUI: implement debounce behavior for resize events 2024-08-17 14:02:15 +08:00
skomerko
e069fbc37f WebUI: Add missing icons 
This adds missing icons to WebUI (in tabs, buttons, etc.).

PR #21162.
 2024-08-17 13:38:44 +08:00
Chocobo1
9df3ee0de8 WebUI: use native property to set styles 2024-08-10 14:26:10 +08:00
Chocobo1
49507ad670 Merge pull request #21123 from skomerko/webui-use-alternating-row-colors 
WebUI: Add ability to toggle alternating row colors in tables
 2024-08-04 17:16:01 +08:00
skomerko
aed103d06e WebUI: Improve visibility of unread RSS articles 2024-07-28 11:35:01 +02:00
Chocobo1
6b52a04ff1 WebUI: avoid queuing up requests 
`setInterval()` will always fire a new timeout regardless previous `updateRssFeedList()` has
completed or not. This patch will now wait for previous request to complete before another
timeout.
 2024-07-25 14:20:57 +08:00
Chocobo1
c3b7dfa918 WebUI: omit closing on HTML void elements 
https://developer.mozilla.org/en-US/docs/Glossary/Void_element#self-closing_tags :
>Self-closing tags (<tag />) do not exist in HTML.
 2024-07-15 17:46:33 +08:00
Chocobo1
25dd6c72f7 WebUI: use the correct property for accessing text 
In these instances we don't need the rendered result. So use the most efficient
property to access it: `.textContent`.
 2024-07-15 17:09:16 +08:00
Chocobo1
9feefc8144 WebUI: avoid redundant re-initialization 
PR #21012.
 2024-07-12 15:00:36 +08:00
Chocobo1
9c26e5d4d6 WebUI: access attribute/property natively 
It is now clearer to see what property is being accessed.
Previously mootools library would re-map attribute/property to another.

PR #21007.
 2024-07-12 14:06:59 +08:00
Chocobo1
648dd9988d WebUI: unify comment format 2024-06-11 02:17:10 +08:00
Chocobo1
bf4e0df386 WebUI: unify curly bracket usage 2024-06-07 02:51:35 +08:00
Chocobo1
64dfb7e122 WebUI: iterate over own properties only 2024-05-27 23:00:03 +08:00
Chocobo1
55bff4f07a WebUI: enforce usage of const whenever possible 2024-05-27 22:56:51 +08:00
Chocobo1
cb90b6769c WebUI: enforce string quotes coding style 2024-05-27 22:50:17 +08:00
Chocobo1
d7cded54e4 WebUI: enforce parentheses around operators 
PR #20696.
 2024-04-15 12:50:07 +08:00
Chocobo1
d06d5b923a Cache program preferences 
So that qbt can just use the data from memory which is vastly faster than waiting for a response
over the net.
 2024-02-14 03:38:09 +08:00
Chocobo1
8ef99b336c Remove 'no cache' directive for POST requests 
The response for POST request is only cachable under a specific condition and
qbt doesn't use it.
https://developer.mozilla.org/en-US/docs/Glossary/Cacheable
 2024-02-11 23:28:44 +08:00
brvphoenix
9fde5634f1 Fix JS memory leak 
The memory leak can be reproduced easily by opening two web pages of qbittorrent so that the WebUI pages are updated with full_update = true. If you have a large number of torrents, such as 100 torrents, you can observe a rapid increase in memory usage.

This is caused by the incorrect usage of dispose and empty methods in the js codes and none of them garbage collect the elements. If event listeners are added to the DOM elements, those DOM elements will not be garbage collected at all event if they are not referenced or out of the scope, which will cause memory leaks. If some elements are expected to be removed, the correct way is to use destroy method instead.

https://github.com/mootools/mootools-core/blob/master/Docs/Element/Element.md#element-method-dispose-elementdispose
https://github.com/mootools/mootools-core/blob/master/Docs/Element/Element.md#element-method-empty-elementempty
https://github.com/mootools/mootools-core/blob/master/Docs/Element/Element.md#element-method-destroy-elementdestroy

Closes #19034.
PR #19969.
 2023-11-25 13:50:45 +08:00
Chocobo1
eb875ac8c1 Add attributes explicitly 2023-03-28 22:20:37 +08:00
Chocobo1
ca274635d5 Make WebUI images self-contained 2022-08-27 13:55:04 +08:00
Chocobo1
72941b10bb Use proper request method 2022-08-16 11:26:47 +08:00
Nowshed H. Imran
748226be29 Rename Icons according to the actions 
Fixes #17357.
PR #17366.
 2022-07-31 13:31:38 +08:00
Nowshed H. Imran
199d770e15 Implement new icon/color theme 
Co-authored-by: xavier2k6 <42386382+xavier2k6@users.noreply.github.com>
 2022-06-09 18:18:14 +06:00
Chocobo1
dbfd6a2368 WebUI: enforce coding style 
Actually, not all of them but some that can be enforced by eslint.
The changes are made by eslint with minor manual tweaking.

PR #17046.
 2022-05-18 11:37:05 +08:00
thalieht
e86916a7f9 Make some strings in WebUI translatable 
Closes #14920
 2021-05-06 20:49:35 +03:00
Chocobo1
121ff2b7be Apply code formatting 2021-03-26 00:27:52 +08:00
Chocobo1
c3bab70434 Remove extra semicolon 2021-03-26 00:27:51 +08:00
Mike Tzou
45c0d5a823 Merge pull request #14587 from Chocobo1/monitor 
Remove wrong parentheses in WebUI
 2021-03-24 12:47:11 +08:00
Chocobo1
e43a9de2f3 Make global functions immutable 2021-03-23 18:53:56 +08:00
brvphoenix
5beb1b2cd0 WebUI: Avoid decoding strings repeatedly 
Fix #14553
 2021-03-21 02:09:53 -07:00
Chocobo1
7e258bfe38 Fix typos 2020-10-20 18:56:30 +08:00
Sepro
6c016cf443 Place WebUI RSS description in sandboxed iframe 2020-10-19 06:39:19 +02:00
Chocobo1
ccdc3b201b Add missing semicolons 
Also trim trailing whitespaces along the way.
 2020-09-17 12:11:13 +08:00
Sepro
2b3c92a4a8 WebUI: Add RSS functionality 
Implemented RSS Reader and AutoDownloader in reference WebUI.
 2020-05-22 14:21:45 +02:00