squidy/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-12-21 07:57:22 -06:00
Code Issues Packages Projects Releases Wiki Activity
12,992 Commits 17 Branches 253 Tags
7af6ac18aa7a6aafc90793b8bc86b60748064d2d
Commit Graph

11106 Commits

Author SHA1 Message Date
Chocobo1
c165131c3f Disable stdout buffering for qbt-nox 
The messages printed out via stdout is usually important and short so
there is no reason to buffer them.

Closes #19984.
PR #20018.
 2023-11-26 15:36:50 +08:00
brvphoenix
9fde5634f1 Fix JS memory leak 
The memory leak can be reproduced easily by opening two web pages of qbittorrent so that the WebUI pages are updated with full_update = true. If you have a large number of torrents, such as 100 torrents, you can observe a rapid increase in memory usage.

This is caused by the incorrect usage of dispose and empty methods in the js codes and none of them garbage collect the elements. If event listeners are added to the DOM elements, those DOM elements will not be garbage collected at all event if they are not referenced or out of the scope, which will cause memory leaks. If some elements are expected to be removed, the correct way is to use destroy method instead.

https://github.com/mootools/mootools-core/blob/master/Docs/Element/Element.md#element-method-dispose-elementdispose
https://github.com/mootools/mootools-core/blob/master/Docs/Element/Element.md#element-method-empty-elementempty
https://github.com/mootools/mootools-core/blob/master/Docs/Element/Element.md#element-method-destroy-elementdestroy

Closes #19034.
PR #19969.
 2023-11-25 13:50:45 +08:00
Vladimir Golovnev
60eaff9fcb Simplify share ratio limits processing code 
PR #19971.
 2023-11-21 22:14:27 +03:00
Vladimir Golovnev
c3adc90f7e Show Add new torrent dialog on main window screen 
PR #19963.
Closes #19774.
 2023-11-21 22:13:22 +03:00
Chocobo1
6f7f418ec1 Improve error message when daemonizing failed 
PR #19959.
 2023-11-21 14:05:32 +08:00
Vlad Zahorodnii
ce34245aaf Fix parent widget of "Lock qBittorrent" submenu 
The parent widget of lockMenu is going to be used to derive the
transient parent window. Currently the parent widget of lockMenu is
the main window, therefore the main window is also going to be the
transient parent for lockMenu's window handle.

In other words, the "View" menu and "Lock qBittorrent" menu are
going to be considered as siblings by the window manager even though
the latter is nested inside the former.

On platforms like wayland, such popup hierarchies are illegal, popups
must be properly nested. qtwayland works around it, but it also prints
warning messages.

This change makes lockMenu a child of the view menu so they are
properly nested from the window manager point of view.

PR #19967.
Closes #19955.
 2023-11-20 20:39:21 +03:00
Vladimir Golovnev
ef06be63bf Remove incorrect assertions 
PR #19964.
 2023-11-20 20:37:55 +03:00
Vladimir Golovnev
a1c78a0455 Follow the parent category options 
PR #19957.
Closes #19941.
 2023-11-20 20:37:17 +03:00
Vladimir Golovnev
75c638e2f8 Add timeouts to network requests 
PR #19947.
 2023-11-18 09:55:33 +03:00
sledgehammer999
20bfd392ff Sync translations from Transifex and run lupdate 2023-11-14 03:05:55 +02:00
Vladimir Golovnev
8cc8ffabb0 Improve Torrent files watcher internals 
PR #19924.
 2023-11-13 14:27:04 +03:00
Vladimir Golovnev
2a20764d39 Add option to enable ".unwanted" folder 
PR #19926.
 2023-11-13 14:25:27 +03:00
Chocobo1
9d6d3a30eb Improve performance of getting torrent numbers via WebAPI 
PR #19919.
 2023-11-12 17:12:02 +08:00
Chocobo1
b67da4bebe Use natural sort for categories 
PR #19920.
 2023-11-12 17:11:39 +08:00
sledgehammer999
8e39ac7efd Merge pull request #19918 from sledgehammer999/webui_opt 
WebUI: Minor optimizations to the login page
 2023-11-11 16:00:26 +02:00
Vladimir Golovnev
fb497f3410 WebUI: Correctly set save path in RSS rules 
PR #19916.
Closes #19915.
 2023-11-11 16:04:13 +03:00
sledgehammer999
5d1d3fcf57 WebUI: Minor optimizations to the login page 2023-11-10 16:22:52 +02:00
Vladimir Golovnev
0f40fad74d Drop WebUI default credentials 
PR #19777.
 2023-11-10 07:18:42 +03:00
vik
28b5d7230c WebUI: Remove extra ')' in QBT_TR macro 
PR #19894.
 2023-11-08 08:32:25 +03:00
Vladimir Golovnev
c88bd7cb3f Improve free disk space checking for WebAPI 
Use single free disk space checker instance for all the web sessions.

PR #19855.
Closes #19732.
 2023-11-07 12:44:27 +03:00
thalieht
30d9978c97 Add copy comment functionality to the torrent list's context menu 
PR #19846.
Closes #18890.
 2023-11-07 12:42:31 +03:00
xavier2k6
f067ab1692 WebUI: Add "Moving" filter to side panel 
PR #19870.
 2023-11-06 16:23:59 +03:00
Chocobo1
f49507cb58 Exclude identical strings 
This gives slightly smaller final binary.

https://doc.qt.io/qt-6/linguist-lrelease.html#lrelease-options
>If the translated text is the same as the source text, exclude the
>message.
 2023-11-06 14:10:27 +08:00
Chocobo1
7c0e3baf5f Drop support for 32-bit Windows 
PR #19865.
 2023-11-06 14:10:01 +08:00
Chocobo1
6cfbc02d8f Expose Mark-of-the-Web setting in Options 2023-11-06 14:09:34 +08:00
Chocobo1
794cce38f3 Move some functions into Utils::OS namespace 
Also remove `Utils::Misc::getUserIDString()` since there are no use of
it.
 2023-11-06 14:09:34 +08:00
sledgehammer999
f20f009b78 Sync translations from Transifex and run lupdate 2023-11-05 21:57:07 +02:00
Vladimir Golovnev
e216a9cf53 Keep unwanted files in separate folder 
PR #19842.
Closes #13531.
 2023-11-05 11:00:06 +03:00
xavier2k6
0186f44bf4 Use appropriate icon for "moving" torrents in transfer list 
PR #19821.
 2023-11-04 12:09:47 +03:00
Bartu Özen
5db2c2c2be WebUI: Fix incorrect subcategory sorting 
PR #19833.
Closes #19756.
 2023-11-02 11:35:42 +03:00
Vladimir Golovnev
cecbb44a03 Allow to request torrents count via WebAPI 
PR #19831.
Closes #19731.
 2023-11-02 11:12:32 +03:00
Vladimir Golovnev
4a20a1660e Correctly handle changing save path of torrent w/o metadata 
PR #19829.
Closes #19824.
 2023-11-01 09:22:32 +03:00
Vladimir Golovnev
eddfaedc4d Update size of selected files when selection is changed 
PR #19827.
Closes #19818.
 2023-11-01 09:21:39 +03:00
Vitaly Cheptsov
e42d3f38cc Fix .torrent file upload on iPadOS 
Mobile Safari on iOS does report `ios` platform, but iPadOS reports `mac`
instead. It is common sense to check for touch points when this happens
to differentiate Mac and iPad.

PR #19822.
Closes #19057.

---------

Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
 2023-11-01 09:19:52 +03:00
Vladimir Golovnev
e7f38ec6ce Don't forget to delete TorrentContentAdaptor instance 
PR #19825.
Closes #19816.
 2023-10-31 10:20:23 +03:00
iomezk
a689ccf798 Add missing main window icon 
PR #19815.

---
Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
 2023-10-31 10:18:35 +03:00
Chocobo1
7bd8f262db Disable "limit virtual memory" routine on macOS 
This has no effect on macOS.
https://stackoverflow.com/questions/3274385/how-to-limit-memory-of-a-os-x-program-ulimit-v-neither-m-are-working

Closes #18656.
PR  #19805.
 2023-10-29 17:41:38 +08:00
Chocobo1
98576dacae Add support for quarantine on macOS 2023-10-29 17:41:08 +08:00
Chocobo1
b4642ca9d3 Use proper fallback value for Mark-of-the-Web URL 
References:
https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/components/services/quarantine/quarantine_win.cc#211
https://hg.mozilla.org/mozilla-central/file/bd568ad893882d37f094d43cba3f62c78982cd05/toolkit/components/downloads/DownloadIntegration.sys.mjs#l537
 2023-10-29 17:41:08 +08:00
Chocobo1
9b924c1931 Drop support for Windows < 10 2023-10-29 17:40:02 +08:00
Chocobo1
c671b7059e Drop unsupported keys 2023-10-29 17:40:02 +08:00
Chocobo1
347124812e Migrate away from deprecated functions 2023-10-29 17:40:02 +08:00
AgentConDier
bf95eb50da WebUI: Fix duplicate scrollbar on Transfer List 
The overlay scrollbars introduced in Firefox 100 take up no space,
breaking the existing overflow detection.
Add an extra check for `scrollHeight != clientHeight` which is able to
detect an overflow independent of scrollbar style.

PR #19779.

---------

Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
 2023-10-29 17:39:30 +08:00
Vladimir Golovnev
ee9390fecd Fix Enter key behavior when add new torrent 
PR #19787.
Closes #19760.
 2023-10-28 10:42:37 +03:00
Vladimir Golovnev
12674d2990 Prevent crash due to race condition when adding magnet link 
PR #19792.
 2023-10-28 10:41:53 +03:00
Hanabishi
35e4b35d12 Make WebUI error non-fatal 
* Do not exit the app when WebUI is failed for start.
* Print the error to stdout.

PR #19697.
Closes #19695.
Closes #19469.
 2023-10-24 13:32:21 +03:00
Vladimir Golovnev
6860c0d60d Allow to set qBittorrent as default program 
Register qBittorrent as possible default program for .torrent files and
magnet links during install.

PR #19446.
 2023-10-24 13:31:01 +03:00
Chocobo1
8d5022c715 Combine CSS properties 
PR #19730.
 2023-10-19 12:07:36 +08:00
Vladimir Golovnev
116b05009d CI: Use dynamic MSVC run-time library 
Otherwise, there is a conflict of run-time libraries used (since Qt DLLs are still use dynamic MSVCRT) that leads to strange errors.

PR #19718.
Closes #19701.
 2023-10-17 21:31:55 +03:00
Chocobo1
63499511cb Forward declare "Add torrent manager" type 
PR #19713.
 2023-10-16 14:52:09 +08:00