Commit Graph

9894 Commits

Author SHA1 Message Date
Chocobo1
d85703608a WebAPI: fix wrong behavior for shutdown action
Qt6 has changed implementation for `QCoreApplication::quit` and therefore it is not suitable
anymore.

Closes #17709.
Original PR #17720.
2022-09-16 12:06:47 +08:00
sledgehammer999
f9811ec3b0 Bump to 4.4.5 2022-08-30 02:40:51 +03:00
Vladimir Golovnev
e331db077c Fix missing trackers from magnet link
PR #17606.
2022-08-26 07:20:21 +03:00
sledgehammer999
4a56c3f5df Bump to 4.4.4 2022-08-22 15:45:31 +03:00
Chocobo1
99b5983143 Set HTTP method restriction on WebAPI actions 2022-08-15 11:57:15 +08:00
Vladimir Golovnev
c1e8849b40 Clear RSS parsing error after use
PR #17465.
2022-08-01 13:18:17 +03:00
brvphoenix
330f20171f Fix reply data can't be decompressed correctly
If the "Accept-Encoding" is not manually specified, it will be
automatically set to the supported encodings by QT and the reply data
will also be automatically decompressed in this case. Setting
"Accept-Encoding" manually will disable the "autodecompress" feature
before QT 6.3.0. Although QT 6.3.x has different behaviors, let QT
specify the "Accept-Encoding" and we will always obtain the decompressed
data.

The macro "QT_NO_COMPRESS" defined when QT is compiled will disable
the zlib support. We can manually address this exceptions.

Original PR #17438.
2022-07-31 13:29:17 +08:00
summer
b53eadaec8 Try to recover missing tags
Tags can go missing from config/resume data. Try to recover them to avoid inconsistent behavior.

Original PR: #17290.
2022-07-06 13:10:38 +08:00
Nick Korotysh
26d78f6462 Open destination folders on macOS in separate thread
In some unknown way, the one line in Objective-C affects Qt's main
loop causing the crash in QApplication::exec() on processing next
event after that call.

Even crash doesn't happen exactly after this call, it will happen
on application exit. Call stack and disassembly are the same in
all cases.

But running that code in another thread solves the issue.

Original PR: #17305.
2022-07-06 13:10:38 +08:00
Chocobo1
9890bb7501 Work around application stuttering on Windows
This is observed by unusual high page faults when the stuttering occurs.
With this workaround, the high page faults still occurs but the GUI remains responsive.
Original PR: #17311.
2022-07-06 13:10:38 +08:00
summer
c7daaf95fc Make working set limit available only on libtorrent 2.0.x builds
You can already control the cache size in libtorrent 1.2.x so it doesn't make sense to implement this limit for all use cases. Also there are some downsides to using working set size to limit memory usage such as unresponsive GUI when limit gets hit.
2022-07-05 12:36:07 +08:00
Vladimir Golovnev
b760f37093 Improve D-Bus notifications handling
Make notifications clickable on Linux by assigning "default" action.
Don't react to unrelated notifications clicked by keeping track of qBittorrent notifications IDs and filter out unrelated ones.
Make D-Bus Notifications interface proxy class to be maintained manually and fix coding style in it.
Closes #9084.
PR #17282.
2022-07-01 11:27:16 +03:00
Vladimir Golovnev
1130bf300a Fix incorrect "max outgoing port" setting
PR #17252.
2022-07-01 11:02:53 +03:00
Chocobo1
3f142360ed Fix wrong file names displayed in tooltip
Closes #17179.
2022-06-12 12:55:59 +08:00
brvphoenix
af07a98784 Don't decompress the reply data for Qt 6.3 2022-05-31 12:57:02 +08:00
sledgehammer999
6c546df70b Bump to 4.4.3.1 2022-05-24 23:10:49 +03:00
sledgehammer999
556db6a91a Regenerate translation files
Closes #17083
2022-05-24 01:50:17 +03:00
sledgehammer999
9ed9ffcaf2 Bump to 4.4.3 2022-05-22 19:36:51 +03:00
sledgehammer999
0036a02a72 Sync translations from Transifex and run lupdate 2022-05-22 19:14:42 +03:00
sledgehammer999
665bbc2421 CMake: Use installed Qt's translations for packaging 2022-05-22 18:57:59 +03:00
thalieht
8d408ffc8b Consistently emit signal when file "ignored" state is changed
PR #17042.
Closes #17037.
2022-05-20 08:29:22 +03:00
Chocobo1
aa39c7aae5 Fix wrong GUI behavior in "Optional IP address to bind to" setting
Previously the address field got erroneously reset to "All addresses"
when the network interface is down.
2022-05-20 12:29:31 +08:00
Vladimir Golovnev
7ad667e8d2 Add trackers in exported .torrent files
Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>

PR #17018.
2022-05-12 08:12:19 +03:00
summer
0c8220c9fd Prevent the new update box from blocking input on other dialogues
PR #16678.
2022-05-01 16:20:00 +03:00
summer
e9364b72f9 Reduce the number of hashing threads by default
This seems to be the culprit responsible for slower hash rate in RC2_0 releases
2022-05-01 12:31:27 +08:00
Chocobo1
a004f0afc5 WebUI: show correct location path
The `path` might contains '&' (delimit character) so it must be
encoded.
Closes #15976.
2022-05-01 12:28:09 +08:00
Chocobo1
d7f172060c Disable Linux-specific function when compiling for Windows 2022-05-01 12:28:09 +08:00
Chocobo1
9eae2b8ea9 Use correct type for comparisons
`_write()` actually returns `int` type.

And fix wrong function parameters.

Closes #16938.
Closes #16944.
2022-05-01 12:28:09 +08:00
Vladimir Golovnev
26e220e003 Avoid dereferencing null pointers
PR #16896.
Closes #16884 and similar issues.
2022-04-20 10:44:21 +03:00
Vladimir Golovnev
d7e9533e8c Don't corrupt IDs of v2 torrents
PR #16841.
2022-04-09 11:53:17 +03:00
Vladimir Golovnev
8306a41d11 Correctly apply content layout when "Skip hash check" is enabled
PR #16825.
2022-04-07 07:15:31 +03:00
Vladimir Golovnev
169c4991d5 Use an appropriate method to show modal dialog
PR #16809.
2022-04-06 08:39:34 +03:00
Vladimir Golovnev
78344a10fa Don't forget to create 'download_path' field
PR #16810.
2022-04-06 08:38:50 +03:00
Vladimir Golovnev
011ac90a52 Correctly handle changing of temp save path
PR #16753.
2022-03-28 07:32:13 +03:00
An0n
c1b38221d2 Fix WebUI crash due to missing tags from config
Tags can be missing from config but set inside .fastresume. May happen due to corrupted/deleted config.
Closes #11906.
PR #16739.
Original PR #16711.
2022-03-27 15:15:13 +08:00
Chocobo1
c621cae43b Don't use explicit memory management
And avoid dangling pointers.
Original PR #16705.
2022-03-27 14:17:42 +08:00
sledgehammer999
ede7c8acbb Bump to 4.4.2 2022-03-22 16:14:07 +02:00
sledgehammer999
a3d5ea829b Sync translations from Transifex and run lupdate 2022-03-22 15:47:50 +02:00
Vladimir Golovnev
c062f86bac Avoid integer overflow when calculating working set size
PR #16700.
2022-03-22 16:15:21 +03:00
Vladimir Golovnev
e5894831ec Prevent crash when open torrent destination folder
Uses the same workaround as Qt does to call ShellExecute() when you use QDesktopServices::openUrl().

PR #16670.
Closes #16423.
2022-03-20 21:54:34 +03:00
Vladimir Golovnev
f40e92f186 Remove incorrect/redundant code
PR #16663.
2022-03-19 08:58:18 +03:00
Vladimir Golovnev (Glassez)
049e376953 Properly handle metadata download for an existing torrent 2022-03-17 16:54:58 +03:00
Vladimir Golovnev (Glassez)
6dab4615aa Prevent loading resume data with inconsistent ID 2022-03-17 16:18:17 +03:00
Chocobo1
0b9a1dfd9d Add back erroneously removed alert handler
Fix up d26e582cc1.
Closes #16655.
PR #16657.
2022-03-17 12:37:32 +08:00
Vladimir Golovnev
11c45db2ec Allow to limit max memory working set size
PR #16485.
2022-03-12 21:40:02 +03:00
Chocobo1
d26e582cc1 Disable performance alert
The alert is too annoying and there is no control knob for tuning it, so
disable it in v4_4_x branch.
Closes #16462.
2022-03-07 13:38:20 +08:00
Vladimir Golovnev
5d161d2477 Correctly handle changing of global save paths 2022-03-04 14:07:58 +03:00
Kevin Cox
7b0b64a04e Fix UI crash when torrent is in non-existent category.
This checks that `category_list[categoryHash].torrents` is truthy before dereferencing it. In some cases the API response will have a torrent in a category that doesn't exist resulting in the check to return `undefined` which is not `null`. This broadens the check so that it will create the category even if null.
PR #16432.
2022-02-19 12:08:01 +08:00
sledgehammer999
4cb386af35 Bump to 4.4.1 2022-02-15 17:14:35 +02:00
sledgehammer999
0a4971c994 Partially revert e93c360db6
QShareDataPointer causes a crash upon start on 32bit Qt5 Windows.
This is a temporary fix in order to release v4.4.1.
2022-02-15 17:08:39 +02:00