Bump to 4.3.0.1

.appveyor.yml

@@ -3,7 +3,7 @@ version: '{branch}-{build}'
 # Do not build on tags (GitHub only)
 skip_tags: true
 
-image: Visual Studio 2022
+image: Visual Studio 2017
 
 branches:
   except:  # blacklist
@@ -13,8 +13,8 @@ environment:
   REPO_DIR: &REPO_DIR c:\qbittorrent
   CACHE_DIR: &CACHE_DIR c:\qbt_cache
 
-  QBT_VER_URL: https://builds.shiki.hu/appveyor/version_64
+  QBT_VER_URL: https://builds.shiki.hu/appveyor/version
-  QBT_LIB_URL: https://builds.shiki.hu/appveyor/qbt_libraries_64.7z
+  QBT_LIB_URL: https://builds.shiki.hu/appveyor/qbt_libraries.7z
 
 # project directory
 clone_folder: *REPO_DIR
@@ -38,12 +38,12 @@ install:
       appveyor DownloadFile "%QBT_LIB_URL%" -FileName "c:\qbt_lib.7z" && 7z x "c:\qbt_lib.7z" -o"%CACHE_DIR%" > nul &&
       COPY "c:\version_new" "%CACHE_DIR%\version")
   # Qt stay compressed in cache
-  - 7z x "%CACHE_DIR%\qt5_64.7z" -o"c:\qbt" > nul
+  - 7z x "%CACHE_DIR%\qt5_32.7z" -o"c:\qbt" > nul
 
 before_build:
   # setup env
-  - CALL "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
+  - CALL "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvars32.bat"
-  - SET PATH=%PATH%;C:\Qt\5.15.2\msvc2019_64\bin;%CACHE_DIR%\jom
+  - SET PATH=%PATH%;c:\qbt\qt5_32\bin;%CACHE_DIR%\jom;
   # setup project
   - COPY /Y "%CACHE_DIR%\conf.pri" "%REPO_DIR%"
   # workarounds
@@ -56,38 +56,4 @@ build_script:
   - qmake qbittorrent.pro && cd src && qmake src.pro
   - jom -j2 -f Makefile.Release
 
-after_build:
-  - cd "%REPO_DIR%"
-  - MKDIR upload
-  - COPY dist\windows\qt.conf upload
-  - COPY src\release\qbittorrent.exe upload
-  - COPY src\release\qbittorrent.pdb upload
-  - COPY "%CACHE_DIR%\base\bin\libcrypto-1_1-x64.dll" upload
-  - COPY "%CACHE_DIR%\base\bin\libssl-1_1-x64.dll" upload
-  - COPY "%CACHE_DIR%\base\lib\torrent-rasterbar.dll" upload
-  - COPY "%CACHE_DIR%\base\lib\zlib1.dll" upload
-  - COPY C:\Qt\5.15.2\msvc2019_64\bin\Qt5Core.dll upload
-  - COPY C:\Qt\5.15.2\msvc2019_64\bin\Qt5Gui.dll upload
-  - COPY C:\Qt\5.15.2\msvc2019_64\bin\Qt5Network.dll upload
-  - COPY C:\Qt\5.15.2\msvc2019_64\bin\Qt5Sql.dll upload
-  - COPY C:\Qt\5.15.2\msvc2019_64\bin\Qt5Svg.dll upload
-  - COPY C:\Qt\5.15.2\msvc2019_64\bin\Qt5Widgets.dll upload
-  - COPY C:\Qt\5.15.2\msvc2019_64\bin\Qt5WinExtras.dll upload
-  - COPY C:\Qt\5.15.2\msvc2019_64\bin\Qt5Xml.dll upload
-  - MKDIR upload\plugins\iconengines
-  - COPY C:\Qt\5.15.2\msvc2019_64\plugins\iconengines\qsvgicon.dll upload\plugins\iconengines
-  - MKDIR upload\plugins\imageformats
-  - COPY C:\Qt\5.15.2\msvc2019_64\plugins\imageformats\qico.dll upload\plugins\imageformats
-  - COPY C:\Qt\5.15.2\msvc2019_64\plugins\imageformats\qsvg.dll upload\plugins\imageformats
-  - MKDIR upload\plugins\platforms
-  - COPY C:\Qt\5.15.2\msvc2019_64\plugins\platforms\qwindows.dll upload\plugins\platforms
-  - MKDIR upload\plugins\sqldrivers
-  - COPY C:\Qt\5.15.2\msvc2019_64\plugins\sqldrivers\qsqlite.dll upload\plugins\sqldrivers
-  - MKDIR upload\plugins\styles
-  - COPY C:\Qt\5.15.2\msvc2019_64\plugins\styles\qwindowsvistastyle.dll upload\plugins\styles
-
 test: off
-
-artifacts:
-  - path: upload
-    name: qBittorrent-Appveyor_Windows-x64

.github/FUNDING.yml

@@ -1 +0,0 @@
-custom: "https://www.qbittorrent.org/donate.php"

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,20 @@
+**Please provide the following information**
+
+### qBittorrent version and Operating System
+(type here)
+
+### If on linux, libtorrent-rasterbar and Qt version
+(type here)
+
+### What is the problem
+(type here)
+
+### What is the expected behavior
+(type here)
+
+### Steps to reproduce
+(type here)
+
+### Extra info(if any)
+(type here)
+

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,76 +0,0 @@
-name: Bug Report
-description: File a bug report to help improve qBittorrent user experience.
-body:
-  - type: markdown
-    attributes:
-      value: |
-        #### ADVISORY
-        "We do not support any versions older than the current release series"
-
-        "We do not support any 3rd party/forked versions e.g. `portableapps`/`Enhanced Edition`etc."
-
-        "Please post all details in **English**."
-
-        #### Prerequisites before submitting an issue!
-        - Read the issue reporting section in the **[contributing guidelines](https://github.com/qbittorrent/qBittorrent/blob/master/CONTRIBUTING.md)**, to know how to submit a good bug report with the required information.
-        - Verify that the issue is not fixed and is reproducible in the **[latest official qBittorrent version](https://www.qbittorrent.org/download.php).**
-        - (Optional, but recommended) Verify that the issue is not fixed and is reproducible in the latest CI (**[macOS](https://github.com/qbittorrent/qBittorrent/actions/workflows/ci_macos.yaml?query=branch%3Amaster+event%3Apush)** / **[Ubuntu](https://github.com/qbittorrent/qBittorrent/actions/workflows/ci_ubuntu.yaml?query=branch%3Amaster+event%3Apush)** / **[Windows](https://github.com/qbittorrent/qBittorrent/actions/workflows/ci_windows.yaml?query=branch%3Amaster+event%3Apush)**) builds.
-        - Check the **[frequent/common issues list](https://github.com/qbittorrent/qBittorrent/projects/2)** and perform a **[search of the issue tracker (including closed ones)](https://github.com/qbittorrent/qBittorrent/issues)** to avoid posting a duplicate.
-        - Make sure this is not a support request or question, both of which are better suited for either the **[discussions section](https://github.com/qbittorrent/qBittorrent/discussions)**, **[forum](https://qbforums.shiki.hu/)**, or **[subreddit](https://www.reddit.com/r/qBittorrent/)**.
-        - Verify that the **[wiki](https://github.com/qbittorrent/qBittorrent/wiki)** did not contain a suitable solution either.
-        - If relevant to issue/when asked, the qBittorrent preferences file, qBittorrent.log & watched_folders.json (if using "Watched Folders" feature) must be provided.
-          See **[Where does qBittorrent save its settings?](https://github.com/qbittorrent/qBittorrent/wiki/Frequently-Asked-Questions#Where_does_qBittorrent_save_its_settings)**
-
-  - type: textarea
-    attributes:
-      label: qBittorrent & operating system versions
-      description: |
-        Qt and libtorrent-rasterbar versions are required when: 1. You are using linux. 2. You are not using an official build downloaded from our website.
-
-        Example of preferred formatting:
-        qBittorrent: 4.3.7 x64
-        Operating system: Windows 10 Pro 21H1/2009 x64
-        Qt: 5.15.2
-        libtorrent-rasterbar: 1.2.14
-      placeholder: |
-        qBittorrent:
-        Operating system:
-        Qt:
-        libtorrent-rasterbar:
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: What is the problem?
-      description: Please add the "crash report" (if encountered) or give a clear and concise description of problem.
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: Steps to reproduce
-      description: Please provide reliable steps to reproduce the problem.
-      placeholder: |
-        1. First step
-        2. Second step
-        3. and so on...
-    validations:
-      required: false
-
-  - type: textarea
-    attributes:
-      label: Additional context
-      description: Add screenshots etc. (Anything that will provide more context about the problem)
-    validations:
-      required: false
-
-  - type: textarea
-    attributes:
-      label: Log(s) & preferences file(s)
-      description: |
-        Add these files: qBittorrent preferences file, qBittorrent.log & watched_folders.json (if using "Watched Folders" feature).
-        See **[Where does qBittorrent save its settings?](https://github.com/qbittorrent/qBittorrent/wiki/Frequently-Asked-Questions#Where_does_qBittorrent_save_its_settings)**
-        #### Note: It's the user's responsibility to redact any sensitive information
-    validations:
-      required: false

.github/ISSUE_TEMPLATE/config.yml

@@ -1,17 +0,0 @@
-blank_issues_enabled: false
-contact_links:
-  - name: Wiki
-    url: "https://github.com/qbittorrent/qBittorrent/wiki/"
-    about: "Consult the wiki first (especially the FAQ), it might already contain the information you are looking for"
-
-  - name: Question
-    url: "https://github.com/qbittorrent/qBittorrent/discussions"
-    about: "Please ask questions related to usage/setup/support/non-issue development discussion in the Discussions section"
-
-  - name: Question
-    url: "http://forum.qbittorrent.org/"
-    about: "Alternatively, ask on the official forum"
-
-  - name: Question
-    url: "https://www.reddit.com/r/qBittorrent/"
-    about: "Alternatively, use the subreddit"

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,37 +0,0 @@
-name: Feature Request
-description: Suggest a new feature or enhancement for qBittorrent.
-labels: ["Feature request"]
-body:
-  - type: markdown
-    attributes:
-      value: |
-        #### ADVISORY
-
-        "Please post all details in **English**."
-
-        #### Prerequisites before submitting a feature request!
-        - Read the feature request section in the **[contributing guidelines](https://github.com/qbittorrent/qBittorrent/blob/master/CONTRIBUTING.md)**, to know how to submit a good feature request with the required information.
-        - Verify that the feature being requested is not available in the **[latest official qBittorrent version](https://www.qbittorrent.org/download.php).**
-        - (Optional but recommended) Verify that the feature being requested is not available in the latest CI (**[macOS](https://github.com/qbittorrent/qBittorrent/actions/workflows/ci_macos.yaml?query=branch%3Amaster+event%3Apush)** / **[Ubuntu](https://github.com/qbittorrent/qBittorrent/actions/workflows/ci_ubuntu.yaml?query=branch%3Amaster+event%3Apush)** / **[Windows](https://github.com/qbittorrent/qBittorrent/actions/workflows/ci_windows.yaml?query=branch%3Amaster+event%3Apush)**) builds.
-        - Search the issue tracker with the **[feature request filter](https://github.com/qbittorrent/qBittorrent/issues?q=is%3Aopen+is%3Aissue+label%3A%22Feature+request%22)** for similar feature requests (including closed ones) to avoid posting a duplicate.
-        - Make sure this is not a support request or question, both of which are better suited for either the **[discussions section](https://github.com/qbittorrent/qBittorrent/discussions)**, **[forum](https://qbforums.shiki.hu/)**, or **[subreddit](https://www.reddit.com/r/qBittorrent/)**.
-        - Verify that the **[wiki](https://github.com/qbittorrent/qBittorrent/wiki)** did not contain a suitable solution either.
-
-  - type: textarea
-    attributes:
-      label: Suggestion
-    validations:
-      required: false
-
-  - type: textarea
-    attributes:
-      label: Use case
-    validations:
-      required: false
-
-  - type: textarea
-    attributes:
-      label: Extra info/examples/attachments
-      description: Add screenshots etc. (Anything that will give us more context about what is being requested!)
-    validations:
-      required: false

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,5 +0,0 @@
-<!--
-MANDATORY Before submitting your work, make sure you have:
-1. Read https://github.com/qbittorrent/qBittorrent/blob/master/CONTRIBUTING.md#opening-a-pull-request
-2. Delete this comment block
--->

.github/SUPPORT.md

@@ -1,18 +0,0 @@
-# Support Resources
-
-The issue tracker is only for bug reports/feature requests related to the project itself.
-
-Please do not use the issue tracker for questions about general program usage,
-how BitTorrent (the protocol) works in general, etc.
-
-For such questions, use one of the following community support resources:
-
-* The [discussions section][discussions-url]
-
-* The official forum [official forum][forum-url]
-
-* The [qBittorrent subreddit][subreddit-url]
-
-[discussions-url]: https://github.com/qbittorrent/qBittorrent/discussions
-[forum-url]: http://forum.qbittorrent.org/
-[subreddit-url]: https://www.reddit.com/r/qBittorrent/

.github/workflows/check_translation_tag.py

@@ -1,68 +0,0 @@
-#!/usr/bin/env python3
-
-# A pre-commit hook for detecting problematic <translation> tags
-# Copyright (C) 2021  Mike Tzou (Chocobo1)
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License
-# as published by the Free Software Foundation; either version 2
-# of the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
-#
-# In addition, as a special exception, the copyright holders give permission to
-# link this program with the OpenSSL project's "OpenSSL" library (or with
-# modified versions of it that use the same license as the "OpenSSL" library),
-# and distribute the linked executables. You must obey the GNU General Public
-# License in all respects for all of the code used other than "OpenSSL".  If you
-# modify file(s), you may extend this exception to your version of the file(s),
-# but you are not obligated to do so. If you do not wish to do so, delete this
-# exception statement from your version.
-
-from typing import Optional, Sequence
-import argparse
-import re
-
-def main(argv: Optional[Sequence[str]] = None) -> int:
-    parser = argparse.ArgumentParser()
-    parser.add_argument('filenames', nargs='*', help='Filenames to check')
-    args = parser.parse_args(argv)
-
-    error_msg = ""
-    regex = re.compile(r"\s*</translation>")
-
-    for filename in args.filenames:
-        line_counter = 1
-        error_buffer = ""
-
-        with open(filename) as file:
-            try:
-                for line in file:
-                    if (match := regex.match(line)) is not None:
-                        error_buffer += str(f"Defect file: \"{filename}\"\n"
-                              f"Line: {line_counter}\n"
-                              f"Column span: {match.span()}\n"
-                              f"Part: \"{match.group()}\"\n\n")
-                    line_counter += 1
-
-            except UnicodeDecodeError as error:
-                # not a text file, skip
-                continue
-
-        error_msg += error_buffer
-
-    if len(error_msg) > 0:
-        print(error_msg)
-        return 1
-
-    return 0
-
-if __name__ == '__main__':
-    exit(main())

.github/workflows/ci.yaml

@@ -0,0 +1,244 @@
+name: GitHub Actions CI
+
+# Cache is used for all Windows and macOS dependencies (size approx. 1230 * 2 + 1850 = 4310 MiB)
+# Cache is not used for Ubuntu builds, because it already has all dependencies except
+# the appropriate libtorrent version, which only takes 3-5 minutes to build from source anyway
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    types: [edited, opened, reopened, synchronize]
+    branches: [ master ]
+
+env:
+  # Qt: 5.15.0
+  # libtorrent: RC_1_2 HEAD, 1.2.10
+  VCPKG_COMMIT: 32eccc18191fbb57b159784a1724d2d00613ae82
+  VCPKG_DEST_MACOS: /Users/runner/qbt_tools/vcpkg
+  VCPKG_DEST_WIN: C:\qbt_tools\vcpkg
+  UBUNTU_LIBTORRENT_VERSION: libtorrent-1.2.10
+
+jobs:
+
+  ci_ubuntu:
+    name: Ubuntu
+
+    strategy:
+      matrix:
+        os: [ubuntu-20.04, ubuntu-18.04]
+        qbt_gui: ["GUI=ON", "GUI=OFF"]
+      fail-fast: false
+
+    runs-on: ${{ matrix.os }}
+
+    defaults:
+      run:
+        shell: bash
+
+    steps:
+    - name: checkout repository
+      uses: actions/checkout@v2.3.2
+
+    - name: install all build dependencies except libtorrent from Ubuntu repos
+      run: |
+        sudo apt update
+        sudo apt install \
+          build-essential cmake git ninja-build pkg-config \
+          libssl-dev libgeoip-dev zlib1g-dev \
+          libboost-dev libboost-chrono-dev libboost-random-dev libboost-system-dev \
+          libqt5svg5-dev qtbase5-dev qttools5-dev
+
+    - name: install libtorrent from source
+      run: |
+        git clone https://github.com/arvidn/libtorrent && cd libtorrent
+        git checkout ${{ env.UBUNTU_LIBTORRENT_VERSION }}
+        cmake -B cmake-build-dir -G "Ninja" \
+          -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+          -Ddeprecated-functions=OFF \
+          --graphviz=cmake-build-dir/target_graph.dot
+        cmake --build cmake-build-dir
+        sudo cmake --install cmake-build-dir --prefix /usr/local
+
+    - name: build qBittorrent
+      run: |
+        cmake -B build -G "Ninja" \
+          -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+          -D${{ matrix.qbt_gui }} \
+          -DVERBOSE_CONFIGURE=ON \
+          --graphviz=build/target_graph.dot
+        cmake --build build
+
+    - name: upload artifact as zip
+      uses: actions/upload-artifact@v2.1.3
+      with:
+        name: qBittorrent-CI-Ubuntu_${{ matrix.os }}-${{ matrix.qbt_gui }}
+        path: |
+          build/compile_commands.json
+          build/target_graph.dot
+          build/qbittorrent
+          build/qbittorrent-nox
+          libtorrent/cmake-build-dir/compile_commands.json
+          libtorrent/cmake-build-dir/target_graph.dot
+
+  ci_windows:
+    name: Windows + vcpkg
+
+    runs-on: windows-2019
+
+    defaults:
+      run:
+        shell: pwsh
+
+    steps:
+    - name: checkout repository
+      uses: actions/checkout@v2.3.2
+
+    # - ninja is needed for building qBittorrent (because it's preferrable, not a hard requirement)
+    - name: install additional required packages with chocolatey
+      run: |
+        choco install ninja
+
+    - name: setup vcpkg (cached, if possible)
+      uses: lukka/run-vcpkg@v3.3
+      with:
+        vcpkgDirectory: ${{ env.VCPKG_DEST_WIN }}
+        vcpkgGitCommitId: ${{ env.VCPKG_COMMIT }}
+        setupOnly: true
+
+    # Tell vcpkg to only build Release variants of the dependencies
+    - name: configure vcpkg triplet overlay for release builds only
+      run: |
+        New-Item -Path ${{ github.workspace }} -Name "triplets_overlay" -ItemType Directory
+        Copy-Item ${{ env.RUNVCPKG_VCPKG_ROOT }}/triplets/x64-windows-static.cmake `
+          ${{ github.workspace }}/triplets_overlay/x64-windows-static-release.cmake
+        Add-Content ${{ github.workspace }}/triplets_overlay/x64-windows-static-release.cmake `
+          -Value "set(VCPKG_BUILD_TYPE release)"
+
+    # clear buildtrees after each package installation to reduce disk space requirements
+    - name: install dependencies via vcpkg
+      run: |
+        $packages = `
+          "boost-circular-buffer:x64-windows-static-release",
+          "libtorrent:x64-windows-static-release",
+          "qt5-base:x64-windows-static-release",
+          "qt5-svg:x64-windows-static-release",
+          "qt5-tools:x64-windows-static-release",
+          "qt5-winextras:x64-windows-static-release"
+        foreach($package in $packages)
+        {
+          ${{ env.RUNVCPKG_VCPKG_ROOT }}/vcpkg.exe install $package `
+            --overlay-triplets=${{ github.workspace }}/triplets_overlay `
+            --clean-after-build
+        }
+
+    # NOTE: this is necessary to correctly find and use cl.exe with the Ninja generator for now
+    - name: setup devcmd
+      uses: ilammy/msvc-dev-cmd@v1.3.0
+
+    - name: build qBittorrent
+      shell: cmd
+      run: |
+        cmake -B build -G "Ninja" ^
+          -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo ^
+          -DCMAKE_TOOLCHAIN_FILE=${{ env.VCPKG_DEST_WIN }}\scripts\buildsystems\vcpkg.cmake ^
+          -DVCPKG_TARGET_TRIPLET=x64-windows-static-release ^
+          -DVERBOSE_CONFIGURE=ON ^
+          -DMSVC_RUNTIME_DYNAMIC=OFF ^
+          --graphviz=build\target_graph.dot
+        cmake --build build
+
+    - name: upload artifact as zip
+      uses: actions/upload-artifact@v2.1.3
+      with:
+        name: qBittorrent-CI-Windows_x64-static-release
+        path: |
+          build/compile_commands.json
+          build/target_graph.dot
+          build/qbittorrent.exe
+          build/qbittorrent.pdb
+          dist/windows/qt.conf
+
+  ci_macos:
+    name: macOS + vcpkg
+
+    strategy:
+      matrix:
+        qbt_gui: ["GUI=ON", "GUI=OFF"]
+      fail-fast: false
+
+    runs-on: macos-10.15
+
+    defaults:
+      run:
+        shell: pwsh
+
+    steps:
+    - name: checkout repository
+      uses: actions/checkout@v2.3.2
+
+    # - ninja is needed for building qBittorrent (because it's preferrable, not a hard requirement)
+    # - pkg-config is needed for some vcpkg installations
+    - name: install additional required packages with homebrew
+      shell: bash
+      run: |
+        brew install ninja pkg-config
+
+    - name: setup vcpkg (cached, if possible)
+      uses: lukka/run-vcpkg@v3.3
+      with:
+        vcpkgDirectory: ${{ env.VCPKG_DEST_MACOS }}
+        vcpkgGitCommitId: ${{ env.VCPKG_COMMIT }}
+        setupOnly: true
+
+    - name: configure vcpkg triplet overlay for release builds only
+      run: |
+        New-Item -Path ${{ github.workspace }} -Name "triplets_overlay" -ItemType Directory
+        Copy-Item ${{ env.RUNVCPKG_VCPKG_ROOT }}/triplets/x64-osx.cmake `
+          ${{ github.workspace }}/triplets_overlay/x64-osx-release.cmake
+        Add-Content ${{ github.workspace }}/triplets_overlay/x64-osx-release.cmake `
+          -Value "set(VCPKG_BUILD_TYPE release)"
+
+    # NOTE: Avoids a libtorrent ABI issue. See https://github.com/arvidn/libtorrent/issues/4965
+    - name: force AppleClang to compile libtorrent with C++14
+      run: |
+        (Get-Content -path ${{ env.RUNVCPKG_VCPKG_ROOT }}/ports/libtorrent/portfile.cmake).Replace( `
+          '${FEATURE_OPTIONS}', '${FEATURE_OPTIONS} -DCMAKE_CXX_STANDARD=14') `
+          | Set-Content -Path ${{ env.RUNVCPKG_VCPKG_ROOT }}/ports/libtorrent/portfile.cmake
+
+    - name: install dependencies via vcpkg
+      run: |
+        $packages = `
+          "boost-circular-buffer:x64-osx-release",
+          "libtorrent:x64-osx-release",
+          "qt5-base:x64-osx-release",
+          "qt5-svg:x64-osx-release",
+          "qt5-tools:x64-osx-release",
+          "qt5-macextras:x64-osx-release"
+        foreach($package in $packages)
+        {
+          ${{ env.RUNVCPKG_VCPKG_ROOT }}/vcpkg install $package `
+            --overlay-triplets=${{ github.workspace }}/triplets_overlay `
+            --clean-after-build
+        }
+
+    - name: build qBittorrent
+      shell: bash
+      run: |
+        cmake -B build -G "Ninja" -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+          -DCMAKE_TOOLCHAIN_FILE=${{ env.VCPKG_DEST_MACOS }}/scripts/buildsystems/vcpkg.cmake \
+          -DVCPKG_TARGET_TRIPLET=x64-osx-release \
+          -D${{ matrix.qbt_gui }} \
+          -DVERBOSE_CONFIGURE=ON \
+          --graphviz=build/target_graph.dot
+        cmake --build build
+
+    - name: upload artifact as zip
+      uses: actions/upload-artifact@v2.1.3
+      with:
+        name: qBittorrent-CI-macOS_x64-static-release_${{ matrix.qbt_gui }}
+        path: |
+          build/compile_commands.json
+          build/target_graph.dot
+          build/qbittorrent.app
+          build/qbittorrent-nox.app

.github/workflows/ci_file_health.yaml

@@ -1,17 +0,0 @@
-name: CI - File health
-
-on: [pull_request, push]
-
-jobs:
-  ci:
-    name: Check
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Install tools
-        uses: actions/setup-python@v2
-
-      - name: Check files
-        uses: pre-commit/action@v2.0.3

.github/workflows/ci_macos.yaml

@@ -1,104 +0,0 @@
-name: CI - macOS
-on: [pull_request, push]
-
-jobs:
-  ci:
-    name: Build
-    runs-on: macos-latest
-
-    strategy:
-      fail-fast: false
-      matrix:
-        libt_version: ["2.0.5", "1.2.15"]
-        qbt_gui: ["GUI=ON", "GUI=OFF"]
-        qt_version: ["5.15.2", "6.2.0"]
-        exclude:
-          - libt_version: "1.2.15"
-            qt_version: "6.2.0"
-
-    env:
-      openssl_root: /usr/local/opt/openssl@1.1
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Install dependencies
-        run: |
-          brew update > /dev/null
-          brew install \
-            cmake ninja \
-            boost openssl@1.1 zlib
-
-      - name: Setup ccache
-        uses: Chocobo1/setup-ccache-action@v1
-        with:
-          update_packager_index: false
-
-      - name: Install Qt
-        uses: jurplel/install-qt-action@v2
-        with:
-          version: ${{ matrix.qt_version }}
-
-      - name: Install libtorrent
-        run: |
-          git clone \
-            --branch v${{ matrix.libt_version }} \
-            --depth 1 \
-            --recurse-submodules \
-            https://github.com/arvidn/libtorrent.git
-          cd libtorrent
-          cmake \
-            -B build \
-            -G "Ninja" \
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-            -DCMAKE_CXX_STANDARD=17 \
-            -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-            -Ddeprecated-functions=OFF \
-            -DOPENSSL_ROOT_DIR="${{ env.openssl_root }}"
-          cmake --build build
-          sudo cmake --install build
-
-      - name: Build qBittorrent (Qt5)
-        if: ${{ startsWith(matrix.qt_version, 5) }}
-        run: |
-          lupdate -extensions c,cpp,h,hpp,ui ./
-          cmake \
-            -B build \
-            -G "Ninja" \
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-            -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-            -DOPENSSL_ROOT_DIR="${{ env.openssl_root }}" \
-            -DVERBOSE_CONFIGURE=ON \
-            -D${{ matrix.qbt_gui }}
-          cmake --build build
-
-      - name: Build qBittorrent (Qt6)
-        if: ${{ startsWith(matrix.qt_version, 6) }}
-        run: |
-          lupdate -extensions c,cpp,h,hpp,ui ./
-          cmake \
-            -B build \
-            -G "Ninja" \
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-            -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-            -DOPENSSL_ROOT_DIR="${{ env.openssl_root }}" \
-            -DQT6=ON \
-            -DVERBOSE_CONFIGURE=ON \
-            -D${{ matrix.qbt_gui }}
-          cmake --build build
-
-      - name: Prepare build artifacts
-        run: |
-          mkdir upload
-          mv build/qbittorrent*.app upload
-          mkdir upload/cmake
-          cp build/compile_commands.json upload/cmake
-          mkdir upload/cmake/libtorrent
-          cp libtorrent/build/compile_commands.json upload/cmake/libtorrent
-
-      - name: Upload build artifacts
-        uses: actions/upload-artifact@v2
-        with:
-          name: qBittorrent-CI_macOS_${{ matrix.qbt_gui }}_libtorrent-${{ matrix.libt_version }}_Qt-${{ matrix.qt_version }}
-          path: upload

.github/workflows/ci_ubuntu.yaml

@@ -1,102 +0,0 @@
-name: CI - Ubuntu
-on: [pull_request, push]
-
-jobs:
-  ci:
-    name: Build
-    runs-on: ubuntu-20.04
-
-    strategy:
-      fail-fast: false
-      matrix:
-        libt_version: ["2.0.5", "1.2.15"]
-        qbt_gui: ["GUI=ON", "GUI=OFF"]
-        qt_version: ["5.15.2", "6.2.0"]
-        exclude:
-          - libt_version: "1.2.15"
-            qt_version: "6.2.0"
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Install dependencies
-        run: |
-          sudo apt update
-          sudo apt install \
-            build-essential cmake ninja-build pkg-config \
-            libboost-dev libssl-dev zlib1g-dev
-
-      - name: Setup ccache
-        uses: Chocobo1/setup-ccache-action@v1
-        with:
-          update_packager_index: false
-          ccache_options: |
-            max_size=2G
-
-      - name: Install Qt
-        uses: jurplel/install-qt-action@v2
-        with:
-          version: ${{ matrix.qt_version }}
-
-      - name: Install libtorrent
-        run: |
-          git clone \
-            --branch v${{ matrix.libt_version }} \
-            --depth 1 \
-            --recurse-submodules \
-            https://github.com/arvidn/libtorrent.git
-          cd libtorrent
-          cmake \
-            -B build \
-            -G "Ninja" \
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-            -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-            -Ddeprecated-functions=OFF
-          cmake --build build
-          sudo cmake --install build
-
-      - name: Build qBittorrent (Qt5)
-        if: ${{ startsWith(matrix.qt_version, 5) }}
-        run: |
-          lupdate -extensions c,cpp,h,hpp,ui ./
-          cmake \
-            -B build \
-            -G "Ninja" \
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-            -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-            -DCMAKE_INSTALL_PREFIX="/usr" \
-            -DVERBOSE_CONFIGURE=ON \
-            -D${{ matrix.qbt_gui }}
-          cmake --build build
-          DESTDIR="qbittorrent" cmake --install build
-
-      - name: Build qBittorrent (Qt6)
-        if: ${{ startsWith(matrix.qt_version, 6) }}
-        run: |
-          lupdate -extensions c,cpp,h,hpp,ui ./
-          cmake \
-            -B build \
-            -G "Ninja" \
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-            -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-            -DCMAKE_INSTALL_PREFIX="/usr" \
-            -DQT6=ON \
-            -DVERBOSE_CONFIGURE=ON \
-            -D${{ matrix.qbt_gui }}
-          cmake --build build
-          DESTDIR="qbittorrent" cmake --install build
-
-      - name: Prepare build artifacts
-        run: |
-          mkdir upload
-          mkdir upload/cmake
-          cp build/compile_commands.json upload/cmake
-          mkdir upload/cmake/libtorrent
-          cp libtorrent/build/compile_commands.json upload/cmake/libtorrent
-
-      - name: Upload build artifacts
-        uses: actions/upload-artifact@v2
-        with:
-          name: build-info_ubuntu-20.04-x64_${{ matrix.qbt_gui }}_libtorrent-${{ matrix.libt_version }}_Qt-${{ matrix.qt_version }}
-          path: upload

.github/workflows/ci_webui.yaml

@@ -1,32 +0,0 @@
-name: CI - WebUI
-
-on: [pull_request, push]
-
-jobs:
-  ci:
-    name: Check
-    runs-on: ubuntu-latest
-
-    defaults:
-      run:
-        working-directory: src/webui/www
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Setup nodejs
-        uses: actions/setup-node@v2
-        with:
-          node-version: 'lts/*'
-
-      - name: Install tools
-        run: npm install
-
-      - name: Lint code
-        run: npm run lint
-
-      - name: Format code
-        run: |
-          npm run format
-          git diff --exit-code

.github/workflows/ci_windows.yaml

@@ -1,154 +0,0 @@
-name: CI - Windows
-on: [pull_request, push]
-
-jobs:
-  ci:
-    name: Build
-    runs-on: windows-latest
-
-    strategy:
-      fail-fast: false
-      matrix:
-        libt_version: ["2.0.5", "1.2.15"]
-
-    env:
-      boost_path: "${{ github.workspace }}/../boost"
-      libtorrent_path: "${{ github.workspace }}/libtorrent"
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Setup devcmd
-        uses: ilammy/msvc-dev-cmd@v1
-
-      - name: Install build tools
-        run: |
-          choco install ninja
-
-      # use the preinstalled vcpkg from image
-      # https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#package-management
-      - name: Setup vcpkg
-        uses: lukka/run-vcpkg@v7
-        with:
-          vcpkgDirectory: C:/vcpkg
-          doNotUpdateVcpkg: true  # the preinstalled vcpkg is updated regularly
-          setupOnly: true
-
-      - name: Install dependencies from vcpkg
-        run: |
-          # tell vcpkg to only build Release variants of the dependencies
-          New-Item `
-            -Path "${{ github.workspace }}" `
-            -Name "triplets_overlay" `
-            -ItemType Directory
-          Copy-Item `
-            "${{ env.RUNVCPKG_VCPKG_ROOT }}/triplets/x64-windows-static.cmake" `
-            "${{ github.workspace }}/triplets_overlay/x64-windows-static-release.cmake"
-          Add-Content `
-            "${{ github.workspace }}/triplets_overlay/x64-windows-static-release.cmake" `
-            -Value "set(VCPKG_BUILD_TYPE release)"
-          # clear buildtrees after each package installation to reduce disk space requirements
-          $packages = `
-            "openssl:x64-windows-static-release",
-            "zlib:x64-windows-static-release"
-          ${{ env.RUNVCPKG_VCPKG_ROOT }}/vcpkg.exe upgrade `
-            --overlay-triplets="${{ github.workspace }}/triplets_overlay" `
-            --no-dry-run
-          ${{ env.RUNVCPKG_VCPKG_ROOT }}/vcpkg.exe install `
-            --overlay-triplets="${{ github.workspace }}/triplets_overlay" `
-            --clean-after-build `
-            $packages
-
-      - name: Install boost
-        run: |
-          aria2c `
-            "https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.7z" `
-            -d "${{ runner.temp }}" `
-            -o "boost.7z"
-          7z x "${{ runner.temp }}/boost.7z" -o"${{ github.workspace }}/.."
-          move "${{ github.workspace }}/../boost_*" "${{ env.boost_path }}"
-
-      - name: Install Qt
-        uses: jurplel/install-qt-action@v2
-        with:
-          version: "5.15.2"
-
-      - name: Install libtorrent
-        run: |
-          git clone `
-            --branch v${{ matrix.libt_version }} `
-            --depth 1 `
-            --recurse-submodules `
-            https://github.com/arvidn/libtorrent.git
-          cd libtorrent
-          cmake `
-            -B build `
-            -G "Ninja" `
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo `
-            -DCMAKE_EXPORT_COMPILE_COMMANDS=ON `
-            -DCMAKE_INSTALL_PREFIX="${{ env.libtorrent_path }}" `
-            -DCMAKE_TOOLCHAIN_FILE="${{ env.RUNVCPKG_VCPKG_ROOT }}/scripts/buildsystems/vcpkg.cmake" `
-            -DBOOST_ROOT="${{ env.boost_path }}" `
-            -DBUILD_SHARED_LIBS=OFF `
-            -Ddeprecated-functions=OFF `
-            -Dstatic_runtime=ON `
-            -DVCPKG_TARGET_TRIPLET=x64-windows-static-release
-          cmake --build build
-          cmake --install build
-
-      - name: Build qBittorrent
-        run: |
-          lupdate -extensions c,cpp,h,hpp,ui .
-          cmake `
-            -B build `
-            -G "Ninja" `
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo `
-            -DCMAKE_EXPORT_COMPILE_COMMANDS=ON `
-            -DCMAKE_TOOLCHAIN_FILE="${{ env.RUNVCPKG_VCPKG_ROOT }}/scripts/buildsystems/vcpkg.cmake" `
-            -DBOOST_ROOT="${{ env.boost_path }}" `
-            -DLibtorrentRasterbar_DIR="${{ env.libtorrent_path }}/lib/cmake/LibtorrentRasterbar" `
-            -DMSVC_RUNTIME_DYNAMIC=OFF `
-            -DVCPKG_TARGET_TRIPLET=x64-windows-static-release `
-            -DVERBOSE_CONFIGURE=ON `
-            --graphviz=build/target_graph.dot
-          cmake --build build
-
-      - name: Prepare build artifacts
-        run: |
-          mkdir upload
-          copy build/qbittorrent.exe upload
-          copy build/qbittorrent.pdb upload
-          copy dist/windows/qt.conf upload
-          # runtimes
-          copy "${{ env.Qt5_DIR }}/bin/Qt5Core.dll" upload
-          copy "${{ env.Qt5_DIR }}/bin/Qt5Gui.dll" upload
-          copy "${{ env.Qt5_DIR }}/bin/Qt5Network.dll" upload
-          copy "${{ env.Qt5_DIR }}/bin/Qt5Sql.dll" upload
-          copy "${{ env.Qt5_DIR }}/bin/Qt5Svg.dll" upload
-          copy "${{ env.Qt5_DIR }}/bin/Qt5Widgets.dll" upload
-          copy "${{ env.Qt5_DIR }}/bin/Qt5WinExtras.dll" upload
-          copy "${{ env.Qt5_DIR }}/bin/Qt5Xml.dll" upload
-          mkdir upload/plugins/iconengines
-          copy "${{ env.Qt5_DIR }}/plugins/iconengines/qsvgicon.dll" upload/plugins/iconengines
-          mkdir upload/plugins/imageformats
-          copy "${{ env.Qt5_DIR }}/plugins/imageformats/qico.dll" upload/plugins/imageformats
-          copy "${{ env.Qt5_DIR }}/plugins/imageformats/qsvg.dll" upload/plugins/imageformats
-          mkdir upload/plugins/platforms
-          copy "${{ env.Qt5_DIR }}/plugins/platforms/qwindows.dll" upload/plugins/platforms
-          mkdir upload/plugins/sqldrivers
-          copy "${{ env.Qt5_DIR }}/plugins/sqldrivers/qsqlite.dll" upload/plugins/sqldrivers
-          mkdir upload/plugins/styles
-          copy "${{ env.Qt5_DIR }}/plugins/styles/qwindowsvistastyle.dll" upload/plugins/styles
-          # cmake additionals
-          mkdir upload/cmake
-          copy build/compile_commands.json upload/cmake
-          copy build/target_graph.dot upload/cmake
-          mkdir upload/cmake/libtorrent
-          copy libtorrent/build/compile_commands.json upload/cmake/libtorrent
-
-      - name: Upload build artifacts
-        uses: actions/upload-artifact@v2
-        with:
-          name: qBittorrent-CI_Windows-x64_libtorrent-${{ matrix.libt_version }}
-          path: upload

.github/workflows/coverity-scan.yml

@@ -1,74 +0,0 @@
-name: Coverity Scan
-
-on:
-  schedule:
-    - cron: '0 0 1 * *' # Monthly (1st day of month at midnight)
-  workflow_dispatch: # Mainly for testing. Don't forget the Coverity usage limits.
-
-jobs:
-  coverity_scan:
-    name: Scan
-    runs-on: ubuntu-20.04
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Install dependencies
-        run: |
-          sudo apt update
-          sudo apt install \
-            build-essential cmake ninja-build pkg-config \
-            libboost-dev libssl-dev zlib1g-dev
-
-      - name: Install Qt
-        uses: jurplel/install-qt-action@v2
-        with:
-          version: "5.15.2"
-
-      - name: Install libtorrent
-        run: |
-          git clone \
-            --branch "v2.0.5" \
-            --depth 1 \
-            --recurse-submodules \
-            https://github.com/arvidn/libtorrent.git
-          cd libtorrent
-          cmake \
-            -B build \
-            -G "Ninja" \
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-            -Ddeprecated-functions=OFF
-          cmake --build build
-          sudo cmake --install build
-
-      - name: Download Coverity Build Tool
-        run: |
-          wget \
-            -q \
-            https://scan.coverity.com/download/linux64 \
-            --post-data "token=${{ secrets.COVERITY_SCAN_TOKEN }}&project=qbittorrent%2FqBittorrent" \
-            -O coverity_tool.tgz
-          mkdir coverity_tool
-          tar xzf coverity_tool.tgz --strip 1 -C coverity_tool
-
-      - name: Build qBittorrent
-        run: |
-          cmake \
-            -B build \
-            -G "Ninja" \
-            -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-            -DGUI=ON \
-            -DVERBOSE_CONFIGURE=ON
-          export PATH="$(pwd)/coverity_tool/bin:$PATH"
-          cov-build --dir cov-int cmake --build build
-
-      - name: Submit the result to Coverity Scan
-        run: |
-          tar caf qbittorrent.xz cov-int
-          curl \
-            --form token="${{ secrets.COVERITY_SCAN_TOKEN }}" \
-            --form email=sledgehammer999@qbittorrent.org \
-            --form file=@qbittorrent.xz \
-            --form version="$(git rev-parse --short HEAD)" \
-            --form description="master" \
-            https://scan.coverity.com/builds?project=qbittorrent%2FqBittorrent

.github/workflows/stale_bot.yaml

@@ -1,22 +0,0 @@
-name: Stale bot
-
-on:
-  schedule:
-    - cron: '0 0 * * *'
-
-jobs:
-  stale:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Mark and close stale PRs
-        uses: actions/stale@v4
-        with:
-          stale-pr-message: "This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity."
-          close-pr-message: "This PR was closed because it has been stalled for some time with no activity."
-          days-before-stale: -1 # avoid marking issues
-          days-before-pr-stale: 60
-          days-before-close: -1 # avoid closing issues
-          days-before-pr-close: 7
-          exempt-all-pr-assignees: true  # avoid stale for all PR with assignees
-          exempt-all-pr-milestones: true # avoid stale for all PR with milestones
-          operations-per-run: 200

.gitignore

@@ -4,7 +4,6 @@ src/qbittorrent
 src/qbittorrent-nox
 src/release
 src/debug
-src/base/version.h
 CMakeLists.txt.user*
 qbittorrent.pro.user*
 conf.pri

.pre-commit-config.yaml

@@ -1,55 +0,0 @@
-repos:
-  - repo: local
-    hooks:
-      - id: check-translation-tag
-        name: Check newline characters in <translation> tag
-        entry: .github/workflows/check_translation_tag.py
-        language: script
-        types_or:
-          - ts
-
-  - repo: https://github.com/pre-commit/pre-commit-hooks.git
-    rev: v4.0.1
-    hooks:
-    - id: check-json
-      name: Check JSON files
-
-    - id: check-yaml
-      name: Check YAML files
-
-    - id: fix-byte-order-marker
-      name: Check file encoding (UTF-8 without BOM)
-      exclude: |
-        (?x)^(
-          src/base/unicodestrings.h
-        )$
-
-    - id: mixed-line-ending
-      name: Check line ending character (LF)
-      args: ["--fix=lf"]
-      exclude: |
-        (?x)^(
-          compile_commands.json |
-          src/webui/www/private/scripts/lib/.*
-        )$
-
-    - id: end-of-file-fixer
-      name: Check trailing newlines
-      exclude: |
-        (?x)^(
-          compile_commands.json |
-          configure |
-          src/webui/www/private/scripts/lib/.*
-        )$
-      exclude_types:
-        - svg
-        - ts
-
-    - id: trailing-whitespace
-      name: Check trailing whitespaces
-      exclude: |
-        (?x)^(
-          src/webui/www/private/scripts/lib/.*
-        )$
-      exclude_types:
-        - ts

.travis.yml

@@ -0,0 +1,177 @@
+language: cpp
+
+os:
+  - linux
+  - osx
+
+dist: bionic
+
+env:
+  matrix:
+    - libt_branch=RC_1_2 gui=true build_system=qmake
+    - libt_branch=RC_1_2 gui=false build_system=qmake
+    - libt_branch=RC_1_2 gui=true build_system=cmake
+    - libt_branch=RC_1_2 gui=false build_system=cmake
+  global:
+    - secure: "OI9CUjj4lTb0HwwIZU5PbECU3hLlAL6KC8KsbwohG8/O3j5fLcnmDsK4Ad9us5cC39sS11Jcd1kDP2qRcCuST/glVNhLkcjKkiQerOfd5nQ/qL4JYfz/1mfP5mdpz9jHKzpLUIG+TXkbSTjP6VVmsb5KPT+3pKEdRFZB+Pu9+J8="
+    - coverity_branch: coverity_scan
+
+matrix:
+  allow_failures:
+    - env: libt_branch=RC_1_2 gui=true build_system=cmake
+    - env: libt_branch=RC_1_2 gui=false build_system=cmake
+
+branches:
+  except:
+    - search_encoding_windows
+    - v2_9_x
+
+notifications:
+  email:
+    on_success: change
+    on_failure: change
+
+cache:
+  ccache: true
+  directories:
+    - $HOME/travis/deb
+    - $HOME/travis/brew
+
+addons:
+  coverity_scan:
+    project:
+      name: "qbittorrent/qBittorrent"
+      description: "Build submitted via Travis CI"
+    build_command_prepend: "./bootstrap.sh && ./configure $qmake_conf"
+    build_command: "make -j2"
+    branch_pattern: $coverity_branch
+    notification_email: sledgehammer999@qbittorrent.org
+  apt:
+    sources:
+      # sources list: https://github.com/travis-ci/apt-source-safelist/blob/master/ubuntu.json
+      - sourceline: 'ppa:qbittorrent-team/qbt-libtorrent-travisci'
+      - sourceline: 'deb https://apt.kitware.com/ubuntu/ bionic main'
+        key_url: 'https://apt.kitware.com/keys/kitware-archive-latest.asc'
+    packages:
+      # packages list: https://github.com/travis-ci/apt-package-safelist/blob/master/ubuntu-trusty
+      - [autoconf, automake, cmake, colormake]
+      - [libboost-dev, libboost-system-dev]
+      - libssl-dev
+      - [qtbase5-dev, libqt5svg5-dev, qttools5-dev]
+      - zlib1g-dev
+
+before_install:
+  # only allow specific build for coverity scan, others will stop
+  - if [ "$TRAVIS_BRANCH" = "$coverity_branch" ] && ! [ "$TRAVIS_OS_NAME" = "linux" -a "$libt_branch" = "RC_1_2" -a "$gui" = "true" -a "$build_system" = "qmake" ]; then exit ; fi
+
+  - shopt -s expand_aliases
+  - alias make="colormake -j2" # Using nprocs/2 sometimes may fail (gcc is killed by system)
+  - qbt_path="$HOME/qbt_install"
+  - qmake_conf="$qmake_conf --prefix=$qbt_path"
+  - cmake_conf="$cmake_conf -DCMAKE_INSTALL_PREFIX=$qbt_path"
+
+  # options for specific branches
+  - |
+    if [ "$TRAVIS_OS_NAME" = "linux" ]; then
+      # setup virtual display for after_success target
+      if [ "$gui" = "true" ]; then export "DISPLAY=:99.0" && /sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen 0 1280x1024x16 ; fi ;
+      # CMake from Kitware is installed in /usr/bin
+      # TravisCI installs its own cmake to another location which ovverides other installations
+      # if they don't call the new binary directly
+      alias cmake="/usr/bin/cmake"
+    fi
+  - |
+    if [ "$TRAVIS_OS_NAME" = "osx" ]; then
+      CXXFLAGS="$CXXFLAGS -Wno-unused-local-typedefs"
+
+      openssl_root_path="/usr/local/opt/openssl"
+      qmake_conf="$qmake_conf PKG_CONFIG_PATH=$openssl_root_path/lib/pkgconfig:$PKG_CONFIG_PATH"
+      cmake_conf="$cmake_conf -DOPENSSL_ROOT_DIR=$openssl_root_path"
+    fi
+  - |
+    if [ "$gui" = "false" ]; then
+      qmake_conf="$qmake_conf --disable-gui"
+      cmake_conf="$cmake_conf -DGUI=OFF"
+    fi
+
+  # print settings
+  - echo $libt_branch
+  - echo $gui
+  - echo $build_system
+  - echo $qmake_conf
+  - echo $cmake_conf
+
+install:
+  - |
+    if [ "$TRAVIS_OS_NAME" = "osx" ]; then
+      # dependencies
+      PATH="/usr/local/opt/ccache/libexec:$PATH"
+
+      brew update > /dev/null
+      brew upgrade cmake
+      brew install ccache colormake boost openssl qt zlib
+      brew link --force qt zlib
+
+      if [ "$build_system" = "cmake" ]; then
+        sudo ln -s /usr/local/opt/qt/mkspecs /usr/local/mkspecs
+        sudo ln -s /usr/local/opt/qt/plugins /usr/local/plugins
+      fi
+    fi
+  - |
+    if [ "$TRAVIS_BRANCH" != "$coverity_branch" ]; then
+      export use_ccache=true
+      ccache -M 512M
+      ccache -V && ccache --show-stats && ccache --zero-stats
+    fi
+  - |
+    if [ "$libt_branch" = "RC_1_2" ] && [ "$TRAVIS_OS_NAME" = "linux" ]; then
+      # Will install latest 1.2.x daily build from the PPA
+      sudo apt-get -y install libtorrent-rasterbar-dev
+    fi
+  - |
+    if [ "$libt_branch" = "RC_1_2" ] && [ "$TRAVIS_OS_NAME" = "osx" ]; then
+      # building libtorrent manually should be faster than using the official bottle
+      # because the bottle will also pull in a lot of updated dependencies and prolong the overall time
+      pushd "$HOME"
+      git clone --single-branch --branch RC_1_2 https://github.com/arvidn/libtorrent.git
+      cd libtorrent
+      git checkout tags/v1.2.10
+
+      cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=14 -Ddeprecated-functions=OFF -DOPENSSL_ROOT_DIR="$openssl_root_path" ./
+      make
+      sudo make install
+      popd
+    fi
+
+script:
+  - if [ "$TRAVIS_BRANCH" = "$coverity_branch" ]; then exit ; fi # skip usual build when running coverity scan
+  - |
+    cd "$TRAVIS_BUILD_DIR"
+    if [ "$build_system" = "qmake" ]; then
+      # scan only as lupdate is prone to hang
+      lupdate -extensions c,cpp,h,hpp,ui ./
+      ./bootstrap.sh
+      ./configure $qmake_conf CXXFLAGS="$CXXFLAGS"
+    else
+      mkdir build && cd build
+      cmake $cmake_conf ../
+    fi
+  - make
+  - make install
+
+after_success:
+  - if [ "$gui" = "true" ]; then qbt_exe="qbittorrent" ; else qbt_exe="qbittorrent-nox" ; fi
+  - if [ "$TRAVIS_OS_NAME" = "linux" ]; then cd "$qbt_path/bin" ; fi
+  - |
+    if [ "$TRAVIS_OS_NAME" = "osx" ]; then
+      if [ "$build_system" = "qmake" ]; then
+        macdeployqt "$TRAVIS_BUILD_DIR/src/$qbt_exe.app"
+        cd "$TRAVIS_BUILD_DIR/src/$qbt_exe.app/Contents/MacOS"
+      else
+        cd "$qbt_path/$qbt_exe.app/Contents/MacOS"
+      fi
+    fi
+  - ./$qbt_exe --version
+
+after_script:
+  - if [ "$use_ccache" = true ]; then ccache --show-stats ; fi

AUTHORS

@@ -17,23 +17,19 @@ Contributors:
 * Nick Tiskov <daymansmail@gmail.com>
 
 Code from other projects:
-* files src/app/qtlocalpeer/*
+* files src/qtsingleapplication/* src/lineedit/*
   copyright: Nokia Corporation
-  license: mixed
+  license: LGPL
 
-* files src/gui/lineedit.*
+* files src/ico.cpp src/ico.h
-  copyright: Trolltech ASA <info@trolltech.com>
+  copyright: Malte Starostik <malte@kde.org>
-  license: custom
+  license: LGPL
 
 * files src/search_engine/socks.py
   copyright: Dan Haim <negativeiq@users.sourceforge.net>
   license: BSD
 
-* file src/app/stacktrace.h
+* file src/stacktrace_win.h
-  copyright: Timo Bingmann from http://idlebox.net/
-  license: WTFPL v2.0
-
-* file src/app/stacktrace_win.h
   copyright: Quassel Project
   license: GPLv2/3
 
@@ -91,7 +87,7 @@ Images Authors:
 
 * file: src/icons/oxygen/checked.png
   copyright: Victor Buinsky <allok.victor@gmail.com>
-
+  
 * file: src/icons/skin/ratio.png
   copyright: Fatcow Web Hosting
   license: Creative Commons Attribution 3.0 License
@@ -123,7 +119,7 @@ Translations authors:
   - German: Niels Hoffmann (zentralmaschine@users.sourceforge.net)
   - Greek: Tsvetan Bankov (emerge_life@users.sourceforge.net), Stephanos Antaris (santaris@csd.auth.gr), sledgehammer999(hammered999@gmail.com) and Γιάννης Ανθυμίδης Evropi(Transifex)
   - Hebrew: David Deutsch (d.deffo@gmail.com)
-  - Hungarian: Majoros Péter
+  - Hungarian: Majoros Péter (majoros.j.p@t-online.hu)
   - Italian: bovirus (bovirus@live.it) and Matteo Sechi (bu17714@gmail.com)
   - Japanese: Masato Hashimoto (cabezon.hashimoto@gmail.com)
   - Korean: Jin Woo Sin (jin828sin@users.sourceforge.net)

CMakeLists.txt

@@ -3,6 +3,7 @@ cmake_minimum_required(VERSION 3.16 FATAL_ERROR) # Policies <= CMP0097 default t
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules)
 
 project(qBittorrent
+    VERSION 4.3.0.1
     DESCRIPTION "The qBittorrent BitTorrent client"
     HOMEPAGE_URL "https://www.qbittorrent.org/"
     LANGUAGES CXX
@@ -10,20 +11,16 @@ project(qBittorrent
 
 # use CONFIG mode first in find_package
 set(CMAKE_FIND_PACKAGE_PREFER_CONFIG ON)
-# version requirements - older versions may work, but you are on your own
+# version requirements
-set(minBoostVersion 1.65)
+set(requiredBoostVersion 1.40)
-set(minQt5Version 5.15.2)
+set(requiredQtVersion 5.9.0)
-set(minQt6Version 6.2)
+set(requiredOpenSSLVersion 1.0)
-set(minOpenSSLVersion 1.1.1)
+set(requiredLibtorrentVersion 1.2.0)
-set(minLibtorrent1Version 1.2.14)
+set(requiredZlibVersion 1.2.5.2)
-set(minLibtorrentVersion 2.0.4)
-set(minZlibVersion 1.2.11)
 
 # features (some are platform-specific)
-include(CheckCXXSourceCompiles) # TODO: migrate to CheckSourceCompiles in CMake >= 3.19
 include(FeatureSummary)
 include(FeatureOptionsSetup)
-feature_option(QT6 "Use Qt6" OFF)
 feature_option(STACKTRACE "Enable stacktraces" ON)
 feature_option(GUI "Build GUI application" ON)
 feature_option(WEBUI "Enables built-in HTTP server for headless use" ON)
@@ -37,22 +34,12 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
         "Install systemd service file to a directory manually overridable with Systemd_SERVICES_INSTALL_DIR"
         OFF "NOT GUI" OFF
     )
-    if (STACKTRACE)
-        check_cxx_source_compiles(
-            "#include <execinfo.h>
-            int main(){return 0;}"
-            QBITTORRENT_HAS_EXECINFO_H
-        )
-        if (NOT QBITTORRENT_HAS_EXECINFO_H)
-            message(FATAL_ERROR "execinfo.h header file not found.\n"
-                "Please either disable the STACKTRACE feature or use a libc that has this header file, such as glibc (GNU libc)."
-            )
-        endif()
-    endif()
 elseif (MSVC)
     feature_option(MSVC_RUNTIME_DYNAMIC "Use MSVC dynamic runtime library (-MD) instead of static (-MT)" ON)
 endif()
 
+set(QBT_VER_STATUS "alpha1" CACHE STRING "Project status version. Should be empty for release builds.")
+
 include(GNUInstallDirs)
 add_subdirectory(src)
 add_subdirectory(dist)
@@ -62,6 +49,3 @@ if (VERBOSE_CONFIGURE)
 else()
     feature_summary(WHAT ENABLED_FEATURES DISABLED_FEATURES)
 endif()
-
-# Generate version header
-configure_file("src/base/version.h.in" "${CMAKE_CURRENT_SOURCE_DIR}/src/base/version.h" @ONLY)

CODING_GUIDELINES.md

@@ -1,14 +1,12 @@
-# Coding Guidelines
+All new code **must** follow the following coding guidelines.  
-
+If you make changes in a file that still uses another coding style, make sure that you follow these guidelines for your changes.  
-All new code **must** follow the following coding guidelines. \
-If you make changes in a file that still uses another coding style, make sure that you follow these guidelines for your changes. \
 For programming languages other than C++ (e.g. JavaScript) used in this repository and submodules, unless otherwise specified, coding guidelines listed here applies as much as possible.
 
-**Note 1:** I will not take your head if you forget and use another style. However, most probably the request will be delayed until you fix your coding style. \
+**Note 1:** I will not take your head if you forget and use another style. However, most probably the request will be delayed until you fix your coding style.  
-**Note 2:** You can use the `uncrustify` program/tool to clean up any source file. Use it with the `uncrustify.cfg` configuration file found in the root folder. \
+**Note 2:** You can use the `uncrustify` program/tool to clean up any source file. Use it with the `uncrustify.cfg` configuration file found in the root folder.  
-**Note 3:** There is also a style for QtCreator but it doesn't cover all cases. In QtCreator `Tools->Options...->C++->Code Style->Import...` and choose the `codingStyleQtCreator.xml` file found in the root folder.
+**Note 3:** There is also a style for QtCreator but it doesn't cover all cases. In QtCreator `Tools->Options...->C++->Code Style->Import...` and choose the `codingStyleQtCreator.xml` file found in the root folder.  
 
-## Table Of Contents
+### Table Of Contents
 
 * [1. New lines & curly braces](#1-new-lines--curly-braces)
   * [a. Function blocks, class/struct definitions, namespaces](#a-function-blocks-classstruct-definitions-namespaces)
@@ -31,13 +29,11 @@ For programming languages other than C++ (e.g. JavaScript) used in this reposito
 * [9. Misc](#9-misc)
 * [10. Git commit message](#10-git-commit-message)
 * [11. Not covered above](#11-not-covered-above)
-
 ---
 
-## 1. New lines & curly braces
+### 1. New lines & curly braces ###
-
-### a. Function blocks, class/struct definitions, namespaces
 
+#### a. Function blocks, class/struct definitions, namespaces ####
 ```c++
 int myFunction(int a)
 {
@@ -47,7 +43,7 @@ int myFunction(int a)
 void myFunction() {} // empty body
 
 MyClass::MyClass(int *parent)
-    : m_parent {parent}
+    : m_parent(parent)
 {
     // initialize
 }
@@ -83,21 +79,17 @@ namespace Name
 }
 ```
 
-### b. Other code blocks
+#### b. Other code blocks ####
-
 ```c++
-if (condition)
+if (condition) {
-{
     // code
 }
 
-for (int a = 0; a < b; ++b)
+for (int a = 0; a < b; ++b) {
-{
     // code
 }
 
-switch (a)
+switch (a) {
-{
 case 1:
     // blah
 case 2:
@@ -105,25 +97,17 @@ case 2:
 default:
     // blah
 }
-
-{
-    // code
-}
 ```
 
-### c. Blocks in switch's case labels
+#### c. Blocks in switch's case labels ####
-
 ```c++
-switch (var)
+switch (var) {
-{
+case 1: {
-case 1:
-    {
         // declare local variables
         // code
     }
     break;
-case 2:
+case 2: {
-    {
         // declare local variables
         // code
     }
@@ -133,29 +117,22 @@ default:
 }
 ```
 
-### d. If-else statements
+#### d. If-else statements ####
-
 The `else if`/`else` must be on their own lines:
-
 ```c++
-if (condition)
+if (condition) {
-{
     // code
 }
-else if (condition)
+else if (condition) {
-{
     // code
 }
-else
+else {
-{
     // code
 }
 ```
 
-### e. Single statement if blocks
+#### e. Single statement if blocks ####
-
 Most single statement if blocks should look like this:
-
 ```c++
 if (condition)
     a = a + b;
@@ -164,23 +141,19 @@ if (condition)
 One acceptable exception to this can be `return`, `break` or `continue` statements,
 provided that the test condition isn't very long and its body statement occupies only one line.
 However you can still choose to use the first rule.
-
 ```c++
 if (a > 0) return;
 
-while (p)
+while (p) {
-{
     // ...
     if (!b) continue;
 }
 ```
 
-### f. Acceptable conditions to omit braces
+#### f. Acceptable conditions to omit braces ####
-
 When the conditional statement in `if`/`else` has only one line and its body occupy only one line,
-this also applies to loops statements. \
+this also applies to loops statements.  
 Notice that for a series of `if - else` branches, if one branch needs braces then all branches must add braces.
-
 ```c++
 if (a < b)  // conditional statement
     do(a);  // body
@@ -192,27 +165,21 @@ else if (a > b)
 else
     do(c);
 
-if (a < b)
+if (a < b) {
-{
     do(a);
 }
-else if (a > b)
+else if (a > b) {  // curly braces required here, then all branches should also add them
-{
-    // curly braces required here, then all branches should also add them
     do(b);
     do(d);
 }
-else
+else {
-{
     do(c);
 }
 ```
 
-### g. Brace enclosed initializers
+#### g. Brace enclosed initializers ####
-
+Unlike single-line functions, you must not insert spaces between the brackets and concluded expressions.<br/>
-Unlike single-line functions, you must not insert spaces between the brackets and concluded expressions. \
 But you must insert a space between the variable name and initializer.
-
 ```c++
 Class obj {}; // empty
 Class obj {expr};
@@ -220,33 +187,28 @@ Class obj {expr1, /*...,*/ exprN};
 QVariantMap map {{"key1", 5}, {"key2", 10}};
 ```
 
-## 2. Indentation
+### 2. Indentation ###
-
 4 spaces.
 
-## 3. File encoding and line endings
+### 3. File encoding and line endings ###
 
 UTF-8 and Unix-like line ending (LF). Unless some platform specific files need other encodings/line endings.
 
-## 4. Initialization lists
+### 4. Initialization lists ###
-
 Initialization lists should be vertical. This will allow for more easily readable diffs. The initialization colon should be indented and in its own line along with first argument. The rest of the arguments should be indented too and have the comma prepended.
-
 ```c++
 myClass::myClass(int a, int b, int c, int d)
-    : m_a {a}
+    : m_a(a)
-    , m_b {b}
+    , m_b(b)
-    , m_c {c}
+    , m_c(c)
-    , m_d {d}
+    , m_d(d)
 {
     // code
 }
 ```
 
-## 5. Enums
+### 5. Enums ###
-
 Enums should be vertical. This will allow for more easily readable diffs. The members should be indented.
-
 ```c++
 enum Days
 {
@@ -260,14 +222,11 @@ enum Days
 };
 ```
 
-## 6. Names
+### 6. Names ###
-
 All names should be camelCased.
 
-### a. Type names and namespaces
+#### a. Type names and namespaces ####
-
 Type names and namespaces start with Upper case letter (except POD types).
-
 ```c++
 class ClassName {};
 
@@ -282,18 +241,14 @@ namespace NamespaceName
 }
 ```
 
-### b. Variable names
+#### b. Variable names ####
-
 Variable names start with lower case letter.
-
 ```c++
 int myVar;
 ```
 
-### c. Private member variable names
+#### c. Private member variable names ####
-
 Private member variable names start with lower case letter and should have ```m_``` prefix.
-
 ```c++
 class MyClass
 {
@@ -301,26 +256,23 @@ class MyClass
 }
 ```
 
-## 7. Header inclusion order
+### 7. Header inclusion order ###
-
 The headers should be placed in the following group order:
+  1. Module header (in .cpp)
+  2. C++ Standard Library headers
+  3. System headers
+  4. Boost library headers
+  5. Libtorrent headers
+  6. Qt headers
+  7. qBittorrent's own headers, starting from the *base* headers.
 
-1. Module header (in .cpp)
+The headers should be ordered alphabetically within each group.  
-2. C++ Standard Library headers
+If there are conditionals for the same header group, then put them at the bottom of the respective group.  
-3. System headers
-4. Boost library headers
-5. Libtorrent headers
-6. Qt headers
-7. qBittorrent's own headers, starting from the *base* headers.
-
-The headers should be ordered alphabetically within each group. \
-If there are conditionals for the same header group, then put them at the bottom of the respective group. \
 If there are conditionals that contain headers from several different header groups, then put them above the "qBittorrent's own headers" group.
 
 One exception is the header containing the library version (for example, QtGlobal), this particular header isn't constrained by the aforementioned order.
 
 Example:
-
 ```c++
 // file: examplewidget.cpp
 
@@ -370,10 +322,8 @@ Example:
 #include "ui_examplewidget.h"
 ```
 
-## 8. Include guard
+### 8. Include guard ###
-
+`#pragma once` should be used instead of "include guard" in new code:
-`#pragma once` must be used instead of a "classic include guard":
-
 ```c++
 // examplewidget.h
 
@@ -388,77 +338,75 @@ class ExampleWidget : public QWidget
 
 ```
 
-## 9. Misc
+### 9. Misc ###
 
 * Line breaks for long lines with operation:
 
-  ```c++
+```c++
-  a += "b"
+a += "b"
-    + "c"
+  + "c"
-    + "d";
+  + "d";
-  ```
+```
 
 * **auto** keyword
 
-  We allow the use of the **auto** keyword only where it is strictly necessary (for example, to declare a lambda object, etc.), or where it **enhances** the readability of the code. \
+We allow the use of the **auto** keyword only where it is strictly necessary 
-  Declarations for which one can gather enough information about the object interface (type) from its name or the usage pattern (an iterator or a loop variable are good examples of clear patterns) or the right part of the expression nicely fit here.
+(for example, to declare a lambda object, etc.), or where it **enhances** the readability of the code.
-
+Declarations for which one can gather enough information about the object interface (type) from its name 
-  When weighing whether to use an auto-typed variable please think about potential reviewers of your code, who will read it as a plain diff (on github.com, for instance). \
+or the usage pattern (an iterator or a loop variable are good examples of clear patterns) 
-  Please make sure that such reviewers can understand the code completely and without excessive effort.
+or the right part of the expression nicely fit here.<br/>
-
+<br/>
-  Some valid use cases:
+When weighing whether to use an auto-typed variable please think about potential reviewers of your code, 
-
+who will read it as a plain diff (on github.com, for instance). Please make sure that such reviewers can 
-  * Container iteration and casts:
+understand the code completely and without excessive effort.<br/>
-
+<br/>
-    ```c++
+Some valid use cases:
-    template <typename List>
+```c++
-    void doSomethingWithList(const List &list)
+template <typename List>
-    {
+void doSomethingWithList(const List &list)
-        foreach (const auto &item, list)
+{
-        {
+    foreach (const auto &item, list) {
-            // we don't know item type here so we use 'auto' keyword
+        // we don't know item type here so we use 'auto' keyword
-            // do something with item
+        // do something with item
-        }
     }
+}
 
-    for (auto it = container.begin(), end = container.end(); it != end; ++it)
+for (auto it = container.begin(), end = container.end(); it != end; ++it) {
-    {
+    // we don't need to know the exact iterator type,
-        // we don't need to know the exact iterator type,
+    // because all iterators have the same interface
-        // because all iterators have the same interface
+}
-    }
 
-    auto spinBox = static_cast<QSpinBox*>(sender());
+auto spinBox = static_cast<QSpinBox*>(sender());
-    // we know the variable type based on the right-hand expression
+// we know the variable type based on the right-hand expression
-    ```
+```
 
-  * Notice the spaces in the following specific situations:
+* Notice the spaces in the following specific situations:
+```c++
+// Before and after the assignment and other binary (and ternary) operators there should be a space
+// There should not be a space between increment/decrement and its operand
+a += 20;
+a = (b <= MAX_B ? b : MAX_B);
+++a;
+--b;
 
-    ```c++
+for (int a = 0; a < b; ++b) {
-    // Before and after the assignment and other binary (and ternary) operators there should be a space
+}
-    // There should not be a space between increment/decrement and its operand
+
-    a += 20;
+// Range-based for loop, spaces before and after the colon
-    a = (b <= MAX_B ? b : MAX_B);
+for (auto i : container) {
-    ++a;
+}
-    --b;
+
-    for (int a = 0; a < b; ++b)
+// Derived class, spaces before and after the colon
-    {
+class Derived : public Base
-    }
+{
-    // Range-based for loop, spaces before and after the colon
+};
-    for (auto i : container)
+```
-    {
-    }
-    // Derived class, spaces before and after the colon
-    class Derived : public Base
-    {
-    };
-    ```
 
 * Prefer pre-increment, pre-decrement operators
-
+```c++
-  ```c++
+++i, --j;  // Yes
-  ++i, --j;  // Yes
+i++, j--;  // No
-  i++, j--;  // No
+```
-  ```
 
 * private/public/protected must not be indented
 
@@ -466,8 +414,7 @@ class ExampleWidget : public QWidget
 
 * Method definitions aren't allowed in header files
 
-## 10. Git commit message
+### 10. Git commit message ###
-
 1. Limit the subject line to 50 characters. Subject should contain only the very essence of the changes (you should avoid extra details and internals)
 2. Separate subject from body with a blank line
 3. Capitalize the subject line
@@ -477,7 +424,6 @@ class ExampleWidget : public QWidget
 7. Use the body to explain what and why vs. how
 8. If commit fixes a reported issue, mention it in the message body (e.g. `Closes #4134.`)
 
-## 11. Not covered above
+### 11. Not covered above ###
-
+If something isn't covered above, just follow the same style the file you are editing has.  
-If something isn't covered above, just follow the same style the file you are editing has. \
 *This guide is not exhaustive and the style for a particular piece of code not specified here will be determined by project members on code review.*

CONTRIBUTING.md

@@ -6,14 +6,22 @@ Read the respective section to find out more.
 ### Table Of Contents
 
 *   **[Bug reporting etiquette](#bug-reporting-etiquette)**
+
+
 *   **[Submitting an issue/bug report](#submitting-an-issuebug-report)**
     *   [What is an actual bug report?](#what-is-an-actual-bug-report)
     *   [Before submitting a bug report](#before-submitting-a-bug-report)
     *   [Steps to ensure a good bug report](#steps-to-ensure-a-good-bug-report)
+
+
 *   **[Suggesting enhancements/feature requests](#suggesting-enhancementsfeature-requests)**
     *   [Before submitting an enhancement/feature request](#before-submitting-an-enhancementfeature-request)
     *   [Steps to ensure a good enhancement/feature suggestion](#steps-to-ensure-a-good-enhancementfeature-suggestion)
+
+
 *   **[Opening a pull request](#opening-a-pull-request)**
+    *   [Must read](#must-read)
+    *   [Good to know](#good-to-know)
 
 # Bug reporting etiquette
 
@@ -186,26 +194,28 @@ Following these guidelines helps maintainers and the community understand your s
 
 # Opening a pull request
 
-*   Consult [coding guidelines][coding-guidelines-url] first. If you are working on translation/i18n, read ["How to translate qBittorrent"][how-to-translate-url].
+### Must read
-*   Keep your git commit history clean.
+*   Read our [**coding guidelines**][coding-guidelines-url]. There are some scripts to help you: [uncrustify script][uncrustify-script-url], [astyle script][astyle-script-url], [(related thread)][coding-guidelines-thread-url].
-    * Refer to the section about ["Git commit messages"][coding-guidelines-git-commit-message-url] in the coding guidelines.
+*   Keep the title **short** and provide a **clear** description about what your pull request does.
-    * When merge conflicts arise, do `git rebase <target_branch_name>` and fix the conflicts, don't do `git pull`. Here is a good explanation: [merging-vs-rebasing][merging-vs-rebasing-url].
+*   Provide **screenshots** for UI related changes.
-*   Keep pull request title concise and provide motivation and "what it does" in the pull request description area. Make it easy to read and understand.
+*   Keep your git commit history **clean** and **precise.** Refer to the section about "Git commit messages" in the [**coding guidelines**][coding-guidelines-url].
-*   Provide screenshots for UI related changes.
+*   If your commit fixes a reported issue (for example #4134), add the following message to the commit `Closes #4134.`. Example [here][commit-message-fix-issue-example-url].
-*   If your commit addresses a reported issue (for example issue #8454), append the following text to the commit body `Closes #8454.`. Example [commit][commit-message-fix-issue-example-url].
-*   Search [pull request list][pull-request-list-url] first. Others might have already implemented your idea (or got rejected already).
 
+### Good to know
+*   **Search** pull request history! Others might have already implemented your idea and it is waiting to be merged (or got rejected already). Save your precious time by doing a search first.
+*   When resolving merge conflicts, do `git rebase <target_branch_name>`, don't do `git pull`. Then you can start fixing the conflicts. Here is a good explanation: [link][merging-vs-rebasing-url].
+
+[astyle-script-url]: https://gist.github.com/Chocobo1/539cee860d1eef0acfa6
 [attachments-howto-url]: https://help.github.com/articles/file-attachments-on-issues-and-pull-requests
-[builds-url]: https://sourceforge.net/projects/qbittorrent/files/
 [coding-guidelines-url]: https://github.com/qbittorrent/qBittorrent/blob/master/CODING_GUIDELINES.md
-[coding-guidelines-git-commit-message-url]: https://github.com/qbittorrent/qBittorrent/blob/master/CODING_GUIDELINES.md#10-git-commit-message
+[coding-guidelines-thread-url]: https://github.com/qbittorrent/qBittorrent/issues/2192
 [commit-message-fix-issue-example-url]: https://github.com/qbittorrent/qBittorrent/commit/c07cd440cd46345297debb47cb260f8688975f50
 [forum-url]: http://forum.qbittorrent.org/
 [howto-report-bugs-url]: https://www.chiark.greenend.org.uk/~sgtatham/bugs.html
-[how-to-translate-url]: https://github.com/qbittorrent/qBittorrent/wiki/How-to-translate-qBittorrent
 [merging-vs-rebasing-url]: https://www.atlassian.com/git/tutorials/merging-vs-rebasing
-[pull-request-list-url]: https://github.com/qbittorrent/qBittorrent/pulls
 [python-url]: https://www.python.org/
 [releases-url]: https://github.com/qbittorrent/qBittorrent/releases
 [search-plugins-url]: https://github.com/qbittorrent/search-plugins
+[uncrustify-script-url]: https://raw.githubusercontent.com/qbittorrent/qBittorrent/master/uncrustify.cfg
 [wiki-url]: https://github.com/qbittorrent/qBittorrent/wiki
+[builds-url]: https://sourceforge.net/projects/qbittorrent/files/

COPYING

@@ -1,6 +1,5 @@
-qBittorrent is licensed under the GNU General Public License either version 2,
+qBittorrent is licensed under the GNU General Public License version 2 with the
-or (at your option) any later version with the addition of the following
+addition of the following special exception:
-special exception:
 
 In addition, as a special exception, the copyright holders give permission to
 link this program with the OpenSSL project's "OpenSSL" library (or with
@@ -11,15 +10,13 @@ modify file(s), you may extend this exception to your version of the file(s),
 but you are not obligated to do so. If you do not wish to do so, delete this
 exception statement from your version.
 
-See also the AUTHORS file
-
 ----------
 
                     GNU GENERAL PUBLIC LICENSE
                        Version 2, June 1991
 
- Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.
- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+                       51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.
 
@@ -32,7 +29,7 @@ software--to make sure the software is free for all its users.  This
 General Public License applies to most of the Free Software
 Foundation's software and to any other program whose authors commit to
 using it.  (Some other Free Software Foundation software is covered by
-the GNU Lesser General Public License instead.)  You can apply it to
+the GNU Library General Public License instead.)  You can apply it to
 your programs, too.
 
   When we speak of free software, we are referring to freedom, not
@@ -295,62 +292,3 @@ PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGES.
 
                      END OF TERMS AND CONDITIONS
-
-            How to Apply These Terms to Your New Programs
-
-  If you develop a new program, and you want it to be of the greatest
-possible use to the public, the best way to achieve this is to make it
-free software which everyone can redistribute and change under these terms.
-
-  To do so, attach the following notices to the program.  It is safest
-to attach them to the start of each source file to most effectively
-convey the exclusion of warranty; and each file should have at least
-the "copyright" line and a pointer to where the full notice is found.
-
-    <one line to give the program's name and a brief idea of what it does.>
-    Copyright (C) <year>  <name of author>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License along
-    with this program; if not, write to the Free Software Foundation, Inc.,
-    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-
-Also add information on how to contact you by electronic and paper mail.
-
-If the program is interactive, make it output a short notice like this
-when it starts in an interactive mode:
-
-    Gnomovision version 69, Copyright (C) year name of author
-    Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
-    This is free software, and you are welcome to redistribute it
-    under certain conditions; type `show c' for details.
-
-The hypothetical commands `show w' and `show c' should show the appropriate
-parts of the General Public License.  Of course, the commands you use may
-be called something other than `show w' and `show c'; they could even be
-mouse-clicks or menu items--whatever suits your program.
-
-You should also get your employer (if you work as a programmer) or your
-school, if any, to sign a "copyright disclaimer" for the program, if
-necessary.  Here is a sample; alter the names:
-
-  Yoyodyne, Inc., hereby disclaims all copyright interest in the program
-  `Gnomovision' (which makes passes at compilers) written by James Hacker.
-
-  <signature of Ty Coon>, 1 April 1989
-  Ty Coon, President of Vice
-
-This General Public License does not permit incorporating your program into
-proprietary programs.  If your program is a subroutine library, you may
-consider it more useful to permit linking proprietary applications with the
-library.  If this is what you want to do, use the GNU Lesser General
-Public License instead of this License.

Changelog

@@ -1,246 +1,5 @@
-Tue Feb 15 2022 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.4.1
-    - FEATURE: Restore all torrent settings to the torrent's main context menu (thalieht)
-    - FEATURE: Add confirmation for enabling Auto TMM from context menu (thalieht)
-    - FEATURE: Add tooltip to Automatic Torrent Management context menu action (thalieht)
-    - FEATURE: Add Select All/None buttons in new torrent dialog (thalieht)
-    - BUGFIX: Keep "torrent info" alive while generate .torrent file (glassez)
-    - BUGFIX: Correctly handle Auto TMM in Torrent Files Watcher (glassez)
-    - BUGFIX: Correctly track the root folder name change (glassez)
-    - BUGFIX: Various fixes to the moving torrent code (glassez)
-    - BUGFIX: Update the torrent's download path field when changing category (thalieht)
-    - BUGFIX: Correctly handle received metadata (glassez)
-    - BUGFIX: Store hybrid torrents using legacy filenames (glassez)
-    - BUGFIX: Open correct directory when clicked on Browse button (glassez)
-    - BUGFIX: Fix crash when shutting down and clicing on system tray icon (Chocobo1)
-    - BUGFIX: Fix "Free space on disk" in new torrent dialog (thalieht)
-    - BUGFIX: Optimize completed files handling (Prince Gupta)
-    - BUGFIX: Migrate proxy settings (sledgehammer999)
-    - BUGFIX: Try to recover missing categories (glassez)
-    - WEBUI: WebAPI: fix wrong key used for categories (Chocobo1)
-    - WEBUI: Remove hack for outdated IE 6 browser (Chocobo1)
-    - RSS: Correctly handle XML parsing errors (glassez)
-
-Thu Jan 06 2022 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.4.0
-    - FEATURE: Support for v2 torrents along with libtorrent 2.0.x support (glassez, Chocobo1)
-    - FEATURE: Support for Qt6 (glassez)
-    - FEATURE: Expose libtorrent hashing_threads settings (Anton Bershanskiy)
-    - FEATURE: Add "Notification timeout" option (kevtechxx)
-    - FEATURE: Add `connection_speed` to advanced settings (Chocobo1)
-    - FEATURE: Announce to all trackers if IP changed (#15001) (zhuangzi926)
-    - FEATURE: Add tooltip for various columns (Chocobo1)
-    - FEATURE: Add context menu to toggle content tab columns (#15164) (AbeniMatteo)
-    - FEATURE: Add filter "Checking" to side panel (#15166) (AbeniMatteo)
-    - FEATURE: Add "Forced metadata downloading" state (#15185) (AbeniMatteo)
-    - FEATURE: Remember last viewed page in Options dialog (#15230) (Chocobo1)
-    - FEATURE: Add tooltip to listening port spinbox (Chocobo1)
-    - FEATURE: Add "Skip hash check" option for watched folders (glassez)
-    - FEATURE: Add "Show torrent options" double-click action (glassez)
-    - FEATURE: Allow setting temp folder per torrent/catergory (glassez)
-    - FEATURE: Support folder based UI Themes (Prince Gupta)
-    - BUGFIX: Save "resume data" once file priority is changed (glassez)
-    - BUGFIX: Show priority menu at top level if there is no other in Add New Torrent dialog (FozzeY)
-    - BUGFIX: Capitalize "peer flags" descriptions (Chocobo1)
-    - BUGFIX: Reorder peer flags (Chocobo1)
-    - BUGFIX: Show "last activity" value under all circumstances (Chocobo1)
-    - BUGFIX: Elide text from the right for all columns' header (smigii)
-    - BUGFIX: Fix startup with different profiles (jagannatharjun)
-    - BUGFIX: Move a few torrent context menu actions into "Torrent options" dialog (thalieht)
-    - BUGFIX: Allow deselecting radio buttons in "Torrent options" for mixed torrents (thalieht)
-    - BUGFIX: Apply file priority changes correctly (a-sum-duma, Chocobo1)
-    - BUGFIX: Use proper string for Korean language (OctopusET)
-    - BUGFIX: Disable "add peers" menu items instead of hiding it (Chocobo1)
-    - BUGFIX: Disable system tray icon menu when app is exiting (Chocobo1)
-    - BUGFIX: Show GUI lock icon after system tray icon is initialized (Chocobo1)
-    - BUGFIX: Apply selected layout to displayed torrent content in "Add New Torrent" dialog (glassez)
-    - WEBUI: Add reverse proxy source IP resolution (#15047) (HiFiPhile)
-    - WEBUI: Support navigating UI tables with arrow keys (Thomas Piccirello)
-    - WEBUI: Support expanding/collapsing UI folders with arrow keys (Thomas Piccirello)
-    - WEBUI: Support sorting UI tables via touch (#15205) (Tom Piccirello)
-    - WEBUI: Add pieces progress bar to General tab (Jesse Smick)
-    - WEBUI: Update authors page (Chocobo1)
-    - WEBUI: Set icon sizes attribute (Daniel Aleksandersen)
-    - WEBUI: Add meta application name (Daniel Aleksandersen)
-    - WEBUI: Sort WebUI language selection values (Chocobo1)
-    - WEBUI: Use correct URL scheme in user prompt when HTTPS is enabled (Chocobo1)
-    - RSS: Stick Unread row to top in RSS feed list (Prince Gupta)
-    - RSS: Correctly use fallback icons for RSS feed in GUI (jagannatharjun)
-    - SEARCH: Add context menu for tabs in search widget (#14926) (Anton)
-    - SEARCH: Add more download options to torrent search result right-click menu (a-sum-duma)
-    - WINDOWS: Add windows-clang support (#15115) (Biswapriyo Nath)
-    - WINDOWS: Update python installer URL for Windows (xavier2k6)
-    - WINDOWS: NSIS: Update Simplified Chinese translation (Losiki)
-    - LINUX: Prolong wait time for shutdown for qbittorrent-nox (Chocobo1)
-    - LINUX: Install vector program icon (Chocobo1)
-    - LINUX: Add detection for OpenBSD, Haiku in configure script (Chocobo1)
-    - MACOS: Update Mac icons for Big Sur (17jiangz1)
-    - EXPERIMENTAL: Setting to store/load fastresume/torrent files in an SQLite database (glassez)
-    - OTHER: Many internal code refactorings and bug fixing by many people
-
-Sun Oct 31 2021 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.9
-    - BUGFIX: Fix "no action" option on torrent double click (Jose M. Abuin)
-    - BUGFIX: Fix broken behavior of "priority by shown file order" (Chocobo1)
-    - WEBUI: Fix WebUI crash when tracker URL is invalid (Chocobo1)
-    - WEBUI: Revert "WebUI: group trackers by hostname" (Chocobo1)
-    - WINDOWS: Remove Windows Vista support from manifest (xavier2k6)
-    - WINDOWS: NSIS: Update Korean, Indonesian and Traditional Chinese translation (JungHee Lee, Faisal Al-Munawar Fathur Rahman, SiderealArt)
-
-Sun Aug 29 2021 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.8
-    - BUGFIX: Delay processing of watched folders (#15282) (glassez)
-    - BUGFIX: Use the same icon for selecting folders/files (Chocobo1)
-    - BUGFIX: Use default upper limits for ddns entries (Chocobo1)
-    - WEBUI: Expose SSRF mitigation (#15247) (Sylvain Finot)
-    - WEBUI: Update webui libraries (Chocobo1)
-    - WEBUI: Group trackers by hostname (#15264) (Mengyang Li)
-    - WEBUI: Improve "last activity" calculation in WebAPI (#15339) (Chocobo1)
-    - WINDOWS: NSIS: Add Polish translation (#15262) (Matthaiks)
-
-Tue Aug 03 2021 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.7
-    - BUGFIX: Don't forget to start Watched folders timer (glassez)
-    - BUGFIX: Don't close tags menu when toggling items (tgregerson)
-    - BUGFIX: Don't overwrite tracker message (glassez)
-    - BUGFIX: Bump file pool size (#14966) (An0n)
-    - BUGFIX: Properly create "clean path" for watched folder (glassez)
-    - WEBUI: Disconnect comment links (Daniel Aleksandersen)
-    - WINDOWS: NSIS: Update Danish translation (scootergrisen)
-
-Sat Jun 26 2021 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.6
-    - FEATURE: New languages: Mongolian, Persian, Thai
-    - BUGFIX: Provide correct error description in "upload mode" (glassez)
-    - BUGFIX: Allow adding torrents with relative save path (glassez)
-    - BUGFIX: Fix main window turns blank after restoring from tray (#15031) (Chocobo1)
-    - BUGFIX: Remove the lockfile on exit (#14997) (brvphoenix)
-    - BUGFIX: Improve "Watched folders" feature (glassez)
-    - BUGFIX: Keep sub-sorting order (#15074) (Dmitry Khlestkov)
-    - BUGFIX: Properly add torrent with new tags (glassez)
-    - WINDOWS: NSIS: Update Japanese, Turkish, Hungarian, Swedish translation (maboroshin, Burak Yavuz, xkrstudio, nonew-star)
-
-Sun May 02 2021 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.5
-    - BUGFIX: Move cursor to the end when autofilling URL/hash in "Download from URLs" dialog (Chocobo1)
-    - BUGFIX: Sort invalid QDateTime values after valid values (Chocobo1)
-    - BUGFIX: Fix tabChangesFocus attribute in "Edit trackers" dialog (Christoph Rackwitz)
-    - BUGFIX: Update DynDNS register url (zhuangzi926)
-    - BUGFIX: Handle "not enough disk space" error more graciously (glassez)
-    - BUGFIX: Correctly draw progress background with stylesheet (jagannatharjun)
-    - WEBUI: Fix magnet url from the search facility (Chocobo1)
-    - WEBUI: Revise folder monitoring functions (Chocobo1)
-    - WEBUI: Fix magnet url from the browser (brvphoenix)
-    - WEBUI: Allow to specify file indexes in torrents/files API (glassez)
-    - WINDOWS: NSIS: Allow more strings to translated (bovirus, Chocobo1)
-    - WINDOWS: NSIS: Update Italian, German, Estonian, Russian, PortugueseBR translations (bovirus, Henry Water, PriitUring, Долматов Алексей, Felipe)
-    - LINUX: Fix D-Bus Notification `desktop-entry` field (Chocobo1)
-    - MACOS: Don't use executable name as CFBundleName value (Nick Korotysh)
-    - OTHER: Lower Qt requirement to 5.11 (sledgehammer999)
-    - OTHER: Clarify that the license is GPLv2+ (sledgehammer999)
-
-Wed Mar 24 2021 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.4.1
-    - BUGFIX: Correctly draw progress bar (glassez)
-    - WEBUI: Fix javascript code which broke the UI (Chocobo1)
-
-Tue Mar 23 2021 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.4
-    - FEATURE: Add ability to prioritize selected items by shown file order (Chocobo1)
-    - FEATURE: Allow tab to escape the text box in "Edit trackers" dialog (Christoph Rackwitz)
-    - FEATURE: Support sub-sorting in Transferlist (jagannatharjun)
-    - FEATURE: Expose ToS setting from libtorrent (Chocobo1)
-    - FEATURE: Improve tracker entries handling (glassez)
-    - BUGFIX: Drop extension from generated content folder name (glassez)
-    - BUGFIX: Change qBittorrent Updater window title (xavier2k6)
-    - BUGFIX: Validate HTTPS Tracker Certificate by default (an0n666)
-    - BUGFIX: Don't let "program update" dialog steal focus (Chocobo1)
-    - BUGFIX: Disable expand on double click in TorrentContentTreeView (jagannatharjun)
-    - BUGFIX: Add hyperlink to Transifex on translator list (Si Yong Kim)
-    - BUGFIX: Enlarge "speed limit" icon slightly (Chocobo1)
-    - BUGFIX: Don't prevent system sleep due to errored torrents (dyumin)
-    - BUGFIX: Use stable sorting in transfer list (Chocobo1)
-    - BUGFIX: Allow "missing files" torrents to save more resume data (glassez)
-    - BUGFIX: Restart "missing files" torrents after changing location (glassez)
-    - BUGFIX: Show proper string when torrent availability is not available (Chocobo1)
-    - BUGFIX: Apply "Hide zero/infinity values" to "Time Active", "Down/Up Limit" and ETA columns (Chocobo1)
-    - BUGFIX: Fix potential out-of-bounds access (Chocobo1)
-    - BUGFIX: Make SpeedPlotView averager time aware (jagannatharjun)
-    - BUGFIX: Add a 3-Hour graph (jagannatharjun)
-    - BUGFIX: Add an option to disable icons in menus (always disabled on MacOS) (Michał Kopeć)
-    - BUGFIX: Improve detection of filename extension of audio/video files (Chocobo1)
-    - BUGFIX: Various drawing improvements of progress bar (Chocobo1)
-    - BUGFIX: Properly stop torrent creation if aborted (Chocobo1)
-    - BUGFIX: Replace external program parameters in one step (Chocobo1)
-    - BUGFIX: Improve "save resume data" handling (glassez)
-    - BUGFIX: Fix bad IPv6 address format for outgoingInterfaces (treysis)
-    - WEBUI: Properly decode strings (brvphoenix)
-    - WEBUI: Accept "share limits" when adding torrent using WebAPI (glassez)
-    - WEBUI: Add seeding time to the active time column (thalieht)
-    - WEBUI: Fix incorrect seeding time string in General tab (thalieht)
-    - WEBUI: Allow >100 days in WebUI function "friendlyDuration" (thalieht)
-    - WEBUI: Avoid decoding strings repeatedly (brvphoenix)
-    - RSS: Add category button on AutomatedRSSDownloader on GUI (Si Yong Kim)
-    - WINDOWS: NSIS: Update Czech translation (slrslr)
-    - WINDOWS: NSIS: Update Portuguese BR translation (Alex)
-    - WINDOWS: NSIS: Add Estonian translation (PriitUring)
-    - WINDOWS: Allow change-case-only file renaming (glassez)
-    - LINUX: Systemd: wait for mounting of local filesystems (Juraj Oršulić)
-    - OTHER: Raise minimum libtorrent version to 1.2.12 (glassez)
-    - OTHER: Raise minimum Qt version to 5.12 (glassez)
-
-Tue Jan 19 2021 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.3
-    - FEATURE: New languages: Azerbaijani, Estonian
-    - BUGFIX: Unify global speed dialogs for normal/alternative speeds (thalieht)
-    - BUGFIX: Increase maximum global speed limits ~2 GiB/s (thalieht)
-    - BUGFIX: Save fastresume when setting torrent speed limits (thalieht)
-    - BUGFIX: Group several torrent options into one dialog (thalieht)
-    - BUGFIX: Capitalize locale names (Chocobo1)
-    - BUGFIX: Improve content file/folder names handling (glassez)
-    - BUGFIX: Drop notification about move storage finished or failed (glassez)
-    - BUGFIX: Reload "missing files" torrent instead of re-checking (glassez)
-    - BUGFIX: Remember dialog sizes (Chocobo1)
-    - BUGFIX: Improve detection of file extension string (Chocobo1)
-    - WEBUI: Don't call non-existent elements (glassez)
-    - WEBUI: Update "Keep top-level folder" in WebUI options (thalieht)
-    - MACOS: QMake: Raise minimal macOS target version to 10.14 (glassez)
-    - LINUX: Use legacy 'data' directory only as a fallback (lbilli)
-    - OTHER: Bump project requirement to C++17 (Chocobo1)
-
-Sun Dec 27 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.2
-    - FEATURE: Allow to add root folder to torrent content (glassez)
-    - FEATURE: "HTTPS tracker validation" option is available on all platforms with latest libtorrent (Chocobo1)
-    - FEATURE: Option for supporting internationalized domain names (IDNs) (Chocobo1)
-    - BUGFIX: Fix broken sorting on some columns (Chocobo1)
-    - BUGFIX: Fix availability per file value (Chocobo1)
-    - BUGFIX: Fix status of torrents without metadata (sledgehammer999)
-    - BUGFIX: Don't try to remove folders for a torrent without metadata (sledgehammer999)
-    - BUGFIX: Lift upper limit of "Max concurrent HTTP announces" option (Chocobo1)
-    - BUGFIX: Add links to libtorrent documentation (Chocobo1)
-    - BUGFIX: Move "embedded tracker" options to qbt section (Chocobo1)
-    - BUGFIX: Properly handle "Append extension" option changing (glassez)
-    - BUGFIX: Correctly save paused torrent state (glassez)
-    - BUGFIX: Fix bug of "move storage job" can be performed multiple times (glassez)
-    - WEBUI: Add ability to use 'shift+delete' to delete torrents (Chocobo1)
-    - WEBUI: Allow to attach tags while adding torrents (Jesse Chan)
-    - WEBUI: Bump version to 2.6.2 (Jesse Chan)
-    - WEBUI: Remove unnecessary restriction on input length (Chocobo1)
-    - WINDOWS: NSIS: Update Russian translation (Andrei Stepanov)
-    - WINDOWS:  NSIS: Update Italian translation (Alessandro Simonelli)
-    - OTHER: Drop support for building with libtorrent < 1.2.11 (Vladimir Golovnev)
-
-Wed Nov 25 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.1
-    - FEATURE: Allow progress bar styling from custom themes (jagannatharjun)
-    - FEATURE: Allow adding torrents using "Paste" key sequence (Chocobo1)
-    - FEATURE: Add Latgalian translation (sledgehammer999)
-    - BUGFIX: Prevent resume data to be saved for removed torrent (glassez)
-    - BUGFIX: Clarify connection protocol choice label (FranciscoPombal)
-    - BUGFIX: Fix crash when clicked outside the table of torrent content view (jagannatharjun)
-    - BUGFIX: Don't resume "paused" torrents when put into "checking" state by libtorrent (glassez)
-    - BUGFIX: Fix torrent state calculation (glassez)
-    - BUGFIX: Align integer data to right in torrent content view (jagannatharjun)
-    - WEBUI: Place WebUI RSS description in sandboxed iframe (Sepro)
-    - WEBUI: Avoid settings being reset via WebAPI (Chocobo1)
-    - WEBUI: Fix toggling advanced option in WebUI (thalieht)
-    - WEBUI: Expose contentPath in WebAPI torrents/info (FranciscoPombal)
-    - WEBUI: Fix the issue that IPv6 address can't be banned (brvphoenix)
-    - RSS: Fix confusion in date format description (Thomas De Rocker)
-    - WINDOWS: Update dutch.nsi (Thomas De Rocker)
-    - LINUX: Update .desktop file translations (sledgehammer999)
-
 Thu Oct 22 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.0.1
-    - WINDOWS: NSIS: Update Italian translation (bovirus)
+    - WINDOWS: NSIS: Update Dutch translation (bovirus)
 
 Sun Oct 18 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.0
     - FEATURE: Many UI elements colors are themeable now (jagannatharjun)
@@ -295,127 +54,6 @@ Sun Oct 18 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.3.0
     - OTHER: Support for libtorrent 1.1.x is dropped (Chocobo1)
     - OTHER: Many code cleanups and improvements (FranciscoPombal, Chocobo1, glassez)
 
-Sat Apr 25 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.5
-    - BUGFIX: Fix crash when torrent is deleted on limit reached (glassez)
-    - BUGFIX: Register datatype properly (Chocobo1)
-    - WEBUI: Add ability to send custom HTTP headers (Chocobo1)
-    - WEBUI: Expand RSS related API (Sepro)
-    - WINDOWS: Installer: Update german translation (schnurlos)
-
-Wed Apr 22 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.4
-    - BUGFIX: Fix sub-sorting of Transfer list (glassez)
-    - BUGFIX: Fix wrong logic that disables "prevent sleeping" timer (Chocobo1)
-    - BUGFIX: Set disk cache size for older libtorrent versions (NotTsunami)
-    - BUGFIX: Sort locale language list (Chocobo1)
-    - BUGFIX: Remove white outline around mascot.png (adem)
-    - BUGFIX: Various fixes in configuring the chosen network interface and not leaking the IP (Raif Atef, an0n666)
-    - BUGFIX: Save "resume data" when torrent storage is moved (glassez)
-    - BUGFIX: Avoid holding encoded resume data in memory (Chocobo1)
-    - BUGFIX: Fix date format for "Last seen complete" (Chocobo1)
-    - BUGFIX: Remove deprecated strict super seeding mode from advanced settings (an0n666)
-    - BUGFIX: Change default stop_tracker_timeout settings (an0n666)
-    - BUGFIX: Convert the Log widget to use custom View/Model (jagannatharjun)
-    - BUGFIX: Change default upload slot choking limits (an0n666)
-    - BUGFIX: Don't uncheck Authentication checkbox when changing proxy type (thalieht)
-    - BUGFIX: Reduce ambiguity for selecting tray icons (Chocobo1)
-    - WEBUI: Fix unable to add multiple peers in WebUI (Sepro)
-    - WEBUI: Fix UPnP lease duration get/set (NotTsunami)
-    - SEARCH: Detect python3 executable on Windows (József Sallai)
-
-Wed Apr 01 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.3
-    - FEATURE: Add logging for SOCKS5 proxy errors (Chocobo1)
-    - FEATURE: Add UPnP lease duration advanced option (NotTsunami)
-    - BUGFIX: Allow to translate error messages (Chocobo1)
-    - BUGFIX: Don't round scaling factor (Nick Korotysh)
-    - BUGFIX: Save log file in UTF-8 encoding (Chocobo1)
-    - BUGFIX: Avoid log file excessive flushing (Chocobo1)
-    - BUGFIX: Fix regression when fastresume contains network path (Tester798)
-    - BUGFIX: Fix broken UNC paths in fastresumes on Windows (sledgehammer999)
-    - BUGFIX: Prevent multiple instances for the same app config (glassez)
-    - BUGFIX: Fix unexpected torrent resume after app restart with libtorrent 1.1.x (glassez)
-    - WEBUI: Add alt and title tags for WebUI footer (LameLemon)
-    - WINDOWS: Installer: Update Finnish translation (Roope Jukkara)
-    - WINDOWS: Installer: Update Japanese translation (maboroshin)
-    - WINDOWS: Installer: Update Turkish translation (Burak Yavuz)
-    - WINDOWS: Installer: Update Russian translation (Andrei Stepanov)
-
-Tue Mar 24 2020 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.2
-    - FEATURE: Allow transfer list text color changes through QSS (Prince Gupta)
-    - FEATURE: Option to show console when external program is run (sledgehammer999)
-    - FEATURE: Rename Country column to "Country / Region" (Thomas Piccirello)
-    - FEATURE: Change the defaults of some settings (FranciscoPombal)
-    - FEATURE: Refactored Transfer List code to allow theming. As a sideffect the row height has more padding. (glassez)
-    - FEATURE: Allow double-click in preview dialog (thalieht)
-    - FEATURE: Expose stop_tracker_timeout in advanced settings (an0n666)
-    - FEATURE: Add piece_extent_affinity to AdvancedSettings (FranciscoPombal)
-    - FEATURE: Reorganize UI theme selection (Prince Gupta)
-    - FEATURE: Show any multiple connections from the same IP in peer list (thalieht)
-    - FEATURE: Add stalled filters to GUI and Web API/UI (FranciscoPombal)
-    - FEATURE: Use IP geolocation database by DB-IP instead of MaxMind (sledgehammer999)
-    - FEATURE: Allow to save downloaded metadata as torrent file (glassez)
-    - FEATURE: Allow single app instance per configuration (glassez)
-    - PERFORMANCE: Move multiple torrents one by one (glassez)
-    - BUGFIX: Disable Torrent Queue by default for new users (an0n666)
-    - BUGFIX: Update free disk space label on Category change in Auto Mode (Medvedishce)
-    - BUGFIX: Save resume data after recheck (glassez)
-    - BUGFIX: Tracker is errored only if all local endpoints fail (sledgehammer999)
-    - BUGFIX: Change placement of stop tracker timeout setting (An0n)
-    - BUGFIX: Redesign torrent startup handling (glassez)
-    - BUGFIX: Show "∞" instead of " -1" in Preferences (Sakib-Abrar)
-    - BUGFIX: Improve code efficiency for reverse resolution of peers (Chocobo1)
-    - BUGFIX: Handle HTTP redirection to magnet URI (glassez)
-    - BUGFIX: Various fixes for portable mode (Tester798)
-    - BUGFIX: Include resume folder path in exception message (Chocobo1)
-    - BUGFIX: Change placeholder text in torrent list's filter (djt3)
-    - BUGFIX: Improvements in the embedded tracker to be more spec compliant (FranciscoPombal)
-    - BUGFIX: Improve the options tooltips (NotTsunami)
-    - BUGFIX: Check if file exists in seed mode (an0n666)
-    - BUGFIX: Delegate GUI scaling work to Qt (Nick Korotysh)
-    - BUGFIX: Fix crash when renaming torrent contents (Chocobo1)
-    - BUGFIX: Fix total connected peers count calculation (FranciscoPombal)
-    - BUGFIX: Allow other keypresses in LogListWidget (NotTsunami)
-    - BUGFIX: Disable Auto TMM when not using default savepath from monitored folder (thalieht)
-    - WEBUI: Fix first row renaming in files tab (Denis)
-    - WEBUI: Use SVG image for WebUI favicon (Nick Korotysh)
-    - WEBUI: Inherit text color for filter list elements (Nick Korotysh)
-    - WEBUI: Expose WebUI ban counter to users (Chocobo1)
-    - WEBUI: Expose WebUI ban duration to users (Chocobo1)
-    - WEBUI: Implement "Secure" flag for session cookie (FranciscoPombal)
-    - WEBUI: Remove unused/deprecated option (FranciscoPombal)
-    - WEBUI: Prevent excessive sync requests (FranciscoPombal)
-    - WEBUI: Fix populating statistics window (FranciscoPombal)
-    - WEBUI: Fix matching uncategorized torrents (FranciscoPombal)
-    - WEBUI: Always allow whitespace in category names (FranciscoPombal)
-    - SEARCH: Bump python version for new installation (Chocobo1)
-    - SEARCH: Fix missing string (Chocobo1)
-    - SEARCH: Drop python2 support (Chocobo1)
-    - WINDOWS: Installer: Option to start qBittorrent on Windows start up (An0n)
-    - WINDOWS: Installer: Improve Czech translation (slrslr)
-    - WINDOWS: Installer: Update French translation (zywo)
-    - WINDOWS: Installer: Update German translation (schnurlos)
-    - WINDOWS: Installer: Update Japanese translation (maboroshin)
-    - WINDOWS: Path length limitation is removed on Windows 10 1607 onwards (an0n666)
-
-Wed Dec 18 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.1
-    - FEATURE: Enable portable mode if "profile" directory exists (Tester798)
-    - FEATURE: Enable "Apply rate limit to peers on LAN" option by default (Chocobo1)
-    - BUGFIX: Sync translations from Transifex and run lupdate (sledgehammer999)
-    - BUGFIX: Don't unnecessarily delete OS files in folders (sledgehammer999)
-    - BUGFIX: Use the incomplete folder where appropriate (sledgehammer999)
-    - BUGFIX: Align Properties tab bar correctly on window resize (Prince Gupta)
-    - BUGFIX: Rework the listening IP/interface selection code (sledgehammer999)
-    - BUGFIX: Fix inconsistent icon for deleting torrent (Chocobo1)
-    - BUGFIX: Show torrent error message in transfer list (Chocobo1)
-    - BUGFIX: Fix stuck in wrong torrent state (Chocobo1)
-    - BUGFIX: Expand single-item folders in torrent content (warren)
-    - WEBUI: Bump Web API version (sledgehammer999)
-    - WEBUI: Add ability to rename torrent files from the WebUI (Thomas Piccirello)
-    - WEBUI: Mention lack of HTTPS in WebUI magnet link warning (nl6720)
-    - WEBUI: Fix HTML elements size in search tab (Chocobo1)
-    - SEARCH: Fix incorrect translation displayed after language change (Chocobo1)
-    - SEARCH: Fix missing translations in search plugins dialog (Chocobo1)
-    - WINDOWS: Update russian translation of the installer (Andrei Stepanov)
-
 Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - FEATURE: Libtorrent 1.2.x series are supported now (glassez)
     - FEATURE: Add OpenSSL version to GUI and stackdump (Chocobo1)
@@ -447,7 +85,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - BUGFIX: Remove the max half-open connections option (thalieht)
     - BUGFIX: Center align the section labels in advanced settings (thalieht)
     - BUGFIX: Add documentation links to some advanced settings (thalieht)
-    - BUGFIX: Improve DownloadManager code (glassez)
+    - BUGFIX: Impove DownloadManager code (glassez)
     - BUGFIX: Limit DownloadHandler max redirection to 20 (Chocobo1)
     - BUGFIX: Log DownloadManager SSL errors (Chocobo1)
     - BUGFIX: Force recheck multiple torrents one by one (glassez)
@@ -678,10 +316,10 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - BUGFIX: Restore torrent in two steps (glassez)
     - BUGFIX: Improve scaling of speed graphs (dzmat)
     - BUGFIX: Add isNetworkFileSystem() detection on Windows. This allows network mounts to be monitored correctly by polling timer. (Chocobo1)
-    - BUGFIX: Reduce horizontal graphs resolution. Improves performance. (dzmat)
+    - BUGFIX: Reduce horizontal graphs resolution. Improves perfomance. (dzmat)
     - BUGFIX: Don't recheck just checked torrent (mj-p, glassez)
     - BUGFIX: Add SMB2 magic number (Chocobo1)
-    - BUGFIX: Restore startup performance to v4.1.2 times. Needs at least libtorrent 1.1.10 (sledgehammer999)
+    - BUGFIX: Restore startup perfomance to v4.1.2 times. Needs at least libtorrent 1.1.10 (sledgehammer999)
     - BUGFIX: Make strings actually translatable (sledgehammer999)
     - WEBUI: Handle downloading .torrent file as success (Tom Piccirello)
     - WEBUI: Fix Alternative Web UI to be available (glassez)
@@ -752,7 +390,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - BUGFIX: Improve torrent initialization (glassez)
     - BUGFIX: Save resume data on torrent change events (glassez)
     - BUGFIX: Increase default resume data save interval (Chocobo1)
-    - BUGFIX: Work around crash when processing recursive download. Closes #9086 (Chocobo1)
+    - BUGFIX: Work around crash when procesing recursive download. Closes #9086 (Chocobo1)
     - BUGFIX: Reduce queries to python version (Chocobo1)
     - BUGFIX: Disable certain mouse wheel events in Options dialog (Chocobo1)
     - WEBUI: Send all rechecks in one request (Thomas Piccirello)
@@ -1239,7 +877,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - COSMETIC: Change RSS view layout to horizontal. Closes #5920. (Chocobo1)
     - OSX: Fix crash on exit using Qt4. (Yez Ezey)
     - OSX: Change QSettings to IniFormat on macOS. Closes #5770 #5808. (Yez Ezey)
-    - LINUX: Workaround a Qt5 bug which results in a flood of network interface change signals. (Eugene Shalygin)
+    - LINUX: Workaround a Qt5 bug which results in a flood of network interface change singals. (Eugene Shalygin)
     - OTHER: Turkish translation for installer. (Burak Yavuz)
     - OTHER: Update portugueseBR for installer. (DaRKSoM)
     - OTHER: Update portuguese for installer. (EdwardLinux)
@@ -1256,7 +894,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - SEARCH: Remove KickassTorrents search engine (ngosang)
     - SEARCH: Remove BTDigg search engine (ngosang)
     - SEARCH: Update Torrentz search engine (ngosang)
-
+    
 * Wed Jul 20 2016 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v3.3.6
     - BUGFIX: Do not create save folder in advance (glassez)
     - BUGFIX: Fix upper-bound limit of command line for "Run External Program" in Windows. Closes #5399. (Chocobo1)
@@ -1569,7 +1207,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
 * Sun Aug 02 2015 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v3.2.3
     - BUGFIX: Fix crash when closing a search tab while search is running (pmzqla)
     - SEARCH: Other minor search fixes and improvements (pmzqla)
-
+    
 * Sat Aug 01 2015 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v3.2.2
     - FEATURE: Allow to force reannounce DHT too (Chocobo1)
     - FEATURE: Implement an option to disable confirmation of torrent recheck (blaxspirit)
@@ -1946,7 +1584,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - BUGFIX: Correctly update tracker tier number in the trackers tab. Closes #1075. (sledgehammer999)
     - BUGFIX: Speed improvements.(sledgehammer999)
     - OTHER: Updated translations.
-
+    
 * Tue Nov 05 2013 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v3.1.2
     - BUGFIX: Fix WebUI gzip compression. Closes #1037. (sledgehammer999)
     - BUGFIX: Fix compilation with qt < 4.8.0. Closes #1043. (sledgehammer999)
@@ -1998,7 +1636,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - BUGFIX: Enable edit/rename via F2 or double click in various places(Gelmir)
     - BUGFIX: Allow to edit trackers and copy their urls(Gelmir and Driim)
     - BUGFIX: Add Uploaded column to main view(Gelmir)
-    - BUGFIX: Calculate ETA for seeding torrents(Gelmir)
+    - BUGFIX: Calculate ETA for seeding torrents(Gelmir)    
     - BUGFIX: Add option to ignore global share ratio limits for created torrents(Gelmir)
     - OTHER: Many RSS bugfixes and improvements all over the place(Gelmir)
     - OTHER: Generate translations at configure time to reduce tarball size
@@ -2020,7 +1658,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - BUGFIX: Use system language as default language. Closes #780 (sledgehammer999)
     - BUGFIX: Move completed files to .unwanted folder when they are unselected by the user (constantined)
     - BUGFIX: Show delete action when multiple feeds are selected (Gelmir)
-    - BUGFIX: Use Unicode for libtorrent alert messages (Gelmir)
+    - BUGFIX: Use Unicode for libtorrent alert messages (Gelmir)    
     - OTHER: Update translations
     - WINDOWS: Shave off ~4MB from the binary size (sledgehammer999)
     - WINDOWS: Remove wrong dependency on msvc2008 runtime (sledgehammer999)
@@ -2048,7 +1686,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - LIBTORRENT: Cache can now be returned to the OS (0.16.10)
     - PERFORMANCE: Improve drawing speed of tranferlist when there are many torrents(>100) (sledgehammer999)
     - PERFORMANCE: Improve drawing speed of peers list when there are many peers (sledgehammer999)
-
+    
 * Sat Mar 16 2013 - Christophe Dumez <chris@qbittorrent.org> - v3.0.9
     - BUGFIX: Raise qBittorrent windows when another instance is launched
     - BUGFIX: Show human readable names for network interfaces in preferences (Windows)
@@ -2255,7 +1893,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - BUGFIX: Cleaner program exit on system log out
     - BUGFIX: Fix possible magnet link parsing problems
     - BUGFIX: Fix possible RSS URL parsing problems
-    - COSMETIC: Added monochrome icon for light themes
+    - COSMETIC: Added monochrome icon for light themes 
 
 * Sun Mar 20 2011 - Christophe Dumez <chris@qbittorrent.org> - v2.7.0
     - FEATURE: Added search field for torrent content
@@ -2586,7 +2224,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - FEATURE: Added "Unread" item to RSS feed list to display all unread news
     - FEATURE: If a torrent contains a torrent file, process downloaded torrent file too
     - FEATURE: A random listening port can be chosen automatically
-    - BUGFIX: torrent resume code rewritten
+    - BUGFIX: torrent resume code rewrited
     - BUGFIX: Fixed uTorrent spoofing code
     - BUGFIX: Greatly improved column sorting code
     - BUGFIX: Possibility to create trackerless torrents
@@ -2708,7 +2346,7 @@ Tue Dec 03 2019 - sledgehammer999 <sledgehammer999@qbittorrent.org> - v4.2.0
     - BUGFIX: Removed "disconnected" connection state, detection was far from perfect
     - BUGFIX: Torrents are no longer starting from scratch when changing default save path (when torrent addition dialog is disabled)
     - BUGFIX: Single instance code is now more reliable on Qt >= 4.4
-    - COSMETIC: Transfer speed, ratio, connection status and DHT nodes are displayed in status bar
+    - COSMETIC: Transfer speed, ratio, connection status and DHT nodes are displayed in status bar    
     - COSMETIC: RSS Tab is now hidden as a default
     - COSMETIC: Allow to hide or display top toolbar
     - COSMETIC: Log is now in a separate dialog

INSTALL

@@ -3,28 +3,22 @@ qBittorrent - A BitTorrent client in C++ / Qt
 
 1) Install these dependencies:
 
-  - Boost >= 1.65
+  - Boost >= 1.40
 
-  - libtorrent-rasterbar 1.2.14 - 1.2.x || 2.0.4 - 2.0.x
+  - libtorrent-rasterbar >= 1.2 (by Arvid Norberg)
-      * By Arvid Norberg, https://www.libtorrent.org/
+      * https://www.libtorrent.org/
       * Be careful: another library (the one used by rTorrent) uses a similar name
 
-  - OpenSSL >= 1.1.1
+  - OpenSSL >= 1.0
 
-  - Qt 5.15.2 - 5.x || 6.2.0 - 6.x
+  - Qt >= 5.9.0
 
-  - zlib >= 1.2.11
+  - zlib >= 1.2.5.2
 
-  - pkg-config *
+  - pkg-config (compile-time only)
-      * Compile-time only on *nix systems
 
-  - Python >= 3.5.0
+  - Python >= 3.5.0 (optional, runtime only)
-      * Optional, run-time only
+      * Required by the internal search engine
-      * Used by the bundled search engine
-
-Dependency version numbers are bumped every once in a while to keep the range of properly tested configurations manageable, even if not strictly required to build.
-You may be able to build with older versions of (some of) the dependencies other than the minimum versions specified in the build scripts, but support for such builds is not provided - you are on your own.
-Please ensure you are building with an officially supported configuration when reporting bugs.
 
 2a) Compile and install qBittorrent with Qt graphical interface
 

README.md

@@ -1,6 +1,7 @@
 qBittorrent - A BitTorrent client in Qt
 ------------------------------------------
 
+[![TravisCI Status](https://travis-ci.org/qbittorrent/qBittorrent.svg?branch=master)](https://travis-ci.org/qbittorrent/qBittorrent)
 [![AppVeyor Status](https://ci.appveyor.com/api/projects/status/github/qbittorrent/qBittorrent?branch=master&svg=true)](https://ci.appveyor.com/project/qbittorrent/qBittorrent)
 [![GitHub Actions CI Status](https://github.com/qbittorrent/qBittorrent/workflows/GitHub%20Actions%20CI/badge.svg)](https://github.com/qbittorrent/qBittorrent/actions)
 [![Coverity Status](https://scan.coverity.com/projects/5494/badge.svg)](https://scan.coverity.com/projects/5494)
@@ -45,8 +46,8 @@ http://forum.qbittorrent.org
 Please report any bug (or feature request) to:
 http://bugs.qbittorrent.org
 
-Official IRC channel:
+You can also meet me (sledgehammer_999) on IRC:
-[#qbittorrent on irc.libera.chat](ircs://irc.libera.chat:6697/qbittorrent)
+`#qbittorrent on irc.freenode.net`
 
 ------------------------------------------
-sledgehammer999 \<sledgehammer999@qbittorrent.org\>
+sledgehammer999 <sledgehammer999@qbittorrent.org>

TODO

@@ -1 +1,2 @@
 See https://blueprints.launchpad.net/qbittorrent/
+

build_dist.sh

@@ -1,19 +0,0 @@
-#!/bin/sh
-
-# get version numbers
-versionSrc="src/base/version.h.in"
-versionMajor="$(grep -Po '(?<=QBT_VERSION_MAJOR )\d+' "$versionSrc")"
-versionMinor="$(grep -Po '(?<=QBT_VERSION_MINOR )\d+' "$versionSrc")"
-versionBugfix="$(grep -Po '(?<=QBT_VERSION_BUGFIX )\d+' "$versionSrc")"
-versionBuild="$(grep -Po '(?<=QBT_VERSION_BUILD )\d+' "$versionSrc")"
-versionStatus="$(grep -Po '(?<=QBT_VERSION_STATUS ")\w+' "$versionSrc")"
-
-if [ "$versionBuild" != "0" ]; then
-    projectVersion="$versionMajor.$versionMinor.$versionBugfix.$versionBuild$versionStatus"
-else
-    projectVersion="$versionMajor.$versionMinor.$versionBugfix$versionStatus"
-fi
-
-# pack archives
-git archive --format=tar --prefix="qbittorrent-$projectVersion/" HEAD | gzip -9 > "qbittorrent-$projectVersion.tar.gz"
-git archive --format=tar --prefix="qbittorrent-$projectVersion/" HEAD | xz -9 > "qbittorrent-$projectVersion.tar.xz"

cmake/Modules/MacroQbtCommonConfig.cmake

@@ -7,17 +7,48 @@ macro(qbt_common_config)
     # treat value specified by the CXX_STANDARD target property as a requirement by default
     set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
+    # these definitions are only needed for calls to
+    # lt::generate_fingerprint and for the qbittorrent.rc file on Windows
+    add_library(qbt_version_definitions INTERFACE)
+
+    target_compile_definitions(qbt_version_definitions INTERFACE
+        QBT_VERSION_MAJOR=${qBittorrent_VERSION_MAJOR}
+        QBT_VERSION_MINOR=${qBittorrent_VERSION_MINOR}
+        QBT_VERSION_BUGFIX=${qBittorrent_VERSION_PATCH}
+        QBT_VERSION_BUILD=${qBittorrent_VERSION_TWEAK}
+    )
+
     add_library(qbt_common_cfg INTERFACE)
 
-    # Full C++ 17 support is required
+    # Full C++ 14 support is required
     # See also https://cmake.org/cmake/help/latest/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html
     # for a breakdown of the features that CMake recognizes for each C++ standard
     target_compile_features(qbt_common_cfg INTERFACE
-        cxx_std_17
+        cxx_std_14
+        cxx_aggregate_default_initializers
+        cxx_attribute_deprecated
+        cxx_binary_literals
+        cxx_contextual_conversions
+        cxx_decltype_auto
+        cxx_digit_separators
+        cxx_generic_lambdas
+        cxx_lambda_init_captures
+        cxx_relaxed_constexpr
+        cxx_return_type_deduction
+        cxx_variable_templates
     )
 
+    set(QBT_PROJECT_VERSION "${qBittorrent_VERSION_MAJOR}.${qBittorrent_VERSION_MINOR}.${qBittorrent_VERSION_PATCH}")
+    if (NOT ${qBittorrent_VERSION_TWEAK} EQUAL 0)
+        set(QBT_PROJECT_VERSION "${QBT_PROJECT_VERSION}.${qBittorrent_VERSION_TWEAK}")
+    endif()
+
+    set(QBT_FULL_VERSION "${QBT_PROJECT_VERSION}${QBT_VER_STATUS}")
+
     target_compile_definitions(qbt_common_cfg INTERFACE
-        QT_DISABLE_DEPRECATED_BEFORE=0x050f02
+        QBT_VERSION="v${QBT_FULL_VERSION}"
+        QBT_VERSION_2="${QBT_FULL_VERSION}"
+        QT_DEPRECATED_WARNINGS
         QT_NO_CAST_TO_ASCII
         QT_NO_CAST_FROM_BYTEARRAY
         QT_USE_QSTRINGBUILDER
@@ -25,12 +56,6 @@ macro(qbt_common_config)
         $<$<NOT:$<CONFIG:Debug>>:QT_NO_DEBUG_OUTPUT>
     )
 
-    if (CMAKE_SYSTEM_NAME STREQUAL "Darwin")
-        target_compile_definitions(qbt_common_cfg INTERFACE
-            _DARWIN_FEATURE_64_BIT_INODE
-        )
-    endif()
-
     if (CMAKE_SYSTEM_NAME STREQUAL "Windows")
         target_compile_definitions(qbt_common_cfg INTERFACE
             NTDDI_VERSION=0x06010000
@@ -43,7 +68,7 @@ macro(qbt_common_config)
         )
     endif()
 
-    if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU") OR (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") OR (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"))
+    if ((CXX_COMPILER_ID STREQUAL "GNU") OR (CXX_COMPILER_ID STREQUAL "Clang") OR (CXX_COMPILER_ID STREQUAL "AppleClang"))
         target_compile_options(qbt_common_cfg INTERFACE
             -Wall
             -Wextra
@@ -65,12 +90,6 @@ macro(qbt_common_config)
         endif()
     endif()
 
-    if ((CMAKE_CXX_COMPILER_ID STREQUAL "Clang") OR (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"))
-        target_compile_options(qbt_common_cfg INTERFACE
-            -Wno-range-loop-analysis
-        )
-    endif()
-
     if (MINGW)
         target_link_options(qbt_common_cfg INTERFACE $<$<OR:$<CONFIG:Debug>,$<CONFIG:RelWithDebInfo>>:LINKER:--dynamicbase>)
     endif()
@@ -82,21 +101,12 @@ macro(qbt_common_config)
     endif()
 
     if (MSVC)
-        target_compile_options(qbt_common_cfg INTERFACE
+        target_compile_options(qbt_common_cfg INTERFACE /guard:cf)
-            /guard:cf
+        target_link_options(qbt_common_cfg INTERFACE /guard:cf
-            /utf-8
-            # https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/
-            /Zc:__cplusplus
-        )
-        target_link_options(qbt_common_cfg INTERFACE
-            /guard:cf
             $<$<NOT:$<CONFIG:Debug>>:/OPT:REF /OPT:ICF>
             # suppress linking warning due to /INCREMENTAL and /OPT:ICF being both ON
             $<$<CONFIG:RelWithDebInfo>:/INCREMENTAL:NO>
         )
     endif()
 
-    if (LibtorrentRasterbar_VERSION VERSION_GREATER_EQUAL ${minLibtorrentVersion})
-        target_compile_definitions(qbt_common_cfg INTERFACE QBT_USES_LIBTORRENT2)
-    endif()
 endmacro(qbt_common_config)

conf.pri.windows

@@ -45,9 +45,6 @@ DEFINES += BOOST_SYSTEM_STATIC_LINK
 # Enable if linking dynamically against libtorrent
 #DEFINES += TORRENT_LINKING_SHARED
 
-# Enable this if compiling with libtorrent 2.x
-#DEFINES += QBT_USES_LIBTORRENT2
-
 # Enable stack trace support
 CONFIG += stacktrace
 

configure.ac

@@ -1,8 +1,6 @@
-AC_INIT([qbittorrent], [v4.4.1], [bugs.qbittorrent.org], [], [https://www.qbittorrent.org/])
+AC_INIT([qbittorrent], [v4.3.0.1], [bugs.qbittorrent.org], [], [https://www.qbittorrent.org/])
 AC_CONFIG_AUX_DIR([build-aux])
 AC_CONFIG_MACRO_DIR([m4])
-: ${CFLAGS=""}
-: ${CXXFLAGS=""}
 AC_PROG_CC
 AC_PROG_CXX
 AC_PROG_SED
@@ -53,32 +51,17 @@ AC_ARG_ENABLE(qt-dbus,
               [enable_qt_dbus=yes])
 
 # Detect OS
-AC_MSG_CHECKING([whether to enable specific tweaks for current host "$host_os"])
+AC_MSG_CHECKING([whether OS is FreeBSD])
-case "$host_os" in
+AS_IF([expr "$host_os" : ".*freebsd.*" > /dev/null],
-    *darwin*)
+      [AC_MSG_RESULT([yes])
-        AC_MSG_RESULT([yes])
+      LIBS="-lexecinfo $LIBS"],
-        enable_qt_dbus=no
+      [AC_MSG_RESULT([no])])
-        ;;
 
-    *freebsd*)
+AC_MSG_CHECKING([whether OS is macOS])
-        AC_MSG_RESULT([yes])
+AS_IF([expr "$host_os" : ".*darwin.*" > /dev/null],
-        LIBS="-lexecinfo $LIBS"
+      [AC_MSG_RESULT([yes])
-        ;;
+      enable_qt_dbus=no],
-
+      [AC_MSG_RESULT([no])])
-    *haiku*)
-        AC_MSG_RESULT([yes])
-        LIBS="-lnetwork $LIBS"
-        ;;
-
-    *openbsd*)
-        AC_MSG_RESULT([yes])
-        LIBS="-lexecinfo $LIBS"
-        ;;
-
-    *)
-        AC_MSG_RESULT([no])
-        ;;
-esac
 
 # Require 0.23 pkg-config
 PKG_PROG_PKG_CONFIG([0.23])
@@ -156,7 +139,7 @@ AS_IF([test "x$QT_QMAKE" = "x"],
       [AC_MSG_ERROR([Could not find qmake])
       ])
 AS_IF([test "x$enable_gui" = "xyes"],
-      [PKG_CHECK_MODULES(Qt5Svg, [Qt5Svg >= 5.15.2])
+      [PKG_CHECK_MODULES(Qt5Svg, [Qt5Svg >= 5.5.1])
       ])
 AC_MSG_CHECKING([whether QtDBus should be enabled])
 AS_CASE(["x$enable_qt_dbus"],
@@ -174,7 +157,7 @@ AS_CASE(["x$enable_qt_dbus"],
         AC_MSG_ERROR([Unknown option "$enable_qt_dbus". Use either "yes" or "no".])])
 
 
-AX_BOOST_BASE([1.65],
+AX_BOOST_BASE([1.40],
               [AC_MSG_NOTICE([Boost CXXFLAGS: "$BOOST_CPPFLAGS"])
                AC_MSG_NOTICE([Boost LDFLAGS: "$BOOST_LDFLAGS"])],
               [AC_MSG_ERROR([Could not find Boost])])
@@ -190,51 +173,53 @@ m4_define([DETECT_BOOST_VERSION_PROGRAM],
 AC_COMPILE_IFELSE([DETECT_BOOST_VERSION_PROGRAM(106000)], [],
     [QBT_ADD_DEFINES="$QBT_ADD_DEFINES BOOST_NO_CXX11_RVALUE_REFERENCES"])
 
+AX_BOOST_SYSTEM()
+AC_MSG_NOTICE([Boost.System LIB: "$BOOST_SYSTEM_LIB"])
+LIBS="$BOOST_SYSTEM_LIB $LIBS"
+
 PKG_CHECK_MODULES(libtorrent,
-                  [libtorrent-rasterbar >= 2.0.4],
+                  [libtorrent-rasterbar >= 1.2],
-                  [CXXFLAGS="$libtorrent_CFLAGS $CXXFLAGS" LIBS="$libtorrent_LIBS $LIBS" QBT_ADD_DEFINES="$QBT_ADD_DEFINES QBT_USES_LIBTORRENT2"],
+                  [CXXFLAGS="$libtorrent_CFLAGS $CXXFLAGS"
-                  [PKG_CHECK_MODULES(libtorrent,
+                  LIBS="$libtorrent_LIBS $LIBS"])
-                                     [libtorrent-rasterbar >= 1.2.14 libtorrent-rasterbar < 2],
-                                     [CXXFLAGS="$libtorrent_CFLAGS $CXXFLAGS" LIBS="$libtorrent_LIBS $LIBS"])])
 
 PKG_CHECK_MODULES(openssl,
-                  [openssl >= 1.1.1],
+                  [openssl >= 1.0],
                   [CXXFLAGS="$openssl_CFLAGS $CXXFLAGS"
                   LIBS="$openssl_LIBS $LIBS"])
 
 PKG_CHECK_MODULES(zlib,
-                 [zlib >= 1.2.11],
+                 [zlib >= 1.2.5.2],
                  [CXXFLAGS="$zlib_CFLAGS $CXXFLAGS"
                  LIBS="$zlib_LIBS $LIBS"])
 
-# Check if already in >= C++17 mode because of the flags returned by one of the above packages
+# Check if already in >= C++14 mode because of the flags returned by one of the above packages
 TMP_CXXFLAGS="$CXXFLAGS"
 CXXFLAGS=""
-AC_MSG_CHECKING([if compiler defaults to C++17 or later mode])
+AC_MSG_CHECKING([if compiler defaults to C++14 or later mode])
-AC_COMPILE_IFELSE([DETECT_CPP17_PROGRAM()],
+AC_COMPILE_IFELSE([DETECT_CPP14_PROGRAM()],
                   [AC_MSG_RESULT([yes])
-                   QBT_CXX17_FOUND="yes"],
+                   QBT_CXX14_FOUND="yes"],
                   [AC_MSG_RESULT([no])
-                   QBT_CXX17_FOUND="no"])
+                   QBT_CXX14_FOUND="no"])
 
-# In case of no, check if the compiler can support at least C++17
+# In case of no, check if the compiler can support at least C++14
 # and if yes, enable it leaving a warning to the user
-AS_IF([test "x$QBT_CXX17_FOUND" = "xno"],
+AS_IF([test "x$QBT_CXX14_FOUND" = "xno"],
-      [AC_MSG_CHECKING([if compiler supports C++17])
+      [AC_MSG_CHECKING([if compiler supports C++14])
-       CXXFLAGS="-std=c++17"
+       CXXFLAGS="-std=c++14"
-       AC_COMPILE_IFELSE([DETECT_CPP17_PROGRAM()],
+       AC_COMPILE_IFELSE([DETECT_CPP14_PROGRAM()],
                         [AC_MSG_RESULT([yes])
-                         AC_MSG_CHECKING([if C++17 is disabled by the set compiler flags])
+                         AC_MSG_CHECKING([if C++14 is disabled by the set compiler flags])
                          # prepend the flag so it won't override conflicting user defined flags
-                         CXXFLAGS="-std=c++17 $TMP_CXXFLAGS"
+                         CXXFLAGS="-std=c++14 $TMP_CXXFLAGS"
-                         AC_COMPILE_IFELSE([DETECT_CPP17_PROGRAM()],
+                         AC_COMPILE_IFELSE([DETECT_CPP14_PROGRAM()],
                                            [AC_MSG_RESULT([no])
-                                            QBT_ADD_CONFIG="$QBT_ADD_CONFIG c++17"
+                                            QBT_ADD_CONFIG="$QBT_ADD_CONFIG c++14"
-                                            AC_MSG_WARN([C++17 mode is now force enabled. The C++ mode should match the mode that other libraries were built with, otherwise you'll likely get linking errors.])],
+                                            AC_MSG_WARN([C++14 mode is now force enabled. The C++ mode should match the mode that other libraries were built with, otherwise you'll likely get linking errors.])],
                                            [AC_MSG_RESULT([yes])
-                                            AC_MSG_ERROR([The compiler supports C++17 but the user or a dependency has explicitly enabled a lower mode.])])],
+                                            AC_MSG_ERROR([The compiler supports C++14 but the user or a dependency has explicitly enabled a lower mode.])])],
                         [AC_MSG_RESULT([no])
-                         AC_MSG_ERROR([A compiler supporting C++17 is required.])])
+                         AC_MSG_ERROR([A compiler supporting C++14 is required.])])
       ])
 CXXFLAGS="$TMP_CXXFLAGS"
 
@@ -285,13 +270,9 @@ AC_SUBST(QBT_REMOVE_CONFIG)
 AC_SUBST(QBT_ADD_DEFINES)
 AC_SUBST(QBT_REMOVE_DEFINES)
 
-QBT_CONFIG_FILES="conf.pri"
+AC_OUTPUT(conf.pri)
-
 AS_IF([test "x$enable_systemd" = "xyes"],
-      [QBT_CONFIG_FILES="$QBT_CONFIG_FILES dist/unix/systemd/qbittorrent-nox@.service"])
+      [AC_OUTPUT(dist/unix/systemd/qbittorrent-nox@.service)])
-
-AC_CONFIG_FILES(["$QBT_CONFIG_FILES"])
-AC_OUTPUT
 
 AC_MSG_NOTICE([Running qmake to generate the makefile...])
 TOPDIR="$(cd "$(dirname "$0")" && pwd)"

dist/mac/CMakeLists.txt

@@ -1 +0,0 @@
-# empty

dist/mac/Info.plist

@@ -47,7 +47,7 @@
 		</dict>
 	</array>
 	<key>CFBundleName</key>
-	<string>qBittorrent</string>
+	<string>@EXECUTABLE@</string>
 	<key>CFBundleIconFile</key>
 	<string>qbittorrent_mac.icns</string>
 	<key>CFBundleInfoDictionaryVersion</key>
@@ -55,9 +55,9 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>4.4.1</string>
+	<string>4.3.0</string>
 	<key>CFBundleExecutable</key>
-	<string>${EXECUTABLE_NAME}</string>
+	<string>@EXECUTABLE@</string>
 	<key>CFBundleIdentifier</key>
 	<string>org.qbittorrent.qBittorrent</string>
 	<key>LSMinimumSystemVersion</key>
@@ -67,7 +67,7 @@
 	<key>NSAppleScriptEnabled</key>
 	<string>YES</string>
 	<key>NSHumanReadableCopyright</key>
-	<string>Copyright © 2006-2022 The qBittorrent project</string>
+	<string>Copyright © 2006-2020 The qBittorrent project</string>
 	<key>UTExportedTypeDeclarations</key>
 	<array>
 		<dict>

dist/unix/CMakeLists.txt

@@ -30,6 +30,12 @@ install(FILES ${MAN_FILES}
 )
 
 if (GUI)
+    install(DIRECTORY menuicons/
+        DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor
+        COMPONENT data
+        FILES_MATCHING PATTERN "*.png"
+    )
+
     install(FILES org.qbittorrent.qBittorrent.desktop
         DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/applications/
         COMPONENT data
@@ -40,11 +46,6 @@ if (GUI)
         COMPONENT data
     )
 
-    install(DIRECTORY menuicons/
-        DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor
-        COMPONENT data
-    )
-
     install(FILES
         ${PROJECT_SOURCE_DIR}/src/icons/qbittorrent-tray.svg
         ${PROJECT_SOURCE_DIR}/src/icons/qbittorrent-tray-dark.svg

dist/unix/menuicons/scalable/apps/qbittorrent.svg

@@ -1,16 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="1024" height="1024" viewBox="0 0 1024 1024">
-  <title>
-    qbittorrent-new-light
-  </title>
-  <defs>
-    <linearGradient x1="34.012%" y1="0%" x2="76.373%" y2="76.805%" id="a">
-      <stop stop-color="#72B4F5" offset="0%"/>
-      <stop stop-color="#356EBF" offset="100%"/>
-    </linearGradient>
-  </defs>
-  <g fill="none" fill-rule="evenodd">
-    <circle stroke="#DAEFFF" stroke-width="32" fill="url(#a)" cx="512" cy="512" r="496"/>
-    <path d="M712.898 332.399q66.657 0 103.38 45.671 37.03 45.364 37.03 128.684t-37.34 129.61q-37.03 45.98-103.07 45.98-33.02 0-60.484-12.035-27.156-12.344-45.672-37.649h-3.703l-10.8 43.512h-36.724V196h51.227v116.65q0 39.191-2.469 70.359h2.47q35.796-50.61 106.155-50.61zm-7.406 42.894q-52.46 0-75.605 30.242-23.145 29.934-23.145 101.219t23.762 102.145q23.761 30.55 76.222 30.55 47.215 0 70.36-34.254 23.144-34.562 23.144-99.058 0-66.04-23.144-98.442-23.145-32.402-71.594-32.402z" fill="#fff"/>
-    <path d="M317.273 639.45q51.227 0 74.68-27.466 23.453-27.464 24.996-92.578v-11.418q0-70.976-24.07-102.144-24.07-31.168-76.223-31.168-45.055 0-69.125 35.18-23.762 34.87-23.762 98.75 0 63.879 23.454 97.515 23.761 33.328 70.05 33.328zm-7.715 42.894q-65.421 0-102.144-45.98-36.723-45.981-36.723-128.376 0-83.011 37.032-129.609 37.03-46.598 103.07-46.598 69.433 0 106.773 52.461h2.778l7.406-46.289h40.426V828h-51.227V683.27q0-30.86 3.395-52.461h-4.012q-35.488 51.535-106.774 51.535z" fill="#c8e8ff"/>
-  </g>
-</svg>

dist/unix/org.qbittorrent.qBittorrent.appdata.xml

@@ -74,6 +74,6 @@
   <url type="translate">https://github.com/qbittorrent/qBittorrent/wiki/How-to-translate-qBittorrent</url>
   <content_rating type="oars-1.1"/>
   <releases>
-    <release version="4.4.1" date="2022-02-15"/>
+    <release version="4.3.0.1" date="2020-10-22"/>
   </releases>
 </component>

dist/unix/org.qbittorrent.qBittorrent.desktop

@@ -13,44 +13,41 @@ StartupWMClass=qbittorrent
 Keywords=bittorrent;torrent;magnet;download;p2p;
 
 # Translations
-
+Comment[oc]=Telecargar e partejar de fichièrs amb BitTorrent
-
+GenericName[oc]=Client BitTorrent
-# Translations
+Name[oc]=qBittorrent
 Comment[af]=Aflaai en deel lêers oor BitTorrent
 GenericName[af]=BitTorrent kliënt
 Name[af]=qBittorrent
 Comment[ar]=نزّل وشارك الملفات عبر كيوبت‎تورنت
 GenericName[ar]=عميل بت‎تورنت
-Name[ar]=qBittorrent
+Name[ar]=كيوبت‎تورنت
-Comment[be]=Спампоўванне і раздача файлаў праз пратакол BitTorrent
+Comment[be]=Сцягванне і раздача файлаў праз пратакол BitTorrent
-GenericName[be]=Кліент BitTorrent
+GenericName[be]=BitTorrent-кліент
 Name[be]=qBittorrent
 Comment[bg]=Сваляне и споделяне на файлове чрез BitTorrent
 GenericName[bg]=BitTorrent клиент
 Name[bg]=qBittorrent
 Comment[bn]=বিটটরেন্টে  ফাইল ডাউনলোড এবং শেয়ার করুন
 GenericName[bn]=বিটটরেন্ট ক্লায়েন্ট
-Name[bn]=qBittorrent
+Name[bn]=কিউবি্টটরেন্ট
-Comment[zh]=通过 BitTorrent 下载和分享文件
-GenericName[zh]=BitTorrent 客户端
-Name[zh]=qBittorrent
 Comment[bs]=Preuzmi i dijeli datoteke preko BitTorrent-a
 GenericName[bs]=BitTorrent klijent
 Name[bs]=qBittorrent
-Comment[ca]=Baixeu i compartiu fitxers amb el BitTorrent
+Comment[ca]=Baixeu i compartiu fitxers mitjançant BitTorrent
 GenericName[ca]=Client de BitTorrent
 Name[ca]=qBittorrent
 Comment[cs]=Stahování a sdílení souborů přes síť BitTorrent
 GenericName[cs]=BitTorrent klient
 Name[cs]=qBittorrent
 Comment[da]=Download og del filer over BitTorrent
-GenericName[da]=BitTorrent-klient
+GenericName[da]=BitTorrent klient
 Name[da]=qBittorrent
 Comment[de]=Über BitTorrent Dateien herunterladen und teilen
 GenericName[de]=BitTorrent Client
 Name[de]=qBittorrent
-Comment[el]=Κάντε λήψη και μοιραστείτε αρχεία μέσω BitTorrent
+Comment[el]=Κάντε λήψη και ανταλάξτε αρχεία μέσω BitTorrent
-GenericName[el]=BitTorrent client
+GenericName[el]=Πελάτης BitTorrent
 Name[el]=qBittorrent
 Comment[en_GB]=Download and share files over BitTorrent
 GenericName[en_GB]=BitTorrent client
@@ -58,19 +55,16 @@ Name[en_GB]=qBittorrent
 Comment[es]=Descargue y comparta archivos por BitTorrent
 GenericName[es]=Cliente BitTorrent
 Name[es]=qBittorrent
-Comment[et]=Lae alla ja jaga faile üle BitTorrenti
+Comment[eu]=Jeitsi eta elkarbanatu agiriak BitTorrent-en
-GenericName[et]=BitTorrent klient
-Name[et]=qBittorrent
-Comment[eu]=Jeitsi eta elkarbanatu agiriak BitTorrent bidez
 GenericName[eu]=BitTorrent bezeroa
 Name[eu]=qBittorrent
 Comment[fa]=دانلود و به اشتراک گذاری فایل های بوسیله  بیت تورنت
 GenericName[fa]=بیت تورنت نسخه کلاینت
-Name[fa]=qBittorrent
+Name[fa]=کیو بیت تورنت
 Comment[fi]=Lataa ja jaa tiedostoja BitTorrentia käyttäen
 GenericName[fi]=BitTorrent-asiakasohjelma
 Name[fi]=qBittorrent
-Comment[fr]=Télécharger et partager des fichiers sur BitTorrent
+Comment[fr]=Télécharger et partager des fichiers avec BitTorrent
 GenericName[fr]=Client BitTorrent
 Name[fr]=qBittorrent
 Comment[gl]=Descargar e compartir ficheiros co protocolo BitTorrent
@@ -78,7 +72,7 @@ GenericName[gl]=Cliente BitTorrent
 Name[gl]=qBittorrent
 Comment[gu]=બિટ્ટોરેંટ પર ફાઈલો ડાઉનલોડ અને શેર કરો
 GenericName[gu]=બિટ્ટોરેંટ ક્લાયન્ટ
-Name[gu]=qBittorrent
+Name[gu]=ક્યૂ-બિટ્ટોરેંટ
 Comment[he]=הורד ושתף קבצים על גבי ביטורנט
 GenericName[he]=לקוח ביטורנט
 Name[he]=qBittorrent
@@ -88,16 +82,13 @@ Name[hr]=qBittorrent
 Comment[hu]=Fájlok letöltése és megosztása a BitTorrent hálózaton keresztül
 GenericName[hu]=BitTorrent kliens
 Name[hu]=qBittorrent
-Comment[hy]=Նիշքերի փոխանցում BitTorrent-ի միջոցով
-GenericName[hy]=BitTorrent սպասառու
-Name[hy]=qBittorrent
 Comment[id]=Unduh dan berbagi berkas melalui BitTorrent
 GenericName[id]=Klien BitTorrent
 Name[id]=qBittorrent
 Comment[is]=Sækja og deila skrám yfir BitTorrent
 GenericName[is]=BitTorrent biðlarar
 Name[is]=qBittorrent
-Comment[it]=Scarica e condividi file tramite BitTorrent
+Comment[it]=Client BitTorrent per il download di file via internet
 GenericName[it]=Client BitTorrent
 Name[it]=qBittorrent
 Comment[ja]=BitTorrent でファイルをダウンロードおよび共有します
@@ -106,23 +97,23 @@ Name[ja]=qBittorrent
 Comment[ka]=ჩამოტვირთე და გააზიარე ფაილები Bittorrent-ის საშუალებით
 GenericName[ka]=BitTorrent კლიენტი
 Name[ka]=qBittorrent
-Comment[ko]=BitTorrent를 통해 파일 다운로드 및 공유
+Comment[ko]=비트토런트를 통해 파일을 다운로드하고 공유합니다
-GenericName[ko]=BitTorrent 클라이언트
+GenericName[ko]=비트토런트 클라이언트
-Name[ko]=qBittorrent
+Name[ko]=큐빗토런트
+Comment[zh]=通过 BitTorrent 下载和分享文件
+GenericName[zh]=BitTorrent 客户端
+Name[zh]=qBittorrent
 Comment[lt]=Atsisiųskite bei dalinkitės failais BitTorrent tinkle
 GenericName[lt]=BitTorrent klientas
 Name[lt]=qBittorrent
-Comment[mk]=Превземајте и споделувајте фајлови преку BitTorrent
-GenericName[mk]=BitTorrent клиент
-Name[mk]=qBittorrent
-Comment[my]=တောရန့်ဖြင့်ဖိုင်များဒေါင်းလုဒ်ဆွဲရန်နှင့်မျှဝေရန်
-GenericName[my]=တောရန့်စီမံခန့်ခွဲသည့်အရာ
-Name[my]=qBittorrent
 Comment[nb]=Last ned og del filer over BitTorrent
 GenericName[nb]=BitTorrent-klient
 Name[nb]=qBittorrent
+Comment[nqo]=ߞߐߕߐ߯ߘߐ ߟߎ߬ ߟߊߖߌ߰ ߞߊ߬ ߓߊ߲߫ ߞߵߊ߬ߟߎ߬ ߘߐߕߟߊ߫ ߓߌߙߏߙߍ߲ߕ ߞߊ߲߬
+GenericName[nqo]=ߓߌߙߏߙߍ߲ߕ ߕߣߐ߬ߓߐ߬ߟߊ
+Name[nqo]=ߞߎ߳ߓߌߕߏߙߍ߲ߕ
 Comment[nl]=Bestanden downloaden en delen via BitTorrent
-GenericName[nl]=BitTorrent-client
+GenericName[nl]=BitTorrent-cliënt
 Name[nl]=qBittorrent
 Comment[pl]=Pobieraj i dziel się plikami przez BitTorrent
 GenericName[pl]=Klient BitTorrent
@@ -130,14 +121,14 @@ Name[pl]=qBittorrent
 Comment[pt]=Transferir e partilhar ficheiros por BitTorrent
 GenericName[pt]=Cliente BitTorrent
 Name[pt]=qBittorrent
-Comment[pt_BR]=Baixe e compartilhe arquivos pelo BitTorrent
+Comment[pt_BR]=Baixe e compartilhe arquivos por BitTorrent
 GenericName[pt_BR]=Cliente BitTorrent
 Name[pt_BR]=qBittorrent
 Comment[ro]=Descărcați și partajați fișiere prin BitTorrent
 GenericName[ro]=Client BitTorrent
 Name[ro]=qBittorrent
-Comment[ru]=Обмен файлами по сети БитТоррент
+Comment[ru]=Скачивайте и делитесь файлами с помощью BitTorrent
-GenericName[ru]=Клиент сети БитТоррент
+GenericName[ru]=BitTorrent-клиент
 Name[ru]=qBittorrent
 Comment[sk]=Sťahovanie a zdieľanie súborov prostredníctvom siete BitTorrent
 GenericName[sk]=Klient siete BitTorrent
@@ -145,36 +136,30 @@ Name[sk]=qBittorrent
 Comment[sl]=Prenesite in delite datoteke preko BitTorrenta
 GenericName[sl]=BitTorrent odjemalec
 Name[sl]=qBittorrent
-Name[sq]=qBittorrent
-Comment[sr]=Преузимајте и делите фајлове преко BitTorrent протокола
 GenericName[sr]=BitTorrent-клијент
-Name[sr]=qBittorrent
 Comment[sr@latin]=Preuzimanje i deljenje fajlova preko BitTorrent-a
 GenericName[sr@latin]=BitTorrent klijent
 Name[sr@latin]=qBittorrent
 Comment[sv]=Hämta och dela filer över BitTorrent
 GenericName[sv]=BitTorrent-klient
 Name[sv]=qBittorrent
-Comment[ta]=BitTorrent வழியாக கோப்புகளை பதிவிறக்க மற்றும் பகிர
+Comment[uz@Latn]=BitTorrent orqali fayllarni yuklab olish va baham ko‘rish
-GenericName[ta]=BitTorrent வாடிக்கையாளர்
+GenericName[uz@Latn]=BitTorrent mijozi
-Name[ta]=qBittorrent
+Name[uz@Latn]=qBittorrent
 Comment[te]=క్యు  బిట్ టొరెంట్ తో ఫైల్స్ దిగుమతి చేసుకోండి , పంచుకోండి
-GenericName[te]=క్యు  బిట్ టొరెంట్ క్లయింట్
+GenericName[te]=క్యు  బిట్ టొరెంట్ క్లయింట్ 
-Name[te]=qBittorrent
+Name[te]=క్యు  బిట్ టొరెంట్
-Comment[th]=ดาวน์โหลดและแชร์ไฟล์ผ่าน BitTorrent
+Comment[hi_IN]= अपनी फाइलें BitTorrent के माध्यम से डाउनलोड आैर साॅझा करें
-GenericName[th]=ไคลเอนต์ BitTorrent
+GenericName[hi_IN]=BitTorrent उपभोक्ता
-Name[th]=qBittorrent
+Name[hi_IN]=qBittorrent
 Comment[tr]=Dosyaları BitTorrent üzerinden indirin ve paylaşın
 GenericName[tr]=BitTorrent istemcisi
 Name[tr]=qBittorrent
-Comment[ur]=BitTorrent پر فائلوں کو ڈاؤن لوڈ کریں اور اشتراک کریں
+Comment[uk]=Завантажувати і обмінюватися файлами через BitTorrent
-GenericName[ur]=قیو بٹ ٹورنٹ   کلائنٹ
-Name[ur]=qBittorrent
-Comment[uk]=Завантажуйте та поширюйте файли через BitTorrent
 GenericName[uk]=BitTorrent-клієнт
 Name[uk]=qBittorrent
-Comment[vi]=Tải về và chia sẻ tệp qua BitTorrent
+Comment[vi]=Tải về và chia sẻ các tập tin thông qua BitTorrent
-GenericName[vi]=Máy khách BitTorrent
+GenericName[vi]=Máy trạm dạng BitTorrent
 Name[vi]=qBittorrent
 Comment[zh_HK]=經由BitTorrent下載並分享檔案
 GenericName[zh_HK]=BitTorrent用戶端
@@ -182,50 +167,24 @@ Name[zh_HK]=qBittorrent
 Comment[zh_TW]=經由 BitTorrent 下載並分享檔案
 GenericName[zh_TW]=BitTorrent 客戶端
 Name[zh_TW]=qBittorrent
-Comment[eo]=Elŝutu kaj kunhavigu dosierojn per BitTorrent
-GenericName[eo]=BitTorrent-kliento
-Name[eo]=qBittorrent
-Comment[kk]=BitTorrent арқылы файл жүктеу және бөлісу
-GenericName[kk]=BitTorrent клиенті
-Name[kk]=qBittorrent
-Comment[en_AU]=Download and share files over BitTorrent
-GenericName[en_AU]=BitTorrent client
-Name[en_AU]=qBittorrent
-Name[rm]=qBittorrent
-Name[jv]=qBittorrent
-Comment[oc]=Telecargar e partejar de fichièrs amb BitTorrent
-GenericName[oc]=Client BitTorrent
-Name[oc]=qBittorrent
-Name[ug]=qBittorrent
-Name[yi]=qBittorrent
-Comment[nqo]=ߞߐߕߐ߯ߘߐ ߟߎ߬ ߟߊߖߌ߰ ߞߊ߬ ߓߊ߲߫ ߞߵߊ߬ߟߎ߬ ߘߐߕߟߊ߫ ߓߌߙߏߙߍ߲ߕ ߞߊ߲߬
-GenericName[nqo]=ߓߌߙߏߙߍ߲ߕ ߕߣߐ߬ߓߐ߬ߟߊ
-Name[nqo]=qBittorrent
-Comment[uz@Latn]=BitTorrent orqali fayllarni yuklab olish va baham ko‘rish
-GenericName[uz@Latn]=BitTorrent mijozi
-Name[uz@Latn]=qBittorrent
-Comment[ltg]=Atsasyuteit i daleit failus ar BitTorrent
-GenericName[ltg]=BitTorrent klients
-Name[ltg]=qBittorrent
-Comment[hi_IN]=BitTorrent द्वारा फाइल डाउनलोड व सहभाजन
-GenericName[hi_IN]=Bittorrent साधन
-Name[hi_IN]=qBittorrent
-Comment[az@latin]=Faylları BitTorrent vasitəsilə göndərin və paylaşın
-GenericName[az@latin]=BitTorrent client
-Name[az@latin]=qBittorrent
 Comment[lv_LV]=Lejupielādēt un koplietot failus ar BitTorrent
 GenericName[lv_LV]=BitTorrent klients
 Name[lv_LV]=qBittorrent
 Comment[ms_MY]=Muat turun dan kongsi fail melalui BitTorrent
 GenericName[ms_MY]=Klien BitTorrent
 Name[ms_MY]=qBittorrent
-Comment[mn_MN]=BitTorrent-оор файлуудаа тат, түгээ
+Comment[eo]=Elŝutu kaj kunhavigu dosierojn per BitTorrent
-GenericName[mn_MN]=BitTorrent татагч
+GenericName[eo]=BitTorrent-kliento
+Name[eo]=qBittorrent
+Comment[mn_MN]=BitTorrent ашиглан файлуудыг татаж түгээх
+GenericName[mn_MN]=BitTorrent үйлчлүүлэгч
 Name[mn_MN]=qBittorrent
 Comment[ne_NP]=फाइलहरू डाउनलोड गर्नुहोस् र BitTorrent मा साझा गर्नुहोस्
 GenericName[ne_NP]=BitTorrent क्लाइन्ट
 Name[ne_NP]=qBittorrent
-Comment[pt_PT]=Transferir e partilhar ficheiros por BitTorrent
+Comment[en_AU]=Download and share files over BitTorrent
-GenericName[pt_PT]=Cliente BitTorrent
+GenericName[en_AU]=BitTorrent client
-Name[pt_PT]=qBittorrent
+Name[en_AU]=qBittorrent
-Name[si_LK]=qBittorrent
+Comment[th]=ดาว์นโหลดและแชร์ไฟล์ด้วยบิททอเร้น
+GenericName[th]=โปรแกรมบิททอเร้น
+Name[th]=qBittorrent

dist/unix/systemd/qbittorrent-nox@.service.in

@@ -2,14 +2,13 @@
 Description=qBittorrent-nox service for user %I
 Documentation=man:qbittorrent-nox(1)
 Wants=network-online.target
-After=local-fs.target network-online.target nss-lookup.target
+After=network-online.target nss-lookup.target
 
 [Service]
 Type=simple
 PrivateTmp=false
 User=%i
 ExecStart=@EXPAND_BINDIR@/qbittorrent-nox
-TimeoutStopSec=1800
 
 [Install]
 WantedBy=multi-user.target

dist/windows/README.txt

@@ -8,8 +8,7 @@ TRANSLATORS:
    english message to help you with the translation.
 4. Edit only the part inside the quotation marks(""). Unless you know
    what you are doing.
-5. Save the files with UTF-8 encoding, without BOM
+5. Save the files with utf8 encoding and BOM.
-   (this should be the default in any modern text editor).
 6. Submit your changes: 1) as a pull request to the official git repo or
    2) open an issue to the bugtracker and attach them or 3) via email or
    4)the same way you provide the translations for qbt itself

dist/windows/UAC.nsh

@@ -22,7 +22,7 @@ Interactive User (MediumIL)        Admin user (HighIL)
 !ifndef UAC_HDR__INC
 !verbose push
 !verbose 3
-!ifndef UAC_VERBOSE
+!ifndef UAC_VERBOSE  
 	!define UAC_VERBOSE 3
 !endif
 !verbose ${UAC_VERBOSE}
@@ -195,7 +195,7 @@ _UAC_L_E_${__UAC_L}:
 !endif
 !insertmacro UAC_AsUser_Call Label _UAC_L_F_${__UAC_L} ${UAC_SYNCREGISTERS}|${UAC_SYNCOUTDIR}|${UAC_SYNCINSTDIR} #|${UAC_CLEARERRFLAG}
 !if "${workdir}" != ""
-	pop $outdir
+	pop $outdir 
 	SetOutPath $outdir
 !endif
 !macroend
@@ -265,7 +265,7 @@ pop $_LOGICLIB_TEMP
 !macroend
 !macro _UAC_AsUser_GenOp outvar op opparam1 opparam2
 !define _UAC_AUGOGR_ID _UAC_AUGOGR_OP${outvar}${op}${opparam1}${opparam2}
-!ifndef ${_UAC_AUGOGR_ID} ;Has this exact action been done before?
+!ifndef ${_UAC_AUGOGR_ID} ;Has this exact action been done before? 
 	!if ${outvar} == $0
 		!define ${_UAC_AUGOGR_ID} $1
 	!else
@@ -277,7 +277,7 @@ pop $_LOGICLIB_TEMP
 	!else
 		!define _UAC_AUGOGR_OPP1 ${opparam1}
 		!define _UAC_AUGOGR_OPP2 ${${_UAC_AUGOGR_ID}}
-	!endif
+	!endif	
 	goto ${_UAC_AUGOGR_ID}_C
 	${_UAC_AUGOGR_ID}_F:
 		${op} ${_UAC_AUGOGR_OPP1} ${_UAC_AUGOGR_OPP2}
@@ -296,4 +296,4 @@ pop ${${_UAC_AUGOGR_ID}}
 
 
 !verbose pop
-!endif /* UAC_HDR__INC */
+!endif /* UAC_HDR__INC */

dist/windows/installer-translations/afrikaans.nsi

@@ -1,4 +1,4 @@
-;Installer strings
+;Installer strings
 
 ;LangString inst_qbt_req ${LANG_ENGLISH} "qBittorrent (required)"
 LangString inst_qbt_req ${LANG_AFRIKAANS} "qBittorrent (required)"
@@ -30,8 +30,7 @@ LangString launch_qbt ${LANG_AFRIKAANS} "Launch qBittorrent."
 LangString inst_requires_64bit ${LANG_AFRIKAANS} "This installer works only in 64-bit Windows versions."
 ;LangString inst_requires_win7 ${LANG_ENGLISH} "This qBittorrent version requires at least Windows 7."
 LangString inst_requires_win7 ${LANG_AFRIKAANS} "This qBittorrent version requires at least Windows 7."
-;LangString inst_uninstall_link_description ${LANG_ENGLISH} "Uninstall qBittorrent"
+
-LangString inst_uninstall_link_description ${LANG_AFRIKAANS} "Uninstall qBittorrent"
 
 ;------------------------------------
 ;Uninstaller strings

dist/windows/installer-translations/albanian.nsi

@@ -1,4 +1,4 @@
-;Installer strings
+;Installer strings
 
 ;LangString inst_qbt_req ${LANG_ENGLISH} "qBittorrent (required)"
 LangString inst_qbt_req ${LANG_ALBANIAN} "qBittorrent (required)"
@@ -30,8 +30,7 @@ LangString launch_qbt ${LANG_ALBANIAN} "Launch qBittorrent."
 LangString inst_requires_64bit ${LANG_ALBANIAN} "This installer works only in 64-bit Windows versions."
 ;LangString inst_requires_win7 ${LANG_ENGLISH} "This qBittorrent version requires at least Windows 7."
 LangString inst_requires_win7 ${LANG_ALBANIAN} "This qBittorrent version requires at least Windows 7."
-;LangString inst_uninstall_link_description ${LANG_ENGLISH} "Uninstall qBittorrent"
+
-LangString inst_uninstall_link_description ${LANG_ALBANIAN} "Uninstall qBittorrent"
 
 ;------------------------------------
 ;Uninstaller strings

dist/windows/installer-translations/arabic.nsi

@@ -1,4 +1,4 @@
-;Installer strings
+;Installer strings
 
 ;LangString inst_qbt_req ${LANG_ENGLISH} "qBittorrent (required)"
 LangString inst_qbt_req ${LANG_ARABIC} "qBittorrent (مطلوب)"
@@ -30,8 +30,7 @@ LangString launch_qbt ${LANG_ARABIC} "تشغيل البرنامج"
 LangString inst_requires_64bit ${LANG_ARABIC} "هذا المثبت يعمل فقط في نسخ ويندوز 64 بت"
 ;LangString inst_requires_win7 ${LANG_ENGLISH} "This qBittorrent version requires at least Windows 7."
 LangString inst_requires_win7 ${LANG_ARABIC} "This qBittorrent version requires at least Windows 7."
-;LangString inst_uninstall_link_description ${LANG_ENGLISH} "Uninstall qBittorrent"
+
-LangString inst_uninstall_link_description ${LANG_ARABIC} "Uninstall qBittorrent"
 
 ;------------------------------------
 ;Uninstaller strings

dist/windows/installer-translations/basque.nsi

@@ -1,4 +1,4 @@
-;Installer strings
+;Installer strings
 
 ;LangString inst_qbt_req ${LANG_ENGLISH} "qBittorrent (required)"
 LangString inst_qbt_req ${LANG_BASQUE} "qBittorrent (beharrezkoa)"
@@ -30,8 +30,7 @@ LangString launch_qbt ${LANG_BASQUE} "Abiarazi qBittorrent."
 LangString inst_requires_64bit ${LANG_BASQUE} "This installer works only in 64-bit Windows versions."
 ;LangString inst_requires_win7 ${LANG_ENGLISH} "This qBittorrent version requires at least Windows 7."
 LangString inst_requires_win7 ${LANG_BASQUE} "This qBittorrent version requires at least Windows 7."
-;LangString inst_uninstall_link_description ${LANG_ENGLISH} "Uninstall qBittorrent"
+
-LangString inst_uninstall_link_description ${LANG_BASQUE} "Uninstall qBittorrent"
 
 ;------------------------------------
 ;Uninstaller strings

dist/windows/installer-translations/belarusian.nsi

@@ -1,4 +1,4 @@
-;Installer strings
+;Installer strings
 
 ;LangString inst_qbt_req ${LANG_ENGLISH} "qBittorrent (required)"
 LangString inst_qbt_req ${LANG_BELARUSIAN} "qBittorrent (required)"
@@ -30,8 +30,7 @@ LangString launch_qbt ${LANG_BELARUSIAN} "Launch qBittorrent."
 LangString inst_requires_64bit ${LANG_BELARUSIAN} "This installer works only in 64-bit Windows versions."
 ;LangString inst_requires_win7 ${LANG_ENGLISH} "This qBittorrent version requires at least Windows 7."
 LangString inst_requires_win7 ${LANG_BELARUSIAN} "This qBittorrent version requires at least Windows 7."
-;LangString inst_uninstall_link_description ${LANG_ENGLISH} "Uninstall qBittorrent"
+
-LangString inst_uninstall_link_description ${LANG_BELARUSIAN} "Uninstall qBittorrent"
 
 ;------------------------------------
 ;Uninstaller strings