Chocobo1
c21bd77be5
Remove unnecessary dynamic allocation
...
Also remove unneeded `if ()` conditional.
2018-08-12 11:08:06 +03:00
Chocobo1
d5430adaaa
Avoid binding constant reference to returned object
...
In such cases, it makes no sense doing so.
2018-08-12 11:08:06 +03:00
Chocobo1
9e99a0d3f5
Replace single-character string with character literal
...
Also remove unnecessary dynamic allocation.
2018-08-12 11:08:06 +03:00
sledgehammer999
d088ab6f43
Remove trailing dot from headings
2018-08-12 11:08:06 +03:00
sledgehammer999
820d510c12
Add a TOC in the coding guidelines
2018-08-12 11:08:06 +03:00
Chocobo1
676847fcd0
Add options in AddNewTorrentDialog
...
The new checkboxes are: "Download in sequential order", "Download first
and last pieces first".
2018-08-12 11:08:06 +03:00
Chocobo1
0204630ee6
Revise dialog messages
...
Using critical dialog is a bit too strong as qbt didn't actually run
into something that fails, so downgrade to warning dialog.
2018-08-12 11:08:06 +03:00
Chocobo1
b515c7eda4
Fix typo
2018-08-12 11:08:06 +03:00
Chocobo1
73fcecac76
Simplify code
...
This avoids "deferencing null pointer" warning from static analyzers.
2018-08-12 11:08:06 +03:00
Chocobo1
a7b82ebcb5
Cache more preference values
...
These values from Preference class are frequently used.
Also group related variables together.
2018-08-12 11:08:06 +03:00
Eugene Shalygin
f8598b010d
Use proper include files in the QtSingleApplication find module.
...
Look for qtsinglecoreapplication.h when Qt5Widgets module was not found,
and qtsingleapplication.h otherwise. Fixes #9196 .
This also removes Qt4 support from the QtSingleApplication find module.
2018-08-12 11:08:06 +03:00
Vladimir Golovnev (Glassez)
93779bcc4b
Download favicon using appropriate protocol
...
Some trackers use UDP protocol but we can't download its favicon
using UDP. Just try to download it using HTTP.
2018-08-12 11:08:06 +03:00
Vladimir Golovnev (Glassez)
938f5b9dd9
Apply proxy settings on DownloadManager creation
2018-08-12 11:08:06 +03:00
Vladimir Golovnev (Glassez)
3b4d9f49d5
Improve torrent initialization
...
Don't post "torrent resumed" event when torrent starts in "resumed"
state.
Fix confusing names. Now "resumed torrent" means "unpaused torrent"
only. When we load previously added torrent it is called "restored
torrent".
2018-08-12 11:08:06 +03:00
Vladimir Golovnev (Glassez)
171c93af50
Save resume data on torrent change events
...
Closes #9174 .
2018-08-12 11:08:06 +03:00
sledgehammer999
6f81e40106
Revert email address changes in copyright notices
2018-08-12 11:08:06 +03:00
tjjh89017
e19b5cb2ce
Add async io threads option to AdvancedSettings
2018-08-12 11:08:06 +03:00
Chocobo1
2c69faca58
Allow save resume interval to be disabled
...
Also raise the allowable upper limit
2018-08-12 11:08:06 +03:00
Chocobo1
9272151d0a
Prolong resume data save interval
2018-08-12 11:08:06 +03:00
Chocobo1
d45ebf5a43
Remove unnecessary resources inclusion
2018-08-12 11:08:06 +03:00
thalieht
8074be7644
Delete several unused #include
2018-08-12 11:08:06 +03:00
thalieht
c99ac99a99
Fix coding style
2018-08-12 11:08:06 +03:00
thalieht
976e2450ec
Convert the names used in ui and c++ files from snake_case to camelCase
2018-08-12 11:08:06 +03:00
Chocobo1
7e4db8fafd
Fix python version detection
...
Closes #9146 .
2018-08-12 11:08:06 +03:00
Chocobo1
115a409d92
Clear python cache conditionally
...
Clear the cache artifacts on plugin install and plugin uninstall events.
2018-08-12 11:08:06 +03:00
Chocobo1
c203ab3d16
Refactor function
...
In SearchPluginManager::updateNova(), omit removing __pycache__ folder and pyc
files, those files will be recreated anyway.
Add const to variables
2018-08-12 11:08:06 +03:00
Chocobo1
5dff96496d
Rename function
2018-08-12 11:08:06 +03:00
Chocobo1
f813935011
Cache SearchPluginManager::engineLocation() result
...
Also the folder is only created on first usage.
2018-08-12 11:08:06 +03:00
Chocobo1
2be719449f
Replace less-efficient QProcess::setEnvironment
...
Also small refactor
2018-08-12 11:08:06 +03:00
Chocobo1
2094c870d5
Simplify function
2018-08-12 11:08:06 +03:00
Chocobo1
4fe93ae8b8
Add checkbox for recursive download dialog
...
Also group similar options together.
2018-08-12 11:08:06 +03:00
Chocobo1
fff1103cf4
Work around crash when procesing recursive download
...
The messagebox is modal and exec() it makes it generates a new local
event loop, however the new local event loop will continue to process
libtorrent events (in Session::readAlerts()), at the time exec()
returns, the original libt::alert pointers are lost and resume
processing alerts will cause the crash.
One solution is to make the messagebox use show() and avoid exec().
Closes #9086 .
2018-08-12 11:08:06 +03:00
Vladimir Golovnev (Glassez)
8cede43a45
Make TorrentInfo loading behavior uniform
2018-08-12 11:08:06 +03:00
Vladimir Golovnev (Glassez)
9b1fa3a5af
Use new DownloadManager interface
2018-08-12 11:08:06 +03:00
Vladimir Golovnev (Glassez)
409e73c074
Implement "Sequential downloading" feature
...
Closes #6835 .
2018-08-12 11:08:06 +03:00
Vladimir Golovnev (Glassez)
c893729d62
Implement DownloadRequest helper
2018-08-12 11:08:06 +03:00
Chocobo1
945466968c
Reduce queries to python version
...
Instead of doing at least 2 queries for python infos, now requires only
1 query (in ideal condition), and the result is cached.
2018-08-12 11:08:06 +03:00
Chocobo1
54f080b755
Move related functions to Utils::Python
2018-08-12 11:08:06 +03:00
Goshik
bfad14d552
Create non-existing path in setLocationAction()
...
When using qbittorrent-nox it is not always possible to manually create
the target path for torrent moving. This commit allows automatic path
creation. It also allows to display error messages in the
'Set location' window.
2018-08-12 11:08:06 +03:00
Chocobo1
2972e1596d
Move optimization flags
...
Those flags aren't strictly required when compiling but they are
recommended to be on.
2018-08-12 11:08:06 +03:00
Chocobo1
987d2aae88
Turn on Control Flow Guard for MSVC builds
...
The performance impact should be negligible according to the
documentation on msdn.
Closes #9101 .
2018-08-12 11:08:06 +03:00
hannsen
4707d34fad
Properly normalize version string before parsing it
...
This allows python scripts to be formatted in PEP 8 style.
2018-08-12 11:08:06 +03:00
Chocobo1
2ffc09d097
Move qm_gen.pri
2018-08-12 11:08:06 +03:00
Chocobo1
afa8d6bb8f
Move .desktop file
2018-08-12 11:08:06 +03:00
Chocobo1
a37ead98e8
Move .ico files into icons dir
2018-08-12 11:08:06 +03:00
Chocobo1
c73cd8d618
Move .qrc files into its own directory
2018-08-12 11:08:06 +03:00
thalieht
800a3aa61e
Change file names and classes names to match them
2018-08-12 11:08:06 +03:00
Thomas Piccirello
ebd815be75
Add WebUI support for Mac ⌘ (Command) key
...
The Command key will now be recognized for WebUI Table multi-selection, as Ctrl is.
2018-08-12 11:08:06 +03:00
Thomas Piccirello
ef669acf89
Implement key functions in Class and refactor
2018-08-12 11:08:06 +03:00
thalieht
ac6426eab1
Fix coding style
2018-08-12 11:08:06 +03:00
